• Joined on 2025-08-21
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-15 06:32:36 +00:00
bd9fd5cd3c Revert "fix matrix / db resource cleanup on space unlink"
Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:51:25 +00:00
feat/add-unlink-space-button

Also, this line causes issue when running the test.

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:47:19 +00:00
feat/add-unlink-space-button

Also, I'm not sure about what's the deal with 0f2e575df21bf940e4780c30d2701da989f62471 The issue is explained in the deleted comment from this commit

I added await on db operations and that…

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:45:23 +00:00
feat/add-unlink-space-button

Not for now but opening the discussion for another day:

As we are leaving rooms / spaces, we might be leaving rooms and spaces, leaving them with no admin (especially in easy mode where if…

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:42:25 +00:00
feat/add-unlink-space-button

I also pushed 0f2e575df21bf940e4780c30d2701da989f62471 to demote bridge user power level, tell me if you'd rather like to have it on a dedicated MR or not, it can be removed from this one

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:41:09 +00:00
feat/add-unlink-space-button

Ok, I just pushed doing a full clean of guild_space, guild_active, invite, and leaving the discord server.

The clean of invite is not strictly necessary, but I you don't clean it, it…

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:34:26 +00:00
feat/add-unlink-space-button

The test deletes the row above, to test for checks. But as I added more tests below related to unlinking, if this is kept deleted, then this cause issues because of inconsistent DB. So I…

Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-04 15:32:16 +00:00
b45eeb150e manually revert 3597a3b: "Factorize some of the space link/unlink sanity checks"
0f2e575df2 on unbriding room, also demote powel level of bridge user in matrix room
ccc10564f1 fix matrix / db resource cleanup on space unlink
f4c1ea7c7f /unlink-space: properly leave guild and clean DB
Compare 4 commits »
Elliu commented on pull request cadence/out-of-your-element#63 2025-11-04 15:22:40 +00:00
feat/add-unlink-space-button

About the quoted code, I'm not sure why it doesn't appear on the quote, but I replaced it with a

	const guild = await validateGuildAccess(event, guildID)

so the error was still being…

Elliu commented on pull request cadence/out-of-your-element#63 2025-11-01 13:43:24 +00:00
feat/add-unlink-space-button

Hi, there is this issue here, I'm not sure what would be the best thing to do with this situation, please let me know if you have any ideas of what should be best

Elliu created pull request cadence/out-of-your-element#63 2025-11-01 13:40:53 +00:00
feat/add-unlink-space-button
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-01 13:36:55 +00:00
10d14bbdaa add tests from /unlink-space endpoint
677d899a92 Fill in more of reg for other people to test with (cherry pick to run
9492137ca6 Add /api/unlink-space implementation
6aa2bfad13 Extract /api/unlink code to its own function
Compare 4 commits »
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-01 13:34:21 +00:00
6ecc8167b2 add tests from /unlink-space endpoint
1413e76ed6 Fill in more of reg for other people to test with
2f830daab4 Add /api/unlink-space implementation
013260e970 Extract /api/unlink code to its own function
fc8d400b7d Factorize some of the space link/unlink sanity checks
Compare 5 commits »
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-11-01 12:03:22 +00:00
255d963049 WIP: add tests for /api/unlink-space
b1d271eb21 Add /api/unlink-space implementation
cd20495b11 Extract /api/unlink code to its own function
673871ce67 Factorize some of the space link/unlink sanity checks
e0c449dc1f Fill in more of reg for other people to test with
Compare 16 commits »
Elliu pushed to fix-remote-join at Elliu/out-of-your-element 2025-11-01 12:02:33 +00:00
ab69eab8a4 Fix tests for new link space error message
717dc185e5 Misc. fixes for remote join
7932f8af85 Add "please try invite" message when joinRoom in /api/link-space fails
0776cc6ccd Fill in more of reg for other people to test with
e7b4dfea9c Fix /api/link-space joinRoom() for remote spaces
Compare 19 commits »
Elliu commented on pull request cadence/out-of-your-element#60 2025-10-09 12:55:43 +00:00
Fix matrix api joinRoom() for remote rooms

Updated, had to add a null coalescing or else linter complains about array of string OR undefined a few lines below

Elliu pushed to fix-remote-join at Elliu/out-of-your-element 2025-10-09 12:54:34 +00:00
23d87fb9a4 Misc. fixes for remote join
Elliu commented on pull request cadence/out-of-your-element#60 2025-10-09 12:42:12 +00:00
Fix matrix api joinRoom() for remote rooms

Yeah, I don't know. The idea at the back of my mind was a weird state that could happen if:

  1. Space is not on the same HS than bridge
  2. Bridge is invited / join the space
  3. User kicks /…
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-09-07 06:34:52 +00:00
16a9c643b8 WIP: add tests for /api/unlink-space
Elliu pushed to feat/add-unlink-space-button at Elliu/out-of-your-element 2025-09-07 05:36:33 +00:00
bbe416a42e Add /api/unlink-space implementation