w/youtube-dl
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Revert "[postprocessor/embedthumbnail] Allow mkv to embed thumbnails"

Browse source 
This reverts commit 7360db05b4.

This commit was added as an attempt to fix #6046. Unfortunately, the fix
is completely wrong. As reported on #10359, embedded thumbnails are not
displayed in VLC, and Se7en on IRC reports that the embedded thumbnail
misleads mpv as well.

The correct way is using -attachment of ffmpeg, while the current
run_ffmpeg_multiple_files API can't handle it cleanly.
This commit is contained in:
Yen Chi Hsuan 2016-10-20 15:07:19 +08:00
parent 19e447150d
commit 8e2915d70b
No known key found for this signature in database
GPG key ID: 3FDDD575826C5C30
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
youtube_dl/postprocessor/embedthumbnail.py
View file

@ -40,7 +40,7 @@ class EmbedThumbnailPP(FFmpegPostProcessor):
'Skipping embedding the thumbnail because the file is missing.') 'Skipping embedding the thumbnail because the file is missing.')
return [], info return [], info
if info['ext'] in ('mp3', 'mkv'): if info['ext'] == 'mp3':
options = [ options = [
'-c', 'copy', '-map', '0', '-map', '1', '-c', 'copy', '-map', '0', '-map', '1',
'-metadata:s:v', 'title="Album cover"', '-metadata:s:v', 'comment="Cover (Front)"'] '-metadata:s:v', 'title="Album cover"', '-metadata:s:v', 'comment="Cover (Front)"']