[utils] Don't attempt to coerce JS strings to numbers in js_to_json (#26851)
The current logic in `js_to_json` tries to rewrite octal/hex numbers to
decimal. However, when the logic actually happens the `"` or `'` have
already been trimmed off. This causes what were originally strings, that
happen to look like octal/hex numbers, to get rewritten to decimal and
returned as a number rather than a string.
In practive something like:
```js
{
  "0x40": "foo",
  "040": "bar",
}
```
would get rewritten as:
```json
{
  64: "foo",
  32: "bar
}
```
This is problematic since this isn't valid JSON as you cannot have
non-string keys.
			
			
This commit is contained in:
		
							parent
							
								
									605535776a
								
							
						
					
					
						commit
						4eda10499e
					
				
					 2 changed files with 12 additions and 6 deletions
				
			
		| 
						 | 
				
			
			@ -4088,12 +4088,12 @@ def js_to_json(code):
 | 
			
		|||
                '\\\n': '',
 | 
			
		||||
                '\\x': '\\u00',
 | 
			
		||||
            }.get(m.group(0), m.group(0)), v[1:-1])
 | 
			
		||||
 | 
			
		||||
        for regex, base in INTEGER_TABLE:
 | 
			
		||||
            im = re.match(regex, v)
 | 
			
		||||
            if im:
 | 
			
		||||
                i = int(im.group(1), base)
 | 
			
		||||
                return '"%d":' % i if v.endswith(':') else '%d' % i
 | 
			
		||||
        else:
 | 
			
		||||
            for regex, base in INTEGER_TABLE:
 | 
			
		||||
                im = re.match(regex, v)
 | 
			
		||||
                if im:
 | 
			
		||||
                    i = int(im.group(1), base)
 | 
			
		||||
                    return '"%d":' % i if v.endswith(':') else '%d' % i
 | 
			
		||||
 | 
			
		||||
        return '"%s"' % v
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue