-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates and Chillx Extractor Updated #1065
Conversation
Remove Log Import
Update for Chillx Thanks to @Rowdy for Key update
).text | ||
)?.groupValues?.get(1) | ||
val decrypt = cryptoAESHandler(master ?: return, getKey().toByteArray(), false)?.replace("\\", "") ?: throw ErrorLoadingException("failed to decrypt") | ||
|
||
val key = app.get("https://raw.githubusercontent.com/rushi-chavan/multi-keys/keys/keys.json").parsedSafe<Keys>()?.key?.get(0) ?: throw ErrorLoadingException("Unable to get key") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this cached, we dont want to ddos github for every url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have assigned that as key url as it can be updated and previously as well its fetching from a Github json hosted on github so do you want me to assign key static in Extractor ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several other extractors using GitHub links. We might have to work on them as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phisher98 What I mean is that you should do something like this, as then you dont have to do an extra get request for every time you use this extractor
companion object {
private val key : String? = null
suspend fun getKey() {
key ?: app.get("...").parsedSafe<Keys>()?.key?.get(0)?.also { key = it }
}
}
private var key: String? = null val key = fetchKey() ?: throw ErrorLoadingException("Unable to get key") val decrypt = cryptoAESHandler(master ?: return, key.toByteArray(), false) private suspend fun fetchKey(): String? { @phisher98 try this |
@b4byhuey Yeah That what i was saying but Thanks for the help |
The key is still not cached |
Updates and Chillx Extractor Updated
Kudos to @rushi-chavan for updated Keys