Extractor: new VidSrcTo extractor

[rushi-chavan]

This also creates NewVidplay extractor which is adaptive as you can pass hostUrl to it before calling getUrl to migrate changing domain URLs.
NewVidplay().getUrl(.....)

[rushi-chavan]

@fire-light42 can you please have a look now?
I tried to reduce few if statements but if(status == 200) seems mandatory cause there is nothing to return when status != 200.
so I don't understand the need of if (res.status != 200) return

[fire-light42]

@fire-light42 can you please have a look now? I tried to reduce few if statements but if(status == 200) seems mandatory cause there is nothing to return when status != 200. so I don't understand the need of if (res.status != 200) return

You want to flatten the code as much as possible, here is an example on how I would do it

app.get(url).document.selectFirst("ul.episodes li a")?.attr("data-id")?.let { mediaId ->
    val res = app.get("$mainUrl/ajax/embed/episode/$mediaId/sources").parsedSafe<VidsrctoEpisodeSources>()
    if (res?.status == 200) {
        res.result?.amap { source ->
            val embedRes = app.get("$mainUrl/ajax/embed/source/${source.id}").parsedSafe<VidsrctoEmbedSource>()
            val finalUrl = DecryptUrl(embedRes?.result?.encUrl ?: "")
            when (source.title) {
                "Vidplay" -> AnyVidplay(finalUrl.substringBefore("/e/")).getUrl(finalUrl, referer, subtitleCallback, callback)
                "Filemoon" -> FileMoon().getUrl(finalUrl, referer, subtitleCallback, callback)
            }
        }
    }
}

into

val mediaId = app.get(url).document.selectFirst("ul.episodes li a")?.attr("data-id") ?: return
val res = app.get("$mainUrl/ajax/embed/episode/$mediaId/sources").parsedSafe<VidsrctoEpisodeSources>() ?: return
if (res.status != 200) return
res.result?.amap { source ->
    val embedRes = app.get("$mainUrl/ajax/embed/source/${source.id}").parsedSafe<VidsrctoEmbedSource>() ?: return@amap
    val finalUrl = DecryptUrl(embedRes.result.encUrl)
    when (source.title) {
        "Vidplay" -> AnyVidplay(finalUrl.substringBefore("/e/")).getUrl(finalUrl, referer, subtitleCallback, callback)
        "Filemoon" -> FileMoon().getUrl(finalUrl, referer, subtitleCallback, callback)
    }
}

[rushi-chavan]

@fire-light42 Thank you so much for telling me how to flat the code> I really appreciate your help.
Please have a look at the updated changes and let me know if any issue with it.

Also, I am including another change related to TmdbProvider in this PR. c363596
Please have a look at this as well.

[fire-light42]

The code looks fine, just want to make sure that it can handle an extra edgecase

[fire-light42]

I did not catch this in the first review, however when looking at the code a bit more, can this at any point cause an infinite loop? If it can, detect it and throw an exception/return.

We can catch exceptions, but not inf recursion. Can you just do a assert(finalUrl != url) or smth along those lines.

[fire-light42]

Your commit to the TmdbProvider looks good, but I dont see the pr.

[fire-light42]

I assume you fixed it, comment or react with 👍 to get this merged

[rushi-chavan]

Good to go