recloudstream/cloudstream
3
3
Fork 1
mirror of https://github.com/recloudstream/cloudstream.git synced 2024-08-15 01:53:11 +00:00
Code Issues Releases Wiki Activity

fix: cast items recycler (finally) (#564)

Browse source 
* turn cast items visible(tools)

* prevent cast gesture listener from permanent RIP in one lifecycle
This commit is contained in:
IndusAryan 2023-08-18 21:16:03 +05:30 committed by GitHub
parent 8f6e8a8e99
commit e95dc1db2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/src/main/java/com/lagradost/cloudstream3/ui/result/ResultFragmentPhone.kt
View file

@ -212,19 +212,17 @@ open class ResultFragmentPhone : FullScreenPlayer() {
loadTrailer() loadTrailer()
} }
override fun onDestroy() {
super.onDestroy()
PanelsChildGestureRegionObserver.Provider.get().apply {
resultBinding?.resultCastItems?.let {
unregister(it)
}
removeGestureRegionsUpdateListener(gestureRegionsListener)
}
}
override fun onDestroyView() { override fun onDestroyView() {
//somehow this still leaks and I dont know why???? //somehow this still leaks and I dont know why????
// todo look at https://github.com/discord/OverlappingPanels/blob/70b4a7cf43c6771873b1e091029d332896d41a1a/sample_app/src/main/java/com/discord/sampleapp/MainActivity.kt // todo look at https://github.com/discord/OverlappingPanels/blob/70b4a7cf43c6771873b1e091029d332896d41a1a/sample_app/src/main/java/com/discord/sampleapp/MainActivity.kt
PanelsChildGestureRegionObserver.Provider.get().let { obs ->
resultBinding?.resultCastItems?.let {
obs.unregister(it)
}
obs.removeGestureRegionsUpdateListener(gestureRegionsListener)
}
updateUIEvent -= ::updateUI updateUIEvent -= ::updateUI
binding = null binding = null
@ -1127,4 +1125,4 @@ open class ResultFragmentPhone : FullScreenPlayer() {
} }
} }
} }
} }

4
app/src/main/res/layout/fragment_result.xml
View file

@ -476,7 +476,7 @@
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
tools:itemCount="2" tools:itemCount="2"
tools:listitem="@layout/cast_item" tools:listitem="@layout/cast_item"
tools:visibility="gone" /> tools:visibility="visible" />
<TextView <TextView
android:id="@+id/result_vpn" android:id="@+id/result_vpn"
@ -905,4 +905,4 @@
android:contentDescription="@string/search_poster_descript"/> android:contentDescription="@string/search_poster_descript"/>
</androidx.cardview.widget.CardView>--> </androidx.cardview.widget.CardView>-->
</FrameLayout> </FrameLayout>