Fix no downloads message display

app/src/main/java/com/lagradost/cloudstream3/ui/download/DownloadChildFragment.kt

@@ -35,6 +35,7 @@ class DownloadChildFragment : Fragment() {
 
     override fun onDestroyView() {
         downloadDeleteEventListener?.let { VideoDownloadManager.downloadDeleteEvent -= it }
+        downloadDeleteEventListener = null
         binding = null
         super.onDestroyView()
     }

app/src/main/java/com/lagradost/cloudstream3/ui/download/DownloadFragment.kt

@@ -35,7 +35,6 @@ import com.lagradost.cloudstream3.ui.result.setLinearListLayout
 import com.lagradost.cloudstream3.ui.settings.Globals.TV
 import com.lagradost.cloudstream3.ui.settings.Globals.isLayout
 import com.lagradost.cloudstream3.utils.AppUtils.loadResult
-import com.lagradost.cloudstream3.utils.Coroutines.main
 import com.lagradost.cloudstream3.utils.DOWNLOAD_EPISODE_CACHE
 import com.lagradost.cloudstream3.utils.DataStore
 import com.lagradost.cloudstream3.utils.UIHelper.dismissSafe
@@ -60,16 +59,8 @@ class DownloadFragment : Fragment() {
         this.layoutParams = param
     }
 
-    private fun setList(list: List<VisualDownloadHeaderCached>) {
-        main {
-            (binding?.downloadList?.adapter as? DownloadAdapter)?.submitList(list)
-        }
-    }
-
     override fun onDestroyView() {
-        downloadDeleteEventListener?.let {
+        downloadDeleteEventListener?.let { VideoDownloadManager.downloadDeleteEvent -= it }
-            VideoDownloadManager.downloadDeleteEvent -= it
-        }
         downloadDeleteEventListener = null
         binding = null
         super.onDestroyView()
@@ -95,12 +86,10 @@ class DownloadFragment : Fragment() {
         hideKeyboard()
         binding?.downloadStorageAppbar?.setAppBarNoScrollFlagsOnTV()
 
-        observe(downloadsViewModel.noDownloadsText) {
-            binding?.textNoDownloads?.text = it
-        }
         observe(downloadsViewModel.headerCards) {
-            setList(it)
+            (binding?.downloadList?.adapter as? DownloadAdapter)?.submitList(it)
             binding?.downloadLoading?.isVisible = false
+            binding?.textNoDownloads?.isVisible = it.isEmpty()
         }
         observe(downloadsViewModel.availableBytes) {
             updateStorageInfo(view.context, it, R.string.free_storage, binding?.downloadFreeTxt, binding?.downloadFree)

app/src/main/java/com/lagradost/cloudstream3/ui/download/DownloadViewModel.kt

@@ -21,11 +21,6 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
 
 class DownloadViewModel : ViewModel() {
-    private val _noDownloadsText = MutableLiveData<String>().apply {
-        value = ""
-    }
-    val noDownloadsText: LiveData<String> = _noDownloadsText
-
     private val _headerCards =
         MutableLiveData<List<VisualDownloadHeaderCached>>().apply { listOf<VisualDownloadHeaderCached>() }
     val headerCards: LiveData<List<VisualDownloadHeaderCached>> = _headerCards

app/src/main/res/layout/fragment_downloads.xml

@@ -143,17 +143,15 @@
 
     <TextView
         android:id="@+id/text_no_downloads"
-        android:layout_width="match_parent"
+        android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginStart="8dp"
+        android:layout_gravity="center"
-        android:layout_marginTop="8dp"
+        android:layout_margin="30dp"
-        android:layout_marginEnd="8dp"
+        android:text="@string/downloads_empty"
-        android:textAlignment="center"
+        android:textSize="15sp"
-        android:textSize="20sp"
+        android:gravity="center"
-        app:layout_constraintBottom_toBottomOf="parent"
+        android:visibility="gone"
-        app:layout_constraintEnd_toEndOf="parent"
+        tools:visibility="visible" />
-        app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent" />
 
     <!--
     <ProgressBar

app/src/main/res/values/strings.xml

@@ -149,6 +149,7 @@
     <string name="download_canceled">Download Canceled</string>
     <string name="download_done">Download Done</string>
     <string name="download_format" translatable="false">%s - %s</string>
+    <string name="downloads_empty">You currently don\'t have any downloads.</string>
     <string name="update_started">Update Started</string>
     <string name="stream">Network stream</string>
     <string name="error_loading_links_toast">Error Loading Links</string>