psyc-mirrors
/
psyced
mirror of git://git.psyced.org/git/psyced
1
0
Fork 0
Code Issues 2 Releases Wiki Activity

float would only last for one more year.. we have to use strings for 

bignum action
This commit is contained in:
psyc://psyced.org/~lynX 2009-06-16 20:07:03 +02:00
parent b22f2e8b9b
commit e1da3b144b
2 changed files with 27 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
world/net/library/jsonparser.pike
View File

@ -527,9 +527,7 @@ PROTECTED mixed nextObject() {
if ((b >= '0' && b <= '9') || b == '.' || b == '-' || b == '+') {
int a; float b_; string c_;
sscanf(s, "%d%s", a, c_);
// some values of json ints exceed the limits of MAX_INT, in that case we need to use float -lynX
// maybe it is more efficient, if we used float in all cases then
if ((c_ && sizeof(c_)) || (a && s != to_string(a))) {
if ((c_ && sizeof(c_))) {
#ifdef __PIKE__
sscanf(s, "%f", b_);
#else
@ -537,6 +535,18 @@ PROTECTED mixed nextObject() {
#endif
return b_;
}
if (!a || s != to_string(a)) {
// some values of json ints exceed the limits of MAX_INT.
// in that case we tried to use float, but rendering floats
// will produce something like 2.17734e+09 instead of just
// a long integer. we have to return a string here, and risk
// to run into runtime errors. we should probably stop trying
// to convert json integers into ints in the first place.
// javascript and lpc just aren't compatible. do we have a
// bignum package for ldmud?
P3(("Warning: JSON integer too big. Returning %O as string.\n", s))
return s;
}
else return a;
}
if (s == "") {

24
world/net/twitter/polly.c
View File

@ -5,7 +5,7 @@
#include <net.h>
persistent float lastid;
persistent mixed lastid;
volatile object feed;
@ -37,15 +37,20 @@ parse(string body, mapping headers) {
"[_source] received an empty structure.");
return;
}
// this used to fail on MAX_INT turning the ints to negative.. interestingly
// it works out of the box now that i convert this to float. funny to run into
// such a weird problem only after months of usage, but if twitter never resets
// its packet ids, that's where you end up.. bignums!
if (wurst[0]["id"] <= lastid) {
P1(("%O received %d old updates (id0 %O <= lastid %O).\n", ME, sizeof(wurst), wurst[0]["id"], lastid))
// this used to fail on MAX_INT turning the ints to negative.. it would work for
// a while longer using floats, but since floating point mantissa in lpc is only
// 32 bits wide, it's just a question of time until we hit that roof again (when
// status_id reaches 4294967296). so let's try strings instead. funny to run into
// such a weird problem only after years that twitter has been in existence.
// twitterific may have run into the same problem, as the timing of its breakdown
// matches ours.
if (lastid && wurst[0]["id"] <= lastid) {
P1(("%O received %d old updates (id0 %O <= lastid %O).\n",
ME, sizeof(wurst), wurst[0]["id"], lastid))
return;
}
lastid = wurst[0]["id"];
P1(("%O -- new lastid %O\n", ME, lastid))
save_object(DATA_PATH "twitter");
for (i=sizeof(wurst)-1; i>=0; i--) {
d = wurst[i];
@ -110,9 +115,8 @@ fetch() {
feed -> content( #'parse, 1, 1 );
// twitter ignores since_id if count is present. stupid.
feed -> fetch("http://twitter.com/statuses/friends_timeline.json?"
// +( lastid? ("since_id="+ lastid) : "count=23"));
"count="+( lastid? ("23&since_id="+
sprintf("%F", lastid)) : "23"));
// +( lastid? ("since_id="+ lastid) : "count=23"));
"count="+( lastid? ("23&since_id="+ lastid) : "23"));
}
create() {