profxadke/misskey
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Better error handling

Browse source
This commit is contained in:
syuilo 2019-04-14 04:17:24 +09:00
parent b390363b25
commit e3b3f8fac1
No known key found for this signature in database
GPG key ID: BDC4C49D06AB9D69
25 changed files with 52 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/services/note/create.ts
View file

@ -175,7 +175,7 @@ export default async (user: User, data: Option, silent = false) => new Promise<N
}
if (data.visibility == 'specified') {
if (data.visibleUsers == null) throw 'invalid param';
if (data.visibleUsers == null) throw new Error('invalid param');
for (const u of data.visibleUsers) {
if (!mentionedUsers.some(x => x.id === u.id)) {
@ -214,7 +214,7 @@ export default async (user: User, data: Option, silent = false) => new Promise<N
// 未読通知を作成
if (data.visibility == 'specified') {
if (data.visibleUsers == null) throw 'invalid param';
if (data.visibleUsers == null) throw new Error('invalid param');
for (const u of data.visibleUsers) {
insertNoteUnread(u, note, true);
@ -428,7 +428,7 @@ async function insertNote(user: User, data: Option, tags: string[], emojis: stri
console.error(e);
throw 'something happened';
throw new Error('something happened');
}
}

4
src/services/note/polls/update.ts
View file

@ -7,10 +7,10 @@ import { Note } from '../../../models/entities/note';
export async function deliverQuestionUpdate(noteId: Note['id']) {
const note = await Notes.findOne(noteId);
if (note == null) throw 'note not found';
if (note == null) throw new Error('note not found');
const user = await Users.findOne(note.userId);
if (user == null) throw 'note not found';
if (user == null) throw new Error('note not found');
const followers = await Followings.find({
followeeId: user.id

2
src/services/note/polls/vote.ts
View file

@ -10,7 +10,7 @@ import { createNotification } from '../../create-notification';
export default async function(user: User, note: Note, choice: number) {
const poll = await Polls.findOne(note.id);
if (poll == null) throw 'poll not found';
if (poll == null) throw new Error('poll not found');
// Check whether is valid choice
if (poll.choices[choice] == null) throw new Error('invalid choice param');