From 112c68cd0c557e04c5087adfd3c98ad767d44075 Mon Sep 17 00:00:00 2001 From: marihachi Date: Sat, 24 Apr 2021 22:55:18 +0900 Subject: [PATCH] refactor init (#7464) --- src/boot/master.ts | 71 +++++++++++++++++++++++----------------------- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/src/boot/master.ts b/src/boot/master.ts index ef8692b30..473e215ba 100644 --- a/src/boot/master.ts +++ b/src/boot/master.ts @@ -45,26 +45,15 @@ function greet() { export async function masterMain() { let config!: Config; + // initialize app try { greet(); - - // initialize app - config = await init(); - - if (config.port == null || Number.isNaN(config.port)) { - bootLogger.error('The port is not configured. Please configure port.', null, true); - process.exit(1); - } - - if (process.platform === 'linux' && isWellKnownPort(config.port) && !isRoot()) { - bootLogger.error('You need root privileges to listen on well-known port on Linux', null, true); - process.exit(1); - } - - if (!await isPortAvailable(config.port)) { - bootLogger.error(`Port ${config.port} is already in use`, null, true); - process.exit(1); - } + showEnvironment(); + await showMachineInfo(bootLogger); + showNodejsVersion(); + config = loadConfigBoot(); + await connectDb(); + await validatePort(config); } catch (e) { bootLogger.error('Fatal error occurred during initialization', null, true); process.exit(1); @@ -89,14 +78,6 @@ const runningNodejsVersion = process.version.slice(1).split('.').map(x => parseI const requiredNodejsVersion = [11, 7, 0]; const satisfyNodejsVersion = !lessThan(runningNodejsVersion, requiredNodejsVersion); -function isWellKnownPort(port: number): boolean { - return port < 1024; -} - -async function isPortAvailable(port: number): Promise { - return await portscanner.checkPortStatus(port, '127.0.0.1') === 'closed'; -} - function showEnvironment(): void { const env = process.env.NODE_ENV; const logger = bootLogger.createSubLogger('env'); @@ -110,14 +91,7 @@ function showEnvironment(): void { logger.info(`You ${isRoot() ? '' : 'do not '}have root privileges`); } -/** - * Init app - */ -async function init(): Promise { - showEnvironment(); - - await showMachineInfo(bootLogger); - +function showNodejsVersion(): void { const nodejsLogger = bootLogger.createSubLogger('nodejs'); nodejsLogger.info(`Version ${runningNodejsVersion.join('.')}`); @@ -126,7 +100,9 @@ async function init(): Promise { nodejsLogger.error(`Node.js version is less than ${requiredNodejsVersion.join('.')}. Please upgrade it.`, null, true); process.exit(1); } +} +function loadConfigBoot(): Config { const configLogger = bootLogger.createSubLogger('config'); let config; @@ -146,6 +122,10 @@ async function init(): Promise { configLogger.succ('Loaded'); + return config; +} + +async function connectDb(): Promise { const dbLogger = bootLogger.createSubLogger('db'); // Try to connect to DB @@ -159,8 +139,29 @@ async function init(): Promise { dbLogger.error(e); process.exit(1); } +} - return config; +async function validatePort(config: Config): Promise { + const isWellKnownPort = (port: number) => port < 1024; + + async function isPortAvailable(port: number): Promise { + return await portscanner.checkPortStatus(port, '127.0.0.1') === 'closed'; + } + + if (config.port == null || Number.isNaN(config.port)) { + bootLogger.error('The port is not configured. Please configure port.', null, true); + process.exit(1); + } + + if (process.platform === 'linux' && isWellKnownPort(config.port) && !isRoot()) { + bootLogger.error('You need root privileges to listen on well-known port on Linux', null, true); + process.exit(1); + } + + if (!await isPortAvailable(config.port)) { + bootLogger.error(`Port ${config.port} is already in use`, null, true); + process.exit(1); + } } async function spawnWorkers(limit: number = 1) {