From 48de8a1da6ac9bb32241aa52a4cc5244d8801a35 Mon Sep 17 00:00:00 2001 From: Oj Date: Fri, 21 Jan 2022 12:56:47 +0000 Subject: [PATCH] [SecurityUtils] Rewrite ssoe to simpler one-liner --- src/utils/securityUtils.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/utils/securityUtils.js b/src/utils/securityUtils.js index a27dbc6..5649fe2 100644 --- a/src/utils/securityUtils.js +++ b/src/utils/securityUtils.js @@ -1,17 +1,7 @@ const { shell } = require('electron'); -const allowedProtocols = [ 'https:', 'http:' ]; -exports.saferShellOpenExternal = (url) => { - let parsed; - - try { - parsed = new URL(url); - } catch (_e) { return Promise.reject(); } - - if (!allowedProtocols.includes(parsed.protocol?.toLowerCase())) return Promise.reject(); // Only allow some protocols - - return shell.openExternal(url); -}; +const allowedProtocols = [ 'https', 'http' ]; // Only allow some protocols +exports.saferShellOpenExternal = (url) => allowedProtocols.includes(url.split(':')[0].toLowerCase()) ? shell.openExternal(url) : Promise.reject(); exports.checkUrlOriginMatches = (url1, url2) => { let parse1, parse2;