no-muse/musescore-downloader
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: ask user to send Discord message when score is missing from dataset

Browse source
This commit is contained in:
Xmader 2021-03-13 01:28:37 -05:00
parent 49aef0ccf3
commit d1c9634331
No known key found for this signature in database
GPG key ID: A20B97FB9EB730E4
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/cli.ts
View file

@ -88,7 +88,8 @@ void (async () => {
if (!confirmed) return
// initiate LibreScore link request
librescoreLink = getLibreScoreLink(scoreinfo, true)
librescoreLink = getLibreScoreLink(scoreinfo)
librescoreLink.catch(() => '') // silence this unhandled Promise rejection
// print a blank line to the terminal
console.log()
@ -134,7 +135,9 @@ void (async () => {
} catch (err) {
spinner.fail(err.message)
spinner.info(
"Send your URL to the #dataset-bugs channel in the LibreScore Community Discord server:\n https://discord.gg/kTyx6nUjMv");
'Send your URL to the #dataset-bugs channel in the LibreScore Community Discord server:\n ' +
'https://discord.gg/kTyx6nUjMv',
)
return
}
spinner.succeed('OK\n')

4
src/librescore-link.ts
View file

@ -6,7 +6,7 @@ const _getLink = (scorepack: string) => {
return `https://librescore.org/score/${scorepack}`
}
export const getLibreScoreLink = async (scoreinfo: ScoreInfo, isMsdl: boolean, _fetch = getFetch()): Promise<string> => {
export const getLibreScoreLink = async (scoreinfo: ScoreInfo, _fetch = getFetch()): Promise<string> => {
const mainCid = await getMainCid(scoreinfo, _fetch)
const ref = scoreinfo.getScorepackRef(mainCid)
const url = `https://ipfs.infura.io:5001/api/v0/dag/get?arg=${ref}`
@ -16,7 +16,7 @@ export const getLibreScoreLink = async (scoreinfo: ScoreInfo, isMsdl: boolean, _
assertRes(r0)
}
const res: { Message: string } | string = await r0.json()
if (typeof res !== 'string' && !isMsdl) {
if (typeof res !== 'string') {
// read further error msg
throw new Error(res.Message)
}