From 972e1a5babe8351a8e697c89cc8c8cec68f1a671 Mon Sep 17 00:00:00 2001 From: murm Date: Thu, 16 Mar 2023 20:39:10 -0400 Subject: [PATCH 1/2] fix image detection to not accept ANY mimetype --- utils/imagedetect.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils/imagedetect.js b/utils/imagedetect.js index 859464d..99dadf0 100644 --- a/utils/imagedetect.js +++ b/utils/imagedetect.js @@ -142,7 +142,10 @@ const checkImages = async (message, extraReturnTypes, video, sticker) => { url = url.replace(/.*\n\n/g, "") if (isValidUrl(url)){ const mimetype = await getType(url, extraReturnTypes) - type = {name: "image", path: url, url: url, type: mimetype} + // console.log(mimetype) + if (mimetype && imageFormats.includes(mimetype)) { + type = {name: "image", path: url, url: url, type: mimetype} + } } } From c11fa40dfc68d5cf7209c75481dc74c5db40d8b7 Mon Sep 17 00:00:00 2001 From: murm Date: Thu, 16 Mar 2023 20:40:15 -0400 Subject: [PATCH 2/2] update tip --- classes/imageCommand.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/imageCommand.js b/classes/imageCommand.js index 9129f7f..a73f0f1 100644 --- a/classes/imageCommand.js +++ b/classes/imageCommand.js @@ -40,7 +40,7 @@ class ImageCommand extends Command { if (selection) selectedImages.delete(this.author); if (image === undefined) { runningCommands.delete(this.author); - return `${this.constructor.noImage} (Tip: try right-clicking/holding on a message and press Apps -> Select Image, then try again.)`; + return `${this.constructor.noImage} (Tip: try running your command while replying to an image (or link to an image))`; } else if (image.type === "large") { runningCommands.delete(this.author); return "That image is too large (>= 25MB)! Try using a smaller image.";