From 2151afb1151e1ab97bce280c55dbea4c4da46890 Mon Sep 17 00:00:00 2001 From: Luna Date: Mon, 15 Jul 2019 14:21:08 -0300 Subject: [PATCH] add roomWidth arg to reverb, update reverb docs --- doc/README.md | 16 +++++++++++++--- examples/reverb.scri | 2 +- src/runner.zig | 1 + 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/doc/README.md b/doc/README.md index 95995be..115290c 100644 --- a/doc/README.md +++ b/doc/README.md @@ -89,11 +89,21 @@ Runs the Higher Quality Pitch Scaler from the SWH plugins. The `mult` parameter is the pitch coefficient, range from 0.5..2, default 1. -## `reverb split index roomLength roomHeight sourceLR sourceFB listLR listFB hpf warmth diffusion` +## `reverb split index roomLength roomWidth roomHeight sourceLR sourceFB listLR listFB hpf warmth diffusion` Run the Early Reflection Reverb from the Invada Studio plugins. -**TODO** Parameter list +Parameters: + - `roomLength`: Room Length, 3..100, default 25 + - `roomWidth`: Room Length, 3..100, default 30 + - `roomHeight`: Room Length, 3..100, default 10 + - `sourceLR`: Source Pan, -1..1, default -0.01 + - `sourceFB`: Source (F/B), 0.5..1, default 0.8 + - `listLR`: Listener Pan, -1..1, default 0.01 + - `listFB`: Listener (F/B), 0..0.5, default 0.2 + - `hpf`: HPF (High Pass Filter), 20..2000, default 1000 (most likely you want 20) + - `warmth`: Warmth, 0..100, default 50 + - `diffusion`: Diffusion, 0..100, default 50 ## `highpass split index freq gain noClip` @@ -118,7 +128,7 @@ Parameters: - `gain_scale`: Amplitude change, 0.2..5, default 1 - `wet`: Dry/wet mix, 0..1, default 1 -## TODO `vinyl split index year warp click wear` +## `vinyl split index year warp click wear` VyNil effect from SWH. diff --git a/examples/reverb.scri b/examples/reverb.scri index 9148bf7..61de89c 100644 --- a/examples/reverb.scri +++ b/examples/reverb.scri @@ -1,3 +1,3 @@ load :0; -reverb 3 1 25 30 0 0.8 0 0.2 1000 50 50; +reverb 3 1 25 30 10 0 0.8 0 0.2 1000 50 50; quicksave; diff --git a/src/runner.zig b/src/runner.zig index c835ba9..1913fa2 100644 --- a/src/runner.zig +++ b/src/runner.zig @@ -336,6 +336,7 @@ pub const Runner = struct { const pos = try cmd.consumePosition(); try cmd.appendParam(¶ms, "roomLength"); + try cmd.appendParam(¶ms, "roomWidth"); try cmd.appendParam(¶ms, "roomHeight"); try cmd.appendParam(¶ms, "sourceLR"); try cmd.appendParam(¶ms, "sourceFB");