luna/kemal
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

removes Content-Type response header if the file is cached

Browse source 
The content-type currently defaults to text/html, which is inaccurate
because no content is being returned. Google, and many popular CDNs
omit the Content-Type header for 304 response.
This commit is contained in:
Sam Eaton 2016-10-11 15:51:37 -06:00
parent 7908b54767
commit 875032f0dc
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/kemal/static_file_handler.cr
View file

@ -80,6 +80,7 @@ module Kemal
etag = %{W/"#{File.lstat(file_path).mtime.epoch.to_s}"} etag = %{W/"#{File.lstat(file_path).mtime.epoch.to_s}"}
context.response.headers["ETag"] = etag context.response.headers["ETag"] = etag
return false if !context.request.headers["If-None-Match"]? || context.request.headers["If-None-Match"] != etag return false if !context.request.headers["If-None-Match"]? || context.request.headers["If-None-Match"] != etag
context.response.headers.delete "Content-Type"
context.response.content_length = 0 context.response.content_length = 0
context.response.status_code = 304 # not modified context.response.status_code = 304 # not modified
return true return true