iv-org-mirror/videojs-quality-selector
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/videojs-quality-selector.git synced 2024-08-15 00:43:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #83 from izkmdz/ismendoza/remove-data-setup

Browse source 
docs: Remove data-setup property to prevent double initialization (#70)
This commit is contained in:
Matt Luedke 2022-04-04 08:54:59 -04:00 • committed by GitHub
commit df38cdebd5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
README.md
View file

@ -78,7 +78,7 @@ instance of a `video.js` player.
#### Using `<source>` #### Using `<source>`
```html ```html
<video id="video_1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="268" data-setup='{}'> <video id="video_1" class="video-js vjs-default-skin" controls preload="auto" width="640" height="268">
<source src="https://example.com/video_720.mp4" type="video/mp4" label="720P"> <source src="https://example.com/video_720.mp4" type="video/mp4" label="720P">
<source src="https://example.com/video_480.mp4" type="video/mp4" label="480P" selected="true"> <source src="https://example.com/video_480.mp4" type="video/mp4" label="480P" selected="true">
<source src="https://example.com/video_360.mp4" type="video/mp4" label="360P"> <source src="https://example.com/video_360.mp4" type="video/mp4" label="360P">
@ -114,7 +114,11 @@ There are at least two ways to add the quality selector control to the player's
bar. The first is directly adding it via `addChild`. For example: bar. The first is directly adding it via `addChild`. For example:
```js ```js
player.controlBar.addChild('QualitySelector'); videojs('video_1', {}, function() {
var player = this;
player.controlBar.addChild('QualitySelector');
});
``` ```
The second option is to add the control via the player's options, for instance: The second option is to add the control via the player's options, for instance:

4
docs/demo/index.html
View file

@ -11,7 +11,7 @@
<body> <body>
<h1>Demo of <code>videojs-quality-selector</code></h1> <h1>Demo of <code>videojs-quality-selector</code></h1>
<video id="video_1" class="video-js vjs-default-skin" controls preload="auto" data-setup='{}'> <video id="video_1" class="video-js vjs-default-skin" controls preload="auto">
<source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.720p.webm" type="video/webm" label="720P"> <source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.720p.webm" type="video/webm" label="720P">
<source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.480p.webm" type="video/webm" label="480P" selected="true"> <source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.480p.webm" type="video/webm" label="480P" selected="true">
<source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.360p.webm" type="video/webm" label="360P"> <source src="https://upload.wikimedia.org/wikipedia/commons/transcoded/a/ab/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm/Caminandes_3_-_Llamigos_-_Blender_Animated_Short.webm.360p.webm" type="video/webm" label="360P">
@ -19,7 +19,7 @@
</video> </video>
<script> <script>
videojs("video_1", {}, function() { videojs('video_1', {}, function() {
var player = this; var player = this;
player.controlBar.addChild('QualitySelector'); player.controlBar.addChild('QualitySelector');