23d2c014b4
Implement fallback for methods without a stub
2022-04-15 17:27:30 -06:00
6f04e0b9da
Allow uninteresting messages through mocks
...
If they are stubbed, but don't match arguments, raise an error.
2022-04-15 17:17:34 -06:00
4b21c9e6c1
Introduce _spectator_stub_for_method? utility method
2022-04-15 17:16:49 -06:00
3961662bf6
Experimental mock functionality
2022-04-10 20:01:54 -06:00
b0e27c69e8
Fix equality check
2022-04-10 15:24:45 -06:00
e8bac86017
Ensure Stubbable can have stubs defined
...
Require implementation of _spectator_define_stub.
2022-04-10 11:11:36 -06:00
0ad1ec11f3
Initial macros for defining and initializing mocks
2022-04-02 18:43:13 -06:00
d97a62e601
Rename constant DOUBLES to TYPES
...
Will use for doubles and mocks.
2022-04-02 17:58:15 -06:00
519836147e
Restructure stub modifiers
2022-04-02 10:50:27 -06:00
318e4f3707
Store location information in stub
...
Allows tracking where a stub was originally defined.
2022-04-02 10:39:59 -06:00
e61b31e47b
Add docs for allow and receive
2022-04-02 10:25:27 -06:00
17592287ad
Replace stub value method with call method
...
Pass method call information to stub.
2022-03-31 23:07:55 -06:00
2131967ba6
Workaround Crystal compiler bug
2022-03-31 22:54:03 -06:00
e05ef94ef5
Initial work on stub DSL - found bug in Crystal compiler
...
```
Module validation failed: Invalid bitcast
%4 = bitcast i32* %3 to %"(Spectator::Arguments(T, NT) | Nil)", !dbg !16
(Exception)
from /crystal/src/int.cr:541:9 in 'finish'
from /crystal/src/compiler/crystal/codegen/codegen.cr:71:7 in 'codegen'
from /crystal/src/compiler/crystal/compiler.cr:173:16 in 'compile'
from /crystal/src/compiler/crystal/command/spec.cr:98:14 in 'spec'
from /crystal/src/hash.cr:901:11 in '__crystal_main'
from /crystal/src/crystal/main.cr:115:5 in 'main'
from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'
Error: you've found a bug in the Crystal compiler. ...
```
I haven't been able to reproduce this in a simplified form.
Passing the `constraint` argument in NullStub#and_return to ValueStub.new triggers the bug.
Removing the `constraint` argument fixes the issue.
2022-03-31 22:49:45 -06:00
003be48591
Use responds_to? to ensure stub is cast correctly
2022-03-31 22:39:21 -06:00
9c1357da3f
Allow passing predefined stubs in as keyword args
2022-03-31 18:55:12 -06:00
c1195ef687
Simplify macro eval by returning a lazy double
2022-03-31 18:54:39 -06:00
914def05e1
Add docs
2022-03-31 18:51:28 -06:00
231323bbf1
Add return type restriction
...
This overrides the previous definition which doesn't have a restriction.
This is a workaround for the inability to infer a stub's return type.
2022-03-30 21:10:36 -06:00
f1a68fee8c
Typo
2022-03-30 20:46:53 -06:00
39f5ea34eb
Another place that needs a cast
2022-03-30 20:33:19 -06:00
613c969fbb
Match RSpec behavior
2022-03-30 20:28:36 -06:00
1327d74040
Fix handling of stubs with the same name
2022-03-26 00:13:24 -06:00
1199379833
Various fixes
2022-03-26 00:12:37 -06:00
bbaa8816b8
Weird segfault when inspecting value type is back.
...
Working around with a crude rescue block.
2022-03-25 23:54:44 -06:00
b28437ccc4
Match RSpec behavior
2022-03-25 22:32:27 -06:00
28488d308e
Don't invoke fallback if there are stubs for the method
2022-03-25 22:30:39 -06:00
fc51c1d730
More logging
2022-03-24 02:39:15 -06:00
b97a367be7
Method return type restriction takes precedence over original return type
...
Raise TypeCastError on ambiguous stub values.
2022-03-24 02:01:25 -06:00
7dd2cffa8e
Inspecting the value's class seems to work now
2022-03-22 22:13:02 -06:00
d6fcf128ba
Temporarily disable returning un-cast value
2022-03-22 22:11:34 -06:00
78dea01abe
Manual method existence check
2022-03-20 21:49:21 -06:00
0fb7be6722
Use stub instead of abstract_stub by default for stub_all
...
RSpec doesn't appear to raise unexpected message errors for standard object methods (like to_s).
There are also a lot of issues that arise when requiring a stub on common methods.
2022-03-20 15:38:26 -06:00
e209fe3eb5
Use Box for Wrapper implementation
...
This won't raise on invalid casts.
It should reduce the amount of instantiated types and methods.
2022-03-19 22:53:50 -06:00
18a03b02fe
Include reserved
2022-03-19 22:36:25 -06:00
03a031ad38
Use absolute path to RESERVED_KEYWORDS
2022-03-19 22:00:12 -06:00
b23a567ee3
Add require statements
2022-03-19 21:56:58 -06:00
04cf211f24
Move reserved keywords to a separate file
...
Add finalize as a reserved keyword.
2022-03-19 21:56:18 -06:00
04f3614ff7
Workaround issue with `value` not being found
...
For some reason the `value` method isn't found.
Event casting to TypedStub doesn't work.
2022-03-19 20:00:50 -06:00
bed84b315d
Add lazy double
2022-03-19 19:32:41 -06:00
162ad4df33
Report call and args like other error messages
2022-03-19 18:58:06 -06:00
b3fa2e3bfe
Address Ameba issues
2022-03-19 17:22:13 -06:00
2f1999b377
Fix call expansion in debug log
...
Macro expansion somehow generated an error when calling a missing method with a block.
```
syntax error in :1
Error: unknown token: 'n'
```
It seems like 'n' is from the '\n' that was previously generated:
```
Log.debug { "Got undefined method " + "baz do\n yield\nend" }
```
2022-03-19 16:32:25 -06:00
17e97cb39a
Explode method expansion
...
Somewhere along the way the block argument gets dropped.
Even though `method` is a `Def` that accepts a block, the `&block` portion is dropped.
Possible Crystal compiler bug.
2022-03-19 16:13:11 -06:00
15dd2ea6f1
Inject stubbable method that accepts a block
2022-03-19 16:09:35 -06:00
99aa8afdce
Add as_null_object method
2022-03-19 14:41:45 -06:00
70787ce2d4
Extend NullDouble from Double
2022-03-19 13:00:42 -06:00
d40040c8ee
Remove extra block body leftover from debug
...
Update docs to show example of default method implementation.
2022-03-19 12:37:46 -06:00
25f546245a
Handle injecting stubbed abstract method
2022-03-19 12:33:09 -06:00
9091b8d027
Literally inject stubs from double block
2022-03-19 12:28:00 -06:00
5a4e95e8a2
Split double macro into def_double and new_double
2022-03-19 11:41:53 -06:00
4dff018330
Pass along block only if it exists
2022-03-19 11:28:36 -06:00
a508aeb4a3
Use a shared macro to handle stub type cast
2022-03-17 02:45:50 -06:00
751ea77172
Add docs explaining how stub macros work
2022-03-17 02:18:32 -06:00
4f7a4a3453
Avoid issue with TypeCastError message
...
For some reason, attempting to get the class of the stubbed value causes a segfault.
This appears to get swallowed in some cases.
Trying to inspect the value was difficult without triggering some error.
In the failing case, the value is 42 (returned by a stubbed foo method).
The method is supposed to return a String, and this error checking should be triggered (line 119).
The value is a union, and inspecting the bytes contained in it looks like it's prefixed with the Crystal type ID for Int32.
However it looks like Crystal tries to treat it as a Bool? I'm not sure.
Very weird behavior and instead of wasting more time on it, I'm omitting the returned type from the error.
This type of casting error shouldn't be common.
This seems like a Crystal bug, but I'm having a hard time distilling the issue.
2022-03-16 22:40:24 -06:00
280f117e23
Use TypedStub instead of ValueStub
...
Test possible issues around stub returning nil
2022-03-16 21:07:20 -06:00
8e38d3b054
Add intermediate TypedStub
2022-03-16 21:05:43 -06:00
dc74a741cf
Bit of method cleanup
2022-03-15 22:55:24 -06:00
332ab1cebc
Smarter handling of stub fallback
2022-03-15 22:46:43 -06:00
01fc91e854
Add stubs for primitive methods
2022-03-14 21:53:09 -06:00
64cd921a7e
Add block arguments and yield
2022-03-12 23:50:30 -07:00
03aa282512
Don't stub primitive methods
2022-03-12 23:02:55 -07:00
291b4c75a8
Compiler error if stub defined in a method
2022-03-12 23:02:33 -07:00
94872a498d
Better string representation of method call
2022-03-12 19:26:18 -07:00
20087f1c57
Treat any tokens starting with _spectator as reserved
2022-03-12 19:17:38 -07:00
5ad29f486f
Better formatting for empty arguments
2022-03-12 17:49:07 -07:00
ca827a3c52
Initial work on null (object) double
2022-03-12 17:07:34 -07:00
f82719746d
Stubable -> Stubbable
2022-03-12 15:45:48 -07:00
7931847164
Cleanup and docs
2022-03-12 15:43:12 -07:00
151926fd25
Fix captured arguments not handling splat
2022-03-12 14:31:39 -07:00
ea46af00a6
Add method to define stubs
2022-03-12 14:31:19 -07:00
123dd0efca
Obscure parameters to avoid accidental usage
2022-03-12 13:58:20 -07:00
c8864b169e
Quick def methods should accept any args
2022-03-12 13:51:58 -07:00
f497aeb79d
Fix redefinition of method with splat argument
2022-03-12 13:15:26 -07:00
c1a14d1ad2
Add logging
2022-03-12 12:59:44 -07:00
59f966d0e0
Fix missing double name
...
Rename internal method to _spectator_stubbed_name.
This is a better name for mocks and doubles.
Improve some handling around stubbed name.
2022-03-12 12:17:27 -07:00
56f1c77a6c
Move method masking macro to Stubable
...
Rename to stub_all.
2022-03-12 11:56:54 -07:00
85cc28c499
Utility method to define a method and a stub override
2022-03-12 11:41:47 -07:00
8de457d80c
Handle previous_def and super - don't redefine method
2022-03-12 11:34:35 -07:00
554e215898
Prevent ugly "has no type" errors
2022-03-12 11:33:56 -07:00
12eeb02a8d
Move method redefinition for stub to Stubable
...
Require stub or raise UnexpectedMessage for all double methods.
Expose abstract_stub macro to require a stub.
2022-03-12 11:11:22 -07:00
9b94245bd8
Stub's type might not match return type (subclass or union)
2022-03-12 11:08:58 -07:00
d891422b3a
Don't need to recreate method by hand
2022-03-12 11:08:29 -07:00
76c1d6a096
Some rework of stubs and doubles
2022-03-12 09:39:32 -07:00
ae14a47329
Rename Response to Stub
2022-03-05 20:09:56 -07:00
ced98778a4
Document and test MethodCall
2022-03-05 16:15:42 -07:00
13f185b801
Capture and report arguments in exception message
2022-03-05 16:06:01 -07:00
d16c55984c
Fixup macros
2022-03-05 15:39:19 -07:00
2e15686d2d
Use internal arg name
2022-03-05 12:31:00 -07:00
ec57105afd
Support response constraints
...
Reduce union expansion by casting at key points.
2022-03-05 12:21:31 -07:00
8668e495ef
Placeholder mocks DSL
2022-03-05 10:41:52 -07:00
2adc867843
Initial work on response constraints
2022-03-05 10:41:39 -07:00
de7cd90d11
Add type capturing arguments
2022-03-04 17:16:45 -07:00
d7f8c2b958
Cleanup and document double
2022-03-03 23:12:35 -07:00
7e65d94cee
Match RSpec double name string
2022-03-03 22:41:18 -07:00
9594604770
Obscure and disallow double name method
2022-03-03 22:34:57 -07:00
5644d54470
Support double names
2022-03-03 22:31:40 -07:00
26deea3d20
Initial work on Double
2022-03-03 22:10:09 -07:00
8ac6546bdd
Rip out more existing mocks
2022-02-28 22:15:29 -07:00
0ea7890ece
Merge branch 'master' into mock-redesign
2022-02-28 20:39:33 -07:00
31d68a9ca3
Don't capture original block as proc
2022-02-22 16:55:11 -07:00
35f8779ceb
Forward Example procsy to_s to example
...
https://gitlab.com/arctic-fox/spectator/-/issues/70
2022-02-22 16:36:16 -07:00
eb8bd88927
Handle case with typeless block
...
Fixes syntax:
`stub method(&block)`
To stub a block with args, use:
`stub method(&block : Type -> Type)`
Addresses https://github.com/icy-arctic-fox/spectator/issues/42
2022-02-21 18:17:44 -07:00
92e839415d
Fix sample iteration with single block arg (not tuple)
2022-01-26 13:14:30 -07:00
d6112bd2dd
Rip out mocks
2022-01-26 12:41:41 -07:00
4057089c20
Support multiple block arguments in sample block
...
https://github.com/icy-arctic-fox/spectator/issues/41#issuecomment-1010192486
2022-01-11 15:53:53 -07:00
dd49fe3a67
Support string interpolation for example names
2022-01-10 21:29:05 -07:00
aabec269cb
Raise compilation error for string interpolation in group name
2022-01-10 21:11:28 -07:00
07aa968d68
Report failed expectation line
...
In output listing the failures, the comment line now shows the failed expectation line.
Previously this showed the example's source line.
2022-01-03 18:47:56 -07:00
4d81031274
Fix usage of 'expect' outside test block
...
Previously gave weird runtime erorr about mismatched groups.
Now correctly produces a compilation error.
2021-12-13 02:42:02 -07:00
d9269e17a8
Better implementation of explicit subject
2021-12-02 01:57:34 -07:00
315a318d7d
Explicit "provided" block description
...
Implements https://gitlab.com/arctic-fox/spectator/-/issues/69
2021-12-01 19:11:36 -07:00
59ce312341
Fix typos and spelling
2021-11-28 15:45:17 -07:00
f1f1659836
Fix adding stubs to class methods on mocked types
2021-10-11 23:03:50 -06:00
5692a77a1b
Update naming from partial to target
2021-10-11 23:03:12 -06:00
53f7c94e8a
Add missing negation variants for method stubs
2021-10-11 22:39:16 -06:00
36354082c7
Pass arguments to original/fallback for stubbed top-level methods
...
Addresses https://github.com/icy-arctic-fox/spectator/issues/36
2021-09-28 19:02:42 -06:00
a95c5bcab7
Better handling with `be` match against Value types and nil
...
Releates to https://github.com/icy-arctic-fox/spectator/issues/37
2021-09-28 18:22:41 -06:00
99ced17516
Handle undefined methods with have_attributes matcher
...
Instead of producing a compilation error on missing/undefind methods,
substitute in an "undefined" value.
This shows better output to the user.
2021-09-26 12:50:17 -06:00
2f1ac1374b
Use RegexMatcher to force used =~ operator
2021-09-22 17:57:56 -06:00
64b9c13436
Remove Test prefix
2021-09-22 17:53:42 -06:00
627a288358
Missing doc
2021-09-20 11:01:00 -06:00
a51640105c
Re-add pre- and post-condition hooks
...
Accidentally removed in hook refactoring.
Addresses https://gitlab.com/arctic-fox/spectator/-/issues/62
2021-09-16 09:01:51 -06:00
632845574f
Stringify tags
...
Addresses https://gitlab.com/arctic-fox/spectator/-/issues/61
2021-09-11 16:05:20 -06:00
09dcbdb383
Fix dumb with JUnit and HTML output
2021-08-19 13:55:58 -06:00
09414e611b
Brighten yellow for pending
2021-08-19 13:45:22 -06:00
e037e42fa7
Fix links to examples not working
2021-08-19 13:14:53 -06:00
f5ec9ccff6
CSS!
...
The HTML report looks beautiful.
2021-08-19 13:07:15 -06:00
efca1409c6
Fix dumb
2021-08-19 13:00:51 -06:00
708fd692ae
Add actual label to match data description
2021-08-19 11:46:07 -06:00
babc7ebc3a
Tweaks
2021-08-18 22:15:50 -06:00
18b42304c9
Use lists and fix some issues
2021-08-18 18:18:18 -06:00
dd0ef01369
Initial code for HTML formatter
2021-08-18 17:50:09 -06:00
f4fc599a1d
Add display_name convenience method
2021-08-18 17:47:20 -06:00
c49522a791
Allow tags on top-level groups
2021-08-18 15:57:22 -06:00
21d14bd814
Add f-prefix variants of groups and examples
...
For instance: `fit` for `it "...", :focus`
2021-08-18 13:55:21 -06:00
2b27ea5a01
Quick implementation of `filter_run_when_matching`
...
Needed for focus tests.
2021-08-18 13:46:54 -06:00
fd4812207a
Whitespace
2021-08-18 11:27:06 -06:00
1e82608500
Add methods matching RSpec for configuring include and exclude tags
2021-08-17 23:40:58 -06:00
c209fe7259
Add ascend methods
2021-08-17 22:10:01 -06:00
8d366bf637
Fully implemented test filtering by tags
...
Addresses https://gitlab.com/arctic-fox/spectator/-/issues/16
2021-08-17 21:54:01 -06:00
a9a46c76ad
Support tag filtering with value
2021-08-17 21:34:26 -06:00
b79dd4361e
Initial implementation of tag filtering
2021-08-17 20:52:06 -06:00
38ea2e7f96
Address Ameba issue
2021-08-17 15:02:34 -06:00
94d5c96e7d
Implement an example filter that supports matching groups
...
Addresses https://gitlab.com/arctic-fox/spectator/-/issues/25 and
https://github.com/icy-arctic-fox/spectator/issues/24
2021-08-17 14:09:37 -06:00
65799fdd3b
Pass along end line
2021-08-17 13:49:58 -06:00
67b4c0589b
Implement NodeIterator
2021-08-17 12:55:49 -06:00
cf7d67c972
Simplify ExampleIterator and remove unecessary allocations
2021-08-17 12:55:22 -06:00
837e4cb85d
Implement Indexable(Node) on ExampleGroup
2021-08-17 12:54:36 -06:00
4e5a52215a
Simplify
2021-08-16 20:27:27 -06:00
3803d4582c
Use Iterable(Node) instead of ExampleGroup
2021-08-16 20:27:21 -06:00
aa81f1d948
Change ExampleFilter to a NodeFilter
...
Node filters may operate on example groups as well as examples.
2021-08-08 12:13:59 -06:00
0f7a9ed9e8
Remove append and prepend variants of hook definition methods
...
RSpec defines these as applying to a scope (example, context, suite) as
opposed to example group.
Mimicing this is currently not possible in Spectator and would require a
substantial restructure of how hooks are handled.
This may be implemented in the future.
2021-08-08 11:50:30 -06:00
91d21b38e2
Lazily initialize global DSL spec builder
...
Require config to create a spec builder.
Config should be fully set up before any DSL is encountered.
2021-08-08 11:25:06 -06:00
605b82c532
Add prepend and append variants of hooks to DSL
2021-08-08 10:51:39 -06:00
841efc236d
Fix flipped append/prepend of "after" hooks
2021-08-08 10:27:34 -06:00
b9f0a31a4a
Overhaul hooks
...
Mostly cleanup and make managing hooks simpler, hopefully.
Tests indicate this configuration matches hook execution order of RSpec.
2021-08-07 21:45:49 -06:00
10b652f4b5
Remove unique/temp names
2021-07-31 19:11:51 -06:00
3dc3b88dbe
Add "after" hooks in reverse order to match RSpec
2021-07-31 15:48:54 -06:00
edcb5118e6
Show pending count only if there are pending examples
2021-07-31 15:02:21 -06:00
abe78410c4
Formatting
2021-07-31 14:18:59 -06:00
868aa1d00a
Support custom handling of hooks
2021-07-31 14:16:39 -06:00
f53ffabf6b
Support label for aggregate_failures block
2021-07-31 12:04:43 -06:00
4c125d98d4
Implement aggregate_failures
2021-07-31 11:56:53 -06:00
9a97596b84
Allow named arguments in `provided` block
2021-07-31 10:15:16 -06:00
ef1832721c
Remove unecessary branch
2021-07-20 18:29:26 -06:00
e8413db33f
Support custom messages for failed expectations
...
Fixes https://gitlab.com/arctic-fox/spectator/-/issues/28
2021-07-17 17:42:25 -06:00
0c4379c731
Formatting
2021-07-17 16:55:43 -06:00
e60cc2a447
Phrasing
2021-07-17 16:41:49 -06:00
eda4328a92
Blank line after stack trace
2021-07-17 16:35:35 -06:00
52a0ae938a
Consistency with location and location?
2021-07-17 16:34:15 -06:00
e316dd8a11
Fix missing example location in output
2021-07-17 16:27:38 -06:00
6c6dff363b
Track source location of pending result
2021-07-17 16:25:32 -06:00
7cb1545e83
Don't use failure location in failed example block output
...
This is problematic, since the failure could have ocurred outside the
example block (in a method call).
The comment line under the failure details will still point to the
result location, if it's available.
2021-07-17 16:15:11 -06:00
81f1966417
Use location instead of source
2021-07-17 16:12:10 -06:00
7e2b267e93
Use failure location in output if available
...
Fixes https://gitlab.com/arctic-fox/spectator/-/issues/57
2021-07-17 16:04:19 -06:00
f75991f34c
Formatting
2021-07-17 15:21:15 -06:00
937b084f66
Support defining hooks in configuration block
2021-07-17 15:20:58 -06:00
009266c8c2
Fix naming of hook methods when using a block
2021-07-17 14:32:55 -06:00
a810eef16c
Add `before_suite` and `after_suite`
2021-07-17 14:19:16 -06:00
af13a89257
Pass along fallback reason
2021-07-17 14:04:17 -06:00
1b53607f8e
Cleanup and add docs
2021-07-17 14:01:27 -06:00
571bc7d8a5
Reuse iterative example group macro code
...
Add support for x prefix to skip sample and random_sample groups.
2021-07-17 13:25:38 -06:00
e506c6b981
Implement random_sample
2021-07-17 13:05:03 -06:00
9d72d26630
Handle sample count
2021-07-17 12:49:11 -06:00
76a23131cb
More checks for missing block in DSL
...
Improved some error messages.
2021-07-17 12:36:21 -06:00
640857bef2
Pretty up iterative group names
2021-07-17 12:15:41 -06:00
d8e9d3128a
Fetch iteration item from group
2021-07-17 12:07:04 -06:00
c79cb62a61
Quick implementation of iterative group builder
2021-07-17 12:06:53 -06:00
c24c2cb5e1
Quick implementation of node builders
2021-07-17 11:10:44 -06:00
c7a90b3e64
Shorten names and cleanup
2021-07-17 10:47:16 -06:00
6c55301d0b
Merge remote-tracking branch 'origin/master' into release/0.10
2021-07-11 00:16:25 -06:00
4d030fb85a
Fix no_args being passed incorrectly
2021-07-10 22:43:54 -06:00
d9bb8e33fe
Fix finding stubs on types (static methods)
2021-07-10 22:41:10 -06:00
23fd075d51
Add stub when using `expect().to receive()`
...
This appears to match RSpec's behavior.
2021-07-10 20:28:51 -06:00
384fb3093f
Allow stubs returning nil to be used on NoReturn calls
2021-07-10 20:19:10 -06:00
e47ae613a5
Check for and allow expected exits
2021-07-10 19:27:01 -06:00
35cb0b527e
Use ExampleFailed instead of ExpectationFailed
2021-07-10 18:15:01 -06:00
5f61a24656
Provide default stub for Process.exit
...
Prevent terminating the process from within a test.
2021-07-10 14:18:07 -06:00
294bd61a25
Don't force top-level namespace
2021-07-10 14:17:14 -06:00
Michael Miller