From d670d960459498d2aeb9f5a1dfcb4c4a6597e6c5 Mon Sep 17 00:00:00 2001 From: Michael Miller Date: Thu, 27 Sep 2018 18:47:54 -0600 Subject: [PATCH] Remove extra assignment operations --- src/spectator/dsl/example_group_builder.cr | 3 +-- src/spectator/dsl/structure_dsl.cr | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spectator/dsl/example_group_builder.cr b/src/spectator/dsl/example_group_builder.cr index 2572e77..0b9ccbb 100644 --- a/src/spectator/dsl/example_group_builder.cr +++ b/src/spectator/dsl/example_group_builder.cr @@ -38,10 +38,9 @@ module Spectator::DSL def build(parent : ExampleGroup?, sample_values : Internals::SampleValues) : ExampleGroup ExampleGroup.new(@what, parent, build_hooks).tap do |group| - children = @children.map do |child| + group.children = @children.map do |child| child.build(group, sample_values).as(ExampleGroup::Child) end - group.children = children end end diff --git a/src/spectator/dsl/structure_dsl.cr b/src/spectator/dsl/structure_dsl.cr index ebeb676..8361c3d 100644 --- a/src/spectator/dsl/structure_dsl.cr +++ b/src/spectator/dsl/structure_dsl.cr @@ -47,11 +47,10 @@ module Spectator::DSL end _spectator_given_collection Collection%collection, %to_a, %collection - %to_a = Collection%collection.new.%to_a ::Spectator::DSL::Builder.start_given_group( {{collection.stringify}}, - %to_a, + Collection%collection.new.%to_a, :%group )