Don't splat values for failed match data

This caused an issue where keys with the same name as existing arguments 
couldn't be used.
In this case, "description" and "failure_message".

Fixes https://github.com/icy-arctic-fox/spectator/issues/13
This commit is contained in:
Michael Miller 2020-09-26 10:50:18 -06:00
parent db284066f6
commit a4680f2584
No known key found for this signature in database
GPG key ID: FB9F12F7C646A4AD
4 changed files with 8 additions and 8 deletions

View file

@ -30,7 +30,7 @@ module Spectator::Matchers
if match?(snapshot)
SuccessfulMatchData.new(description)
else
FailedMatchData.new(description, "#{actual.label} does not have attributes #{expected.label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} does not have attributes #{expected.label}", values(snapshot).to_a)
end
end
@ -39,7 +39,7 @@ module Spectator::Matchers
def negated_match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value)
if match?(snapshot)
FailedMatchData.new(description, "#{actual.label} has attributes #{expected.label}", **negated_values(snapshot))
FailedMatchData.new(description, "#{actual.label} has attributes #{expected.label}", negated_values(snapshot).to_a)
else
SuccessfulMatchData.new(description)
end

View file

@ -20,7 +20,7 @@ module Spectator::Matchers
if match?(snapshot)
SuccessfulMatchData.new(description)
else
FailedMatchData.new(description, "#{actual.label} does not have #{expected.label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} does not have #{expected.label}", values(snapshot).to_a)
end
end
@ -29,7 +29,7 @@ module Spectator::Matchers
def negated_match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value)
if match?(snapshot)
FailedMatchData.new(description, "#{actual.label} has #{expected.label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} has #{expected.label}", values(snapshot).to_a)
else
SuccessfulMatchData.new(description)
end

View file

@ -26,7 +26,7 @@ module Spectator::Matchers
if match?(snapshot)
SuccessfulMatchData.new(description)
else
FailedMatchData.new(description, "#{actual.label} is not #{expected.label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} is not #{expected.label}", values(snapshot).to_a)
end
end
@ -35,7 +35,7 @@ module Spectator::Matchers
def negated_match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value)
if match?(snapshot)
FailedMatchData.new(description, "#{actual.label} is #{expected.label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} is #{expected.label}", values(snapshot).to_a)
else
SuccessfulMatchData.new(description)
end

View file

@ -19,7 +19,7 @@ module Spectator::Matchers
if snapshot.values.all?
SuccessfulMatchData.new(description)
else
FailedMatchData.new(description, "#{actual.label} does not respond to #{label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} does not respond to #{label}", values(snapshot).to_a)
end
end
@ -28,7 +28,7 @@ module Spectator::Matchers
def negated_match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value)
if snapshot.values.any?
FailedMatchData.new(description, "#{actual.label} responds to #{label}", **values(snapshot))
FailedMatchData.new(description, "#{actual.label} responds to #{label}", values(snapshot).to_a)
else
SuccessfulMatchData.new(description)
end