iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix negation case for respond_to matcher

Browse source
This commit is contained in:
Michael Miller 2020-01-17 22:08:52 -07:00
parent ed48b80d58
commit a2508d5f6b
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/spectator/matchers/respond_matcher.cr
View file

@ -16,7 +16,7 @@ module Spectator::Matchers
# Actually performs the test against the expression. # Actually performs the test against the expression.
def match(actual : TestExpression(T)) : MatchData forall T def match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value) snapshot = snapshot_values(actual.value)
if match?(snapshot) if snapshot.values.all?
SuccessfulMatchData.new(description) SuccessfulMatchData.new(description)
else else
FailedMatchData.new(description, "#{actual.label} does not respond to #{label}", **values(snapshot)) FailedMatchData.new(description, "#{actual.label} does not respond to #{label}", **values(snapshot))
@ -27,7 +27,7 @@ module Spectator::Matchers
# A successful match with `#match` should normally fail for this method, and vice-versa. # A successful match with `#match` should normally fail for this method, and vice-versa.
def negated_match(actual : TestExpression(T)) : MatchData forall T def negated_match(actual : TestExpression(T)) : MatchData forall T
snapshot = snapshot_values(actual.value) snapshot = snapshot_values(actual.value)
if match?(snapshot) if snapshot.values.any?
FailedMatchData.new(description, "#{actual.label} responds to #{label}", **values(snapshot)) FailedMatchData.new(description, "#{actual.label} responds to #{label}", **values(snapshot))
else else
SuccessfulMatchData.new(description) SuccessfulMatchData.new(description)
@ -46,13 +46,6 @@ module Spectator::Matchers
{% end %} {% end %}
end end
# Checks if all results from the snapshot are satisified.
private def match?(snapshot)
# The snapshot did the hard work.
# Here just check if all values are true.
snapshot.values.all?
end
# Produces the tuple for the failed match data from a snapshot of the results. # Produces the tuple for the failed match data from a snapshot of the results.
private def values(snapshot) private def values(snapshot)
{% begin %} {% begin %}