iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't return nil for NoReturn stubs

Browse source 
Raise instead, which prevents making the method's return type nilable.
This commit is contained in:
Michael Miller 2021-07-08 11:36:07 -06:00
parent 78de2be994
commit 82f26dbb91
No known key found for this signature in database
GPG key ID: FB9F12F7C646A4AD
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/spectator/mocks/stubs.cr
View file

@ -83,7 +83,7 @@ module Spectator::Mocks
%harness.mocks.record_call(self, %call) %harness.mocks.record_call(self, %call)
if (%stub = %harness.mocks.find_stub(self, %call)) if (%stub = %harness.mocks.find_stub(self, %call))
if typeof({{original}}) == NoReturn if typeof({{original}}) == NoReturn
return %stub.call!(%args) { nil } return %stub.call!(%args) { raise "Cannot call original implementation of {{name}} - it won't return." }
else else
return %stub.call!(%args) { {{original}} } return %stub.call!(%args) { {{original}} }
end end
@ -106,7 +106,7 @@ module Spectator::Mocks
%harness.mocks.record_call(self, %call) %harness.mocks.record_call(self, %call)
if (%stub = %harness.mocks.find_stub(self, %call)) if (%stub = %harness.mocks.find_stub(self, %call))
if typeof({{original}}) == NoReturn if typeof({{original}}) == NoReturn
return %stub.call!(%args) { nil } return %stub.call!(%args) { raise "Cannot call original implementation of {{name}} - it won't return." }
else else
return %stub.call!(%args) { {{original}} { |*%ya| yield *%ya } } return %stub.call!(%args) { {{original}} { |*%ya| yield *%ya } }
end end