From 8232da116788ade3c06e83f1b90a9bf7b12e2433 Mon Sep 17 00:00:00 2001 From: Michael Miller Date: Tue, 9 Feb 2021 22:40:15 -0700 Subject: [PATCH] Mark DSL generated methods as private --- src/spectator/dsl/examples.cr | 2 +- src/spectator/dsl/hooks.cr | 4 ++-- src/spectator/dsl/tags.cr | 2 +- src/spectator/dsl/values.cr | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/spectator/dsl/examples.cr b/src/spectator/dsl/examples.cr index b466b02..af25638 100644 --- a/src/spectator/dsl/examples.cr +++ b/src/spectator/dsl/examples.cr @@ -41,7 +41,7 @@ module Spectator::DSL _spectator_tags(%tags, :tags, {{tags.splat(",")}} {{metadata.double_splat}}) _spectator_tags(\%tags, %tags, \{{tags.splat(",")}} \{{metadata.double_splat}}) - def \%test(\{{block.args.splat}}) : Nil + private def \%test(\{{block.args.splat}}) : Nil \{{block.body}} end diff --git a/src/spectator/dsl/hooks.cr b/src/spectator/dsl/hooks.cr index e1194ba..75dd06c 100644 --- a/src/spectator/dsl/hooks.cr +++ b/src/spectator/dsl/hooks.cr @@ -11,7 +11,7 @@ module Spectator::DSL \{% raise "Missing block for '{{type.id}}' hook" unless block %} \{% raise "Cannot use '{{type.id}}' inside of a test block" if @def %} - def self.\%hook : Nil + private def self.\%hook : Nil \{{block.body}} end @@ -29,7 +29,7 @@ module Spectator::DSL \{% raise "Block argument count '{{type.id}}' hook must be 0..1" if block.args.size > 1 %} \{% raise "Cannot use '{{type.id}}' inside of a test block" if @def %} - def \%hook(\{{block.args.splat}}) : Nil + private def \%hook(\{{block.args.splat}}) : Nil \{{block.body}} end diff --git a/src/spectator/dsl/tags.cr b/src/spectator/dsl/tags.cr index a73c396..f2dc268 100644 --- a/src/spectator/dsl/tags.cr +++ b/src/spectator/dsl/tags.cr @@ -4,7 +4,7 @@ module Spectator::DSL # returned by *source* with *tags* and *metadata*. # Any falsey items from *metadata* are removed. private macro _spectator_tags(name, source, *tags, **metadata) - def self.{{name.id}} + private def self.{{name.id}} %tags = {{source.id}} {% unless tags.empty? %} %tags.concat({ {{tags.map(&.id.symbolize).splat}} }) diff --git a/src/spectator/dsl/values.cr b/src/spectator/dsl/values.cr index a0d448b..fdff02f 100644 --- a/src/spectator/dsl/values.cr +++ b/src/spectator/dsl/values.cr @@ -14,7 +14,7 @@ module Spectator::DSL @%value = ::Spectator::LazyWrapper.new - def {{name.id}} + private def {{name.id}} {% if block.args.size > 0 %} {{block.args.first}} = ::Spectator::Example.current {% end %} @@ -62,7 +62,7 @@ module Spectator::DSL let({{name.id}}) {{block}} {% if name.id != :subject.id %} - def subject + private def subject {{name.id}} end {% end %} @@ -93,7 +93,7 @@ module Spectator::DSL let!({{name.id}}) {{block}} {% if name.id != :subject.id %} - def subject + private def subject {{name.id}} end {% end %}