iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use tuples instead of parallel arrays

Browse source
This commit is contained in:
Michael Miller 2018-12-13 14:48:20 -07:00
parent 5a87753c7d
commit 77efdd84be
1 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
spec/internals/sample_values_spec.cr
View file

@ -49,14 +49,17 @@ describe Spectator::Internals::SampleValues do
context "with multiple values" do context "with multiple values" do
it "returns the expected value" do it "returns the expected value" do
symbols = [:one, :two, :three] symbols = {
numbers = [123, 456, 789] one: 123,
two: 456,
three: 789,
}
values = Spectator::Internals::SampleValues.empty values = Spectator::Internals::SampleValues.empty
symbols.zip(numbers).each do |symbol, number| symbols.each do |symbol, number|
values = add_sample_value(values, symbol, symbol.to_s, number) values = add_sample_value(values, symbol, symbol.to_s, number)
end end
selected_symbol = symbols[1] selected_symbol = :one
selected_number = numbers[1] selected_number = symbols[selected_symbol]
wrapper = values.get_wrapper(selected_symbol) wrapper = values.get_wrapper(selected_symbol)
wrapper.should be_a(Spectator::Internals::TypedValueWrapper(typeof(selected_number))) wrapper.should be_a(Spectator::Internals::TypedValueWrapper(typeof(selected_number)))
wrapper.as(Spectator::Internals::TypedValueWrapper(typeof(selected_number))).value.should eq(selected_number) wrapper.as(Spectator::Internals::TypedValueWrapper(typeof(selected_number))).value.should eq(selected_number)
@ -74,14 +77,17 @@ describe Spectator::Internals::SampleValues do
context "with multiple values" do context "with multiple values" do
it "returns the expected value" do it "returns the expected value" do
symbols = [:one, :two, :three] symbols = {
numbers = [123, 456, 789] one: 123,
two: 456,
three: 789,
}
values = Spectator::Internals::SampleValues.empty values = Spectator::Internals::SampleValues.empty
symbols.zip(numbers).each do |symbol, number| symbols.each do |symbol, number|
values = add_sample_value(values, symbol, symbol.to_s, number) values = add_sample_value(values, symbol, symbol.to_s, number)
end end
selected_symbol = symbols[1] selected_symbol = :one
selected_number = numbers[1] selected_number = symbols[selected_symbol]
value = values.get_value(selected_symbol, typeof(selected_number)) value = values.get_value(selected_symbol, typeof(selected_number))
value.should eq(selected_number) value.should eq(selected_number)
end end
@ -90,18 +96,20 @@ describe Spectator::Internals::SampleValues do
describe "#each" do describe "#each" do
it "yields each entry" do it "yields each entry" do
symbols = [:one, :two, :three] symbols = {
numbers = [123, 456, 789] one: 123,
two: 456,
three: 789,
}
values = Spectator::Internals::SampleValues.empty values = Spectator::Internals::SampleValues.empty
symbols.zip(numbers).each do |symbol, number| symbols.each do |symbol, number|
values = add_sample_value(values, symbol, symbol.to_s, number) values = add_sample_value(values, symbol, symbol.to_s, number)
end end
size = 0 size = 0
values.each do |entry| values.each do |entry|
size += 1 size += 1
symbol = symbols.find { |s| s.to_s == entry.name } symbols.keys.map(&.to_s).should contain(entry.name)
symbol.should_not be_nil
end end
size.should eq(symbols.size) size.should eq(symbols.size)
end end