Update tests to use new Double usage

spec/spectator/mocks/double_spec.cr

@@ -1,9 +1,13 @@
 require "../../spec_helper"
 
 Spectator.describe Spectator::Double do
-  Spectator::Double.define(TestDouble, foo: 42, bar: "baz")
+  Spectator::Double.define(EmptyDouble)
+  Spectator::Double.define(FooBarDouble, "dbl-name", foo: 42, bar: "baz")
 
-  subject(dbl) { TestDouble.new("dbl-name") }
+  # The subject `dbl` must be carefully used in sub-contexts, otherwise it pollutes parent scopes.
+  # This changes the type of `dbl` to `Double`, which produces a union of methods and their return types.
+  context "plain double" do
+    subject(dbl) { FooBarDouble.new }
 
     it "responds to defined messages" do
       aggregate_failures do
@@ -17,7 +21,7 @@ Spectator.describe Spectator::Double do
     end
 
     it "reports the name in errors" do
-    expect { dbl.baz }.to raise_error(/dbl-name/)
+      expect { dbl.baz }.to raise_error(/"dbl-name"/)
     end
 
     it "reports arguments" do
@@ -31,10 +35,15 @@ Spectator.describe Spectator::Double do
       end
     end
 
-  context "without a double name" do
+    it "uses nil for undefined messages" do
-    Spectator::Double.define(TestDouble, foo: 42)
+      expect { dbl.baz }.to compile_as(Nil)
+    end
+  end
 
-    subject(dbl) { TestDouble.new }
+  context "without a double name" do
+    Spectator::Double.define(NamelessDouble, foo: 42)
+
+    subject(dbl) { NamelessDouble.new }
 
     it "reports as anonymous" do
       expect { dbl.baz }.to raise_error(/anonymous/i)
@@ -43,29 +52,29 @@ Spectator.describe Spectator::Double do
 
   context "with common object methods" do
     subject(dbl) do
-      Spectator::Double.new(
+      EmptyDouble.new([
-        "!=": "!=",
+        Spectator::ValueStub.new(:"!=", "!="),
-        "!~": "!~",
+        Spectator::ValueStub.new(:"!~", "!~"),
-        "==": "==",
+        Spectator::ValueStub.new(:"==", "=="),
-        "===": "===",
+        Spectator::ValueStub.new(:"===", "==="),
-        "=~": "=~",
+        Spectator::ValueStub.new(:"=~", "=~"),
-        "class": "class",
+        Spectator::ValueStub.new(:class, "class"),
-        "dup": "dup",
+        Spectator::ValueStub.new(:dup, "dup"),
-        "hash": "hash",
+        Spectator::ValueStub.new(:hash, "hash"),
-        "in?": true,
+        Spectator::ValueStub.new(:"in?", true),
-        "inspect": "inspect",
+        Spectator::ValueStub.new(:inspect, "inspect"),
-        "itself": "itself",
+        Spectator::ValueStub.new(:itself, "itself"),
-        "not_nil!": "not_nil!",
+        Spectator::ValueStub.new(:"not_nil!", "not_nil!"),
-        "pretty_inspect": "pretty_inspect",
+        Spectator::ValueStub.new(:pretty_inspect, "pretty_inspect"),
-        "tap": "tap",
+        Spectator::ValueStub.new(:tap, "tap"),
-        "to_json": "to_json",
+        Spectator::ValueStub.new(:to_json, "to_json"),
-        "to_pretty_json": "to_pretty_json",
+        Spectator::ValueStub.new(:to_pretty_json, "to_pretty_json"),
-        "to_s": "to_s",
+        Spectator::ValueStub.new(:to_s, "to_s"),
-        "to_yaml": "to_yaml",
+        Spectator::ValueStub.new(:to_yaml, "to_yaml"),
-        "try": "try",
+        Spectator::ValueStub.new(:try, "try"),
-        "object_id": 42_u64,
+        Spectator::ValueStub.new(:object_id, 42_u64),
-        "same?": false,
+        Spectator::ValueStub.new(:"same?", false),
-      )
+      ] of Spectator::Stub)
     end
 
     it "responds with defined messages" do
@@ -103,42 +112,42 @@ Spectator.describe Spectator::Double do
   end
 
   context "without common object methods" do
-    subject(dbl) { Spectator::Double.new }
+    subject(dbl) { EmptyDouble.new }
 
     it "raises with undefined messages" do
       io = IO::Memory.new
       pp = PrettyPrint.new(io)
       aggregate_failures do
-        expect { dbl.!=(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.!=(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.!~(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.!~(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.==(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.==(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.===(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.===(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.=~(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.=~(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.class }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.class }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.dup }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.dup }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.hash(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.hash(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.hash }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.hash }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.in?(42) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.in?(42) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.in?(1, 2, 3) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.in?(1, 2, 3) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.inspect }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.inspect }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.itself }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.itself }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.not_nil! }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.not_nil! }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.pretty_inspect }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.pretty_inspect }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.pretty_inspect(io) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.pretty_inspect(io) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.pretty_print(pp) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.pretty_print(pp) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.tap { nil } }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.tap { nil } }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_json }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_json }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_json(io) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_json(io) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_pretty_json }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_pretty_json }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_pretty_json(io) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_pretty_json(io) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_s }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_s }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_s(io) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_s(io) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_yaml }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_yaml }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.to_yaml(io) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.to_yaml(io) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.try { nil } }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.try { nil } }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.object_id }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.object_id }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.same?(dbl) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.same?(dbl) }.to raise_error(Spectator::UnexpectedMessage)
-        expect { dbl.same?(nil) }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.same?(nil) }.to raise_error(Spectator::UnexpectedMessage)
       end
     end
 
@@ -149,8 +158,14 @@ Spectator.describe Spectator::Double do
 
   context "with arguments constraints" do
     let(arguments) { Spectator::Arguments.capture(/foo/) }
+
+    context "without common object methods" do
+      Spectator::Double.define(TestDouble) do
+        abstract_stub abstract def foo(value) : String
+      end
+
       let(stub) { Spectator::ValueStub.new(:foo, "bar", arguments).as(Spectator::Stub) }
-    subject(dbl) { Spectator::Double({foo: String}).new([stub]) }
+      subject(dbl) { TestDouble.new([stub]) }
 
       it "returns the response when constraint satisfied" do
         expect(dbl.foo("foobar")).to eq("bar")
@@ -167,17 +182,22 @@ Spectator.describe Spectator::Double do
       it "has a non-union return type" do
         expect(dbl.foo("foobar")).to compile_as(String)
       end
+    end
 
     context "with common object methods" do
+      Spectator::Double.define(TestDouble) do
+        stub abstract def same?(other : Reference) : Bool
+      end
+
       let(stub) { Spectator::ValueStub.new(:"same?", true, arguments).as(Spectator::Stub) }
-      subject(dbl) { Spectator::Double({"same?": Bool}).new([stub]) }
+      subject(dbl) { TestDouble.new([stub]) }
 
       it "returns the response when constraint satisfied" do
         expect(dbl.same?("foobar")).to eq(true)
       end
 
       it "raises an error when constraint unsatisfied" do
-        expect { dbl.same?("baz") }.to raise_error(Spectator::UnexpectedMessage, /mask/)
+        expect { dbl.same?("baz") }.to raise_error(Spectator::UnexpectedMessage)
       end
 
       it "raises an error when argument count doesn't match" do