Rename with method to avoid recursive splat and ambiguity

src/spectator/mocks/exception_stub.cr

@@ -12,7 +12,7 @@ module Spectator
     end
 
     # Returns a new stub with constrained arguments.
-    def with(constraint : AbstractArguments)
+    def with_constraint(constraint : AbstractArguments)
       self.class.new(method, @exception, constraint, location)
     end
 

src/spectator/mocks/multi_value_stub.cr

@@ -16,7 +16,7 @@ module Spectator
     end
 
     # Returns a new stub with constrained arguments.
-    def with(constraint : AbstractArguments)
+    def with_constraint(constraint : AbstractArguments)
       self.class.new(method, @values, constraint, location)
     end
 

src/spectator/mocks/null_stub.cr

@@ -9,7 +9,7 @@ module Spectator
     end
 
     # Returns a new stub with constrained arguments.
-    def with(constraint : AbstractArguments)
+    def with_constraint(constraint : AbstractArguments)
       self.class.new(method, constraint, location)
     end
   end

src/spectator/mocks/proc_stub.cr

@@ -11,7 +11,7 @@ module Spectator
     end
 
     # Returns a new stub with constrained arguments.
-    def with(constraint : AbstractArguments)
+    def with_constraint(constraint : AbstractArguments)
       self.class.new(method, @proc, constraint, location)
     end
 

src/spectator/mocks/stub_modifiers.cr

@@ -4,12 +4,12 @@ module Spectator
   # Mixin intended for `Stub` to return new, modified stubs.
   module StubModifiers
     # Returns a new stub of the same type with constrained arguments.
-    abstract def with(constraint : AbstractArguments)
+    abstract def with_constraint(constraint : AbstractArguments)
 
     # :ditto:
     def with(*args, **kwargs)
-      constraint = Arguments.new(args, kwargs)
-      self.with(constraint)
+      constraint = Arguments.new(args, kwargs).as(AbstractArguments)
+      self.with_constraint(constraint)
     end
   end
 end

src/spectator/mocks/value_stub.cr

@@ -12,7 +12,7 @@ module Spectator
     end
 
     # Returns a new stub with constrained arguments.
-    def with(constraint : AbstractArguments)
+    def with_constraint(constraint : AbstractArguments)
       self.class.new(method, @value, constraint, location)
     end