iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix resolution issue when mocked types use custom types

Browse source 
GitLab issue 51 is affected.
https://gitlab.com/arctic-fox/spectator/-/issues/51
Private types cannot be referenced with mocks.
This commit is contained in:
Michael Miller 2022-12-17 20:56:16 -07:00
parent c3e7edc700
commit 4b68b8e3de
No known key found for this signature in database
GPG key ID: 32B47AE8F388A1FF
4 changed files with 133 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

42
spec/issues/gitlab_issue_51_spec.cr
View file

@ -1,31 +1,33 @@
require "../spec_helper"
private class Foo
def call(str : String) : String?
""
module GitLabIssue51
class Foo
def call(str : String) : String?
""
end
def alt1_call(str : String) : String?
nil
end
def alt2_call(str : String) : String?
[str, nil].sample
end
end
def alt1_call(str : String) : String?
nil
end
def alt2_call(str : String) : String?
[str, nil].sample
class Bar
def call(a_foo) : Nil # Must add nil restriction here, otherwise a segfault occurs from returning the result of #alt2_call.
a_foo.call("")
a_foo.alt1_call("")
a_foo.alt2_call("")
end
end
end
private class Bar
def call(a_foo) : Nil # Must add nil restriction here, otherwise a segfault occurs from returning the result of #alt2_call.
a_foo.call("")
a_foo.alt1_call("")
a_foo.alt2_call("")
end
end
Spectator.describe GitLabIssue51::Bar do
mock GitLabIssue51::Foo, call: "", alt1_call: "", alt2_call: ""
Spectator.describe Bar do
mock Foo, call: "", alt1_call: "", alt2_call: ""
let(:foo) { mock(Foo) }
let(:foo) { mock(GitLabIssue51::Foo) }
subject(:call) { described_class.new.call(foo) }
describe "#call" do