From 23d2c014b47e7ad1a553d46b0f6fecf1b683c36f Mon Sep 17 00:00:00 2001
From: Michael Miller <icy.arctic.fox@gmail.com>
Date: Fri, 15 Apr 2022 17:27:30 -0600
Subject: [PATCH] Implement fallback for methods without a stub

---
 src/spectator/mocks/mocked.cr | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/src/spectator/mocks/mocked.cr b/src/spectator/mocks/mocked.cr
index 2b0773d..3826397 100644
--- a/src/spectator/mocks/mocked.cr
+++ b/src/spectator/mocks/mocked.cr
@@ -13,8 +13,7 @@ module Spectator
     # This method can also raise an error if it's impossible to return something.
     def _spectator_stub_fallback(call : MethodCall, &)
       if _spectator_stub_for_method?(call.method)
-        # FIXME: Don't log to top-level Spectator logger (use mock or double logger).
-        Spectator::Log.info do
+        Spectator::Log.info do # FIXME: Don't log to top-level Spectator logger (use mock or double logger).
           "Stubs are defined for #{call.method.inspect}, but none matched (no argument constraints met)."
         end
 
@@ -31,8 +30,14 @@ module Spectator
     # Yield to call the original method's implementation.
     # The stubbed method returns the value returned by this method.
     # This method can also raise an error if it's impossible to return something.
-    def _spectator_stub_fallback(call : MethodCall, _type, &)
-      _spectator_stub_fallback(call) { yield }
+    def _spectator_stub_fallback(call : MethodCall, type, &)
+      value = _spectator_stub_fallback(call) { yield }
+
+      begin
+        type.cast(value)
+      rescue TypeCastError
+        raise TypeCastError.new("#{_spectator_stubbed_name} received message #{call} and is attempting to return `#{value.inspect}`, but returned type must be `#{type}`.")
+      end
     end
 
     # Method called when a stub isn't found.
@@ -60,8 +65,14 @@ module Spectator
     # The expected return type is provided by *type*.
     # The stubbed method returns the value returned by this method.
     # This method can also raise an error if it's impossible to return something.
-    def _spectator_abstract_stub_fallback(call : MethodCall, _type)
-      _spectator_abstract_stub_fallback(call)
+    def _spectator_abstract_stub_fallback(call : MethodCall, type)
+      value = _spectator_abstract_stub_fallback(call)
+
+      begin
+        type.cast(value)
+      rescue TypeCastError
+        raise TypeCastError.new("#{_spectator_stubbed_name} received message #{call} and is attempting to return `#{value.inspect}`, but returned type must be `#{type}`.")
+      end
     end
   end
 end