iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Workaround issue with Box.unbox causing segfault

Browse source 
Using Box.unbox on a nil value with a union type causes:

Invalid memory access (signal 11) at address 0x8

Related Crystal issue: https://github.com/crystal-lang/crystal/issues/11839
Fixes: https://gitlab.com/arctic-fox/spectator/-/issues/76
This commit is contained in:
Michael Miller 2022-07-18 19:47:34 -06:00
parent 95764140ee
commit 18e9c1c35d
No known key found for this signature in database
GPG key ID: 32B47AE8F388A1FF
3 changed files with 22 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/spectator/wrapper.cr
View file

@ -19,7 +19,12 @@ module Spectator
# Retrieves the previously wrapped value.
# The *type* of the wrapped value must match otherwise an error will be raised.
def get(type : T.class) : T forall T
Box(T).unbox(@pointer)
{% begin %}
{% if T.nilable? %}
@pointer.null? ? nil :
{% end %}
Box(T).unbox(@pointer)
{% end %}
end
# Retrieves the previously wrapped value.
@ -34,7 +39,12 @@ module Spectator
# type = wrapper.get { Int32 } # Returns Int32
# ```
def get(& : -> T) : T forall T
Box(T).unbox(@pointer)
{% begin %}
{% if T.nilable? %}
@pointer.null? ? nil :
{% end %}
Box(T).unbox(@pointer)
{% end %}
end
end
end