iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Run after-all hooks correctly

Browse source
This commit is contained in:
Michael Miller 2019-09-26 22:53:16 -06:00
parent 95fa9b39b2
commit 0e3727b504
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/spectator/runner.cr
View file

@ -37,7 +37,7 @@ module Spectator
result = run_example(example).as(Result) result = run_example(example).as(Result)
results << result results << result
if @config.fail_fast? && result.is_a?(FailedResult) if @config.fail_fast? && result.is_a?(FailedResult)
# TODO: example.group.run_after_all_hooks(ignore_unfinished: true) example.group.context.run_after_all_hooks(example.group, ignore_unfinished: true)
break break
end end
end end

10
src/spectator/test_context.cr
View file

@ -31,14 +31,18 @@ module Spectator
def run_after_hooks(example : Example) def run_after_hooks(example : Example)
run_after_each_hooks(example) run_after_each_hooks(example)
run_after_all_hooks run_after_all_hooks(example.group)
end end
protected def run_after_all_hooks protected def run_after_all_hooks(group : ExampleGroup, *, ignore_unfinished = false)
return if @after_all_hooks_run return if @after_all_hooks_run
return unless ignore_unfinished || group.finished?
@hooks.run_after_all @hooks.run_after_all
@parent.try &.run_after_all_hooks @parent.try do |parent_context|
parent_group = group.as(NestedExampleGroup).parent
parent_context.run_after_all_hooks(parent_group, ignore_unfinished: ignore_unfinished)
end
ensure ensure
@after_all_hooks_run = true @after_all_hooks_run = true
end end