iv-org-mirror/shard-spectator
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-spectator.git synced 2024-08-15 00:53:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fixed an issue where named subjects could crash the compiler

Browse source 
Received:

Nil assertion failed (NilAssertionError)
  from ???
  ...
Error: you've found a bug in the Crystal compiler. ...

for this code:

subject(point) { Point.new }
describe "#x" do
  subject { point.x }
end

Redefining subjects with a named subject broke.
This commit fixes that with a simply flip in the definitions.
This commit is contained in:
Michael Miller 2019-05-21 13:44:19 -06:00
parent ec9e598882
commit 01b5d71ad0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/spectator/dsl/structure_dsl.cr
View file

@ -781,8 +781,8 @@ module Spectator::DSL
# It is cached so that the same instance is used throughout the test. # It is cached so that the same instance is used throughout the test.
# The subject will be recreated for each test it is used in. # The subject will be recreated for each test it is used in.
macro subject(name, &block) macro subject(name, &block)
subject {{block}} let({{name.id}}) {{block}}
let({{name.id}}) { subject } subject { {{name.id}} }
end end
# Defines an expression by name. # Defines an expression by name.