iv-org-mirror/shard-kemal
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-kemal.git synced 2024-08-15 00:53:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

Build Route Regex once to reduce allocations

Browse source 
Right now every `match?` performed against the routes defined result
in a new Regex compiled for the exact same `@path`.

Since `@path` of the Route does not change on every request, we
pre-build it to avoid repeated allocations.

When testing this in release mode (against 0.10.2 [d1e3f0b]):

Before: 32408.48 req/s
After:  34862.07 req/s
This commit is contained in:
Luis Lavena 2016-01-18 13:48:41 -03:00
parent 788c7241d4
commit df359d66c9
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/kemal/route.cr
View file

@ -6,13 +6,14 @@ class Kemal::Route
getter method getter method
def initialize(@method, @path, &@handler : Kemal::Context -> _) def initialize(@method, @path, &@handler : Kemal::Context -> _)
@compiled_regex = pattern_to_regex(@path)
end end
def match?(request) def match?(request)
check_for_method_override!(request) check_for_method_override!(request)
return nil unless request.override_method == @method return nil unless request.override_method == @method
return true if request.path.not_nil!.includes?(':') && request.path.not_nil! == @path return true if request.path.not_nil!.includes?(':') && request.path.not_nil! == @path
request.path.not_nil!.match(pattern_to_regex(@path)) do |url_params| request.path.not_nil!.match(@compiled_regex) do |url_params|
request.url_params = url_params request.url_params = url_params
return true return true
end end