From e3be2d8d78be8a7a566ffcaa14a5e3de3337cd08 Mon Sep 17 00:00:00 2001 From: Anton Maminov Date: Mon, 17 Apr 2023 23:05:18 +0300 Subject: [PATCH 1/4] test on Windows --- .github/workflows/ci.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 983dc67..3e139ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,8 +11,11 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, macos-latest] - crystal: [latest, nightly] + include: + - { os: ubuntu-latest, crystal: latest } + - { os: ubuntu-latest, crystal: nightly } + - { os: macos-latest } + - { os: windows-latest } runs-on: ${{ matrix.os }} steps: From bbb21c1b6f8354f83976dbcab2c839664d6174f9 Mon Sep 17 00:00:00 2001 From: Anton Maminov Date: Mon, 17 Apr 2023 23:20:20 +0300 Subject: [PATCH 2/4] use ameba github action --- .github/workflows/ci.yml | 14 ++++++++++++-- shard.yml | 4 ---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3e139ae..97e3069 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,5 +40,15 @@ jobs: - name: Check formatting run: crystal tool format --check - - name: Run ameba linter - run: bin/ameba + check_ameba: + runs-on: ubuntu-latest + steps: + - name: Install Crystal + uses: crystal-lang/install-crystal@v1 + - name: Check out repository code + uses: actions/checkout@v3 + - name: Crystal Ameba Linter + id: crystal-ameba + uses: crystal-ameba/github-action@v0.7.1 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/shard.yml b/shard.yml index 4223a97..330fbde 100644 --- a/shard.yml +++ b/shard.yml @@ -12,10 +12,6 @@ dependencies: github: crystal-loot/exception_page version: ~> 0.4.1 -development_dependencies: - ameba: - github: crystal-ameba/ameba - crystal: ">= 0.36.0" license: MIT From 25d718ea8caf1381caac23c7f4ba005e66ea18ad Mon Sep 17 00:00:00 2001 From: Anton Maminov Date: Wed, 19 Apr 2023 13:04:56 +0300 Subject: [PATCH 3/4] allowed-failure for windows ci --- .github/workflows/ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97e3069..54a01c6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,10 +12,10 @@ jobs: fail-fast: false matrix: include: - - { os: ubuntu-latest, crystal: latest } - - { os: ubuntu-latest, crystal: nightly } - - { os: macos-latest } - - { os: windows-latest } + - { os: ubuntu-latest, crystal: latest, allowed-failure: false } + - { os: ubuntu-latest, crystal: nightly, allowed-failure: false } + - { os: macos-latest, allowed-failure: false } + - { os: windows-latest, allowed-failure: true } runs-on: ${{ matrix.os }} steps: @@ -36,6 +36,7 @@ jobs: run: | crystal spec crystal spec --release --no-debug + continue-on-error: ${{ matrix.allowed-failure }} - name: Check formatting run: crystal tool format --check