iv-org-mirror/shard-kemal
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-kemal.git synced 2024-08-15 00:53:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix parsing JSON params when "charset" is present in "Content-Type" header (#193)

Browse source 
Resolves case when `Content-Type` headers is passed in form of `application/json; charset=utf-8`
This commit is contained in:
Sijawusz Pur Rahnama 2016-08-11 21:29:29 +02:00 • committed by Serdar Dogruyol
parent d4e96c7b44
commit 28859fbdb8
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec/param_parser_spec.cr
View file

@ -91,6 +91,20 @@ describe "ParamParser" do
json_params.should eq({"name" => "Serdar"})
end
it "parses request body when passed charset" do
route = Route.new "POST", "/" { }
request = HTTP::Request.new(
"POST",
"/",
body: "{\"name\": \"Serdar\"}",
headers: HTTP::Headers{"Content-Type" => "application/json; charset=utf-8"},
)
json_params = Kemal::ParamParser.new(request).json
json_params.should eq({"name" => "Serdar"})
end
it "parses request body for array" do
route = Route.new "POST", "/" { }

2
src/kemal/param_parser.cr
View file

@ -55,7 +55,7 @@ module Kemal
# If request body is a JSON Array it's added into `params` as `_json` and can be accessed
# like params["_json"]
def parse_json
return unless @request.body && @request.headers["Content-Type"]? == APPLICATION_JSON
return unless @request.body && @request.headers["Content-Type"]?.try(&.[APPLICATION_JSON]?)
body = @request.body.as(String)
case json = JSON.parse(body).raw