Start moving out URI from ConnectionContext

Create connections with an initial context. Database will set itself as context after connection has been created

spec/custom_drivers_types_spec.cr

@@ -48,7 +48,7 @@ class FooDriver < DB::Driver
   end
 
   def build_connection(context : DB::ConnectionContext) : DB::Connection
-    FooConnection.new(context)
+    FooConnection.new
   end
 
   class FooConnection < DB::Connection
@@ -111,7 +111,7 @@ class BarDriver < DB::Driver
   end
 
   def build_connection(context : DB::ConnectionContext) : DB::Connection
-    BarConnection.new(context)
+    BarConnection.new
   end
 
   class BarConnection < DB::Connection

spec/dummy_driver.cr

@@ -3,12 +3,11 @@ require "../src/db"
 
 class DummyDriver < DB::Driver
   def build_connection(context : DB::ConnectionContext) : DB::Connection
-    DummyConnection.new(context)
+    DummyConnection.new
   end
 
   class DummyConnection < DB::Connection
-    def initialize(context)
+    def initialize
-      super(context)
       @connected = true
       @@connections ||= [] of DummyConnection
       @@connections.not_nil! << self

src/db.cr

@@ -160,7 +160,8 @@ module DB
   end
 
   private def self.build_connection(uri : URI)
-    build_driver(uri).build_connection(SingleConnectionContext.new(uri)).as(Connection)
+    # PENDING: parse connection options from uri and set the right connection context
+    build_driver(uri).build_connection(SingleConnectionContext.default).as(Connection)
   end
 
   private def self.build_driver(uri : URI)

src/db/connection.cr

@@ -24,15 +24,14 @@ module DB
     include BeginTransaction
 
     # :nodoc:
-    getter context
+    property context : ConnectionContext = SingleConnectionContext.default
     @statements_cache = StringKeyCache(Statement).new
     @transaction = false
-    getter? prepared_statements : Bool
     # :nodoc:
     property auto_release : Bool = true
 
-    def initialize(@context : ConnectionContext)
+    def prepared_statements? : Bool
-      @prepared_statements = @context.prepared_statements?
+      context.prepared_statements?
     end
 
     # :nodoc:
@@ -59,7 +58,7 @@ module DB
     protected def do_close
       @statements_cache.each_value &.close
       @statements_cache.clear
-      @context.discard self
+      context.discard self
     end
 
     # :nodoc:
@@ -75,7 +74,7 @@ module DB
     # managed by the database. Should be used
     # only if the connection was obtained by `Database#checkout`.
     def release
-      @context.release(self)
+      context.release(self)
     end
 
     # :nodoc:

src/db/connection_context.cr

@@ -1,8 +1,5 @@
 module DB
   module ConnectionContext
-    # Returns the uri with the connection settings to the database
-    abstract def uri : URI
-
     # Return whether the statements should be prepared by default
     abstract def prepared_statements? : Bool
 
@@ -19,12 +16,11 @@ module DB
   class SingleConnectionContext
     include ConnectionContext
 
-    getter uri : URI
+    class_getter default : SingleConnectionContext = SingleConnectionContext.new(true)
+
     getter? prepared_statements : Bool
 
-    def initialize(@uri : URI)
+    def initialize(@prepared_statements : Bool)
-      params = HTTP::Params.parse(uri.query || "")
-      @prepared_statements = DB.fetch_bool(params, "prepared_statements", true)
     end
 
     def discard(connection : Connection)

src/db/database.cr

@@ -56,6 +56,7 @@ module DB
       @pool = Pool.new(**pool_options) {
         conn = @driver.build_connection(self).as(Connection)
         conn.auto_release = false
+        conn.context = self
         @setup_connection.call conn
         conn
       }