diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml deleted file mode 100644 index 34c5a4b..0000000 --- a/.github/workflows/ci.yml +++ /dev/null @@ -1,48 +0,0 @@ -name: CI - -on: - pull_request: - branches: - - 'master' - schedule: - - cron: '0 21 * * *' - -jobs: - check_format: - runs-on: ubuntu-latest - container: - image: crystallang/crystal:latest-alpine - steps: - - uses: actions/checkout@v2 - - name: Format - run: crystal tool format --check - coding_standards: - runs-on: ubuntu-latest - container: - image: crystallang/crystal:latest-alpine - steps: - - uses: actions/checkout@v2 - - name: Install Dependencies - run: shards install - - name: Ameba - run: ./bin/ameba - test_latest: - runs-on: ubuntu-latest - container: - image: crystallang/crystal:latest-alpine - steps: - - uses: actions/checkout@v2 - - name: Install Dependencies - run: shards install - - name: Specs - run: crystal spec --order random --error-on-warnings - test_nightly: - runs-on: ubuntu-latest - container: - image: crystallang/crystal:nightly-alpine - steps: - - uses: actions/checkout@v2 - - name: Install Dependencies - run: shards install - - name: Specs - run: crystal spec --order random --error-on-warnings diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml deleted file mode 100644 index 095862e..0000000 --- a/.github/workflows/deployment.yml +++ /dev/null @@ -1,27 +0,0 @@ -name: Deployment - -on: - push: - branches: - - master - -jobs: - deploy_docs: - runs-on: ubuntu-latest - container: - image: crystallang/crystal:latest-alpine - steps: - - name: Install Build Dependencies - run: apk add --update rsync - - uses: actions/checkout@v2 - - name: Install Dependencies - run: shards install - - name: Build - run: crystal docs lib/athena-spec/src/athena-spec.cr src/athena-negotiation.cr - - name: Deploy - uses: JamesIves/github-pages-deploy-action@3.7.1 - with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - BRANCH: gh-pages - FOLDER: docs - SINGLE_COMMIT: true diff --git a/.gitignore b/.gitignore index 0bbd4a9..82f1ad5 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,3 @@ -/docs/ /lib/ /bin/ /.shards/ diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..d54ee29 --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,51 @@ +# Changelog + +## [0.1.5] - 2024-04-09 + +### Changed + +- Integrate website into monorepo ([#365](https://github.com/athena-framework/athena/pull/365)) (George Dietrich) + +## [0.1.4] - 2023-10-09 + +_Administrative release, no functional changes_ + +## [0.1.3] - 2023-02-18 + +### Changed + +- Update some links in preparation for Athena Framework `0.18.0` ([#261](https://github.com/athena-framework/athena/pull/261)) (George Dietrich) + +## [0.1.2] - 2022-05-14 + +_First release a part of the monorepo._ + +### Added + +- Add `VERSION` constant to `Athena::Negotiation` namespace ([#166](https://github.com/athena-framework/athena/pull/166)) (George Dietrich) +- Add getting started documentation to API docs ([#172](https://github.com/athena-framework/athena/pull/172)) (George Dietrich) + +### Changed + +- Update minimum `crystal` version to `~> 1.4.0` ([#169](https://github.com/athena-framework/athena/pull/169)) (George Dietrich) + +### Fixed + +- Correct the shard version in `README.md` ([#6](https://github.com/athena-framework/negotiation/pull/6)) (syeopite) + +## [0.1.1] - 2021-02-04 + +### Changed + +- Migrate documentation to [MkDocs](https://mkdocstrings.github.io/crystal/) ([#4](https://github.com/athena-framework/negotiation/pull/4)) (George Dietrich) + +## [0.1.0] - 2020-12-24 + +_Initial release._ + +[0.1.5]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.5 +[0.1.4]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.4 +[0.1.3]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.3 +[0.1.2]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.2 +[0.1.1]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.1 +[0.1.0]: https://github.com/athena-framework/negotiation/releases/tag/v0.1.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..9bbfb49 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,3 @@ +# Contributing + +This repository is a read-only mirror. Please refer the [main Athena repository](https://github.com/athena-framework/athena/blob/master/CONTRIBUTING.md) on how to start contributing. diff --git a/README.md b/README.md index eb8264a..6a1e9e4 100644 --- a/README.md +++ b/README.md @@ -1,35 +1,15 @@ # Negotiation -[![CI](https://github.com/athena-framework/negotiation/workflows/CI/badge.svg)](https://github.com/athena-framework/negotiation/actions?query=workflow%3ACI) +[![Common Changelog](https://common-changelog.org/badge.svg)](https://common-changelog.org) +[![CI](https://github.com/athena-framework/athena/workflows/CI/badge.svg)](https://github.com/athena-framework/athena/actions/workflows/ci.yml) [![Latest release](https://img.shields.io/github/release/athena-framework/negotiation.svg)](https://github.com/athena-framework/negotiation/releases) Framework agnostic [content negotiation](https://tools.ietf.org/html/rfc7231#section-5.3) library based on [willdurand/Negotiation](https://github.com/willdurand/Negotiation). -## Installation +## Getting Started -1. Add the dependency to your `shard.yml`: - -```yaml -dependencies: - athena-negotiation: - github: athena-framework/negotiation - version: ~> 1.0.0 -``` - -2. Run `shards install` - -## Documentation - -Everything is documented in the [API Docs](https://athena-framework.github.io/negotiation/Athena/Negotiation.html). +Checkout the [Documentation](https://athenaframework.org/Negotiation). ## Contributing -1. Fork it (https://github.com/athena-framework/negotiation/fork) -2. Create your feature branch (`git checkout -b my-new-feature`) -3. Commit your changes (`git commit -am 'Add some feature'`) -4. Push to the branch (`git push origin my-new-feature`) -5. Create a new Pull Request - -## Contributors - -- [George Dietrich](https://github.com/blacksmoke16) - creator and maintainer +Read the general [Contributing Guide](./CONTRIBUTING.md) for information on how to get started. diff --git a/docs/README.md b/docs/README.md new file mode 100644 index 0000000..94b03ef --- /dev/null +++ b/docs/README.md @@ -0,0 +1,83 @@ +The `Athena::Negotiation` component allows an application to support [content negotiation](https://tools.ietf.org/html/rfc7231#section-5.3). +The component has no dependencies and is framework agnostic; supporting various negotiators. + +## Installation + +First, install the component by adding the following to your `shard.yml`, then running `shards install`: + +```yaml +dependencies: + athena-negotiation: + github: athena-framework/negotiation + version: ~> 0.1.0 +``` + +## Usage + +The main type of [Athena::Negotiation][] is [ANG::AbstractNegotiator][] which is used to implement negotiators for each `Accept*` header. +`Athena::Negotiation` exposes class level getters for each negotiator; that return a lazily initialized singleton instance. +Each negotiator exposes two methods: [ANG::AbstractNegotiator#best][] and [ANG::AbstractNegotiator#ordered_elements][]. + +### Media Type + +```crystal +negotiator = ANG.negotiator + +accept_header = "text/html, application/xhtml+xml, application/xml;q=0.9" +priorities = ["text/html; charset=utf-8", "application/json", "application/xml;q=0.5"] + +accept = negotiator.best(accept_header, priorities).not_nil! + +accept.media_range # => "text/html" +accept.parameters # => {"charset" => "utf-8"} +``` + +The [ANG::Negotiator][] type returns an [ANG::Accept][], or `nil` if negotiating the best media type has failed. + +### Character Set + +```crystal +negotiator = ANG.charset_negotiator + +accept_header = "ISO-8859-1, utf-8; q=0.9" +priorities = ["iso-8859-1;q=0.3", "utf-8;q=0.9", "utf-16;q=1.0"] + +accept = negotiator.best(accept_header, priorities).not_nil! + +accept.charset # => "utf-8" +accept.quality # => 0.9 +``` + +The [ANG::CharsetNegotiator][] type returns an [ANG::AcceptCharset][], or `nil` if negotiating the best character set has failed. + +### Encoding + +```crystal +negotiator = ANG.encoding_negotiator + +accept_header = "gzip;q=1.0, identity; q=0.5, *;q=0" +priorities = ["gzip", "foo"] + +accept = negotiator.best(accept_header, priorities).not_nil! + +accept.coding # => "gzip" +``` + +The [ANG::EncodingNegotiator][] type returns an [ANG::AcceptEncoding][], or `nil` if negotiating the best encoding has failed. + +### Language + +```crystal +negotiator = ANG.language_negotiator + +accept_header = "en; q=0.1, fr; q=0.4, zh-Hans-CN; q=0.9, de; q=0.2" +priorities = ["de", "zh-Hans-CN", "en"] + +accept = negotiator.best(accept_header, priorities).not_nil! + +accept.language # => "zh" +accept.region # => "cn" +accept.script # => "hans" +``` + +The [ANG::LanguageNegotiator][] type returns an [ANG::AcceptLanguage][], or `nil` if negotiating the best language has failed. diff --git a/mkdocs.yml b/mkdocs.yml new file mode 100644 index 0000000..08ced2d --- /dev/null +++ b/mkdocs.yml @@ -0,0 +1,31 @@ +INHERIT: ../../../mkdocs-common.yml + +site_name: Negotiation +site_url: https://athenaframework.org/Negotiation/ +repo_url: https://github.com/athena-framework/negotiation + +nav: + - Introduction: README.md + - Back to Manual: project://. + - API: + - Aliases: aliases.md + - Top Level: top_level.md + - '*' + +plugins: + - search + - section-index + - literate-nav + - gen-files: + scripts: + - ../../../gen_doc_stubs.py + - mkdocstrings: + default_handler: crystal + custom_templates: ../../../docs/templates + handlers: + crystal: + crystal_docs_flags: + - ./docs/index.cr + - ./lib/athena-negotiation/src/athena-negotiation.cr + source_locations: + lib/athena-negotiation: https://github.com/athena-framework/negotiation/blob/v{shard_version}/{file}#L{line} diff --git a/shard.yml b/shard.yml index 1f5a48e..b15ac1f 100644 --- a/shard.yml +++ b/shard.yml @@ -1,25 +1,17 @@ name: athena-negotiation -version: 0.1.0 +version: 0.1.5 -crystal: '>= 0.35.0' +crystal: ~> 1.4 license: MIT repository: https://github.com/athena-framework/negotiation -documentation: https://athena-framework.github.io/negotiation/Athena/Negotiation.html +documentation: https://athenaframework.org/Negotiation description: | Framework agnostic content negotiation library. authors: - - George Dietrich - -development_dependencies: - ameba: - github: crystal-ameba/ameba - version: ~> 0.13.0 - athena-spec: - github: athena-framework/spec - version: ~> 0.2.3 + - George Dietrich diff --git a/spec/negotiator_spec.cr b/spec/negotiator_spec.cr index 2c89e54..353942d 100644 --- a/spec/negotiator_spec.cr +++ b/spec/negotiator_spec.cr @@ -47,7 +47,7 @@ struct NegotiatorTest < NegotiatorTestCase expected = expected.should_not be_nil accept_header.media_range.should eq expected[0] - accept_header.parameters.should eq (expected[1] || Hash(String, String).new) + accept_header.parameters.should eq(expected[1] || Hash(String, String).new) end def best_data_provider : Tuple @@ -71,9 +71,9 @@ struct NegotiatorTest < NegotiatorTestCase {"image/png, text/plain, audio/ogg", {"baz/asdf"}, nil}, {"image/png, text/plain, audio/ogg", {"audio/ogg"}, {"audio/ogg", nil}}, {"image/png, text/plain, audio/ogg", {"YO/SuP"}, nil}, - {"text/html; charset=UTF-8, application/pdf", {"text/html; charset=UTF-8"}, {"text/html", {"charset" => "UTF-8"}}}, - {"text/html; charset=UTF-8, application/pdf", {"text/html"}, nil}, - {"text/html, application/pdf", {"text/html; charset=UTF-8"}, {"text/html", {"charset" => "UTF-8"}}}, + {"text/html; charset=utf-8, application/pdf", {"text/html; charset=utf-8"}, {"text/html", {"charset" => "utf-8"}}}, + {"text/html; charset=utf-8, application/pdf", {"text/html"}, nil}, + {"text/html, application/pdf", {"text/html; charset=utf-8"}, {"text/html", {"charset" => "utf-8"}}}, # PHP"s PEAR HTTP2 assertions I took from the other lib. {php_pear_header, {"image/gif", "image/png", "application/xhtml+xml", "application/xml", "text/html", "image/jpeg", "text/plain"}, {"image/png", nil}}, @@ -86,7 +86,7 @@ struct NegotiatorTest < NegotiatorTestCase {php_pear_header, {"audio/midi"}, {"audio/midi", nil}}, {"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8", {"application/rss+xml"}, {"application/rss+xml", nil}}, - # Case sensitiviy + # Case sensitivity {"text/* ; q=0.3, TEXT/html ;Q=0.7, text/html ; level=1, texT/Html ;leVel = 2 ;q=0.4, */* ; q=0.5", {"text/html; level=2"}, {"text/html", {"level" => "2"}}}, {"text/* ; q=0.3, text/html;Q=0.7, text/html ;level=1, text/html; level=2;q=0.4, */*;q=0.5", {"text/HTML; level=3"}, {"text/html", {"level" => "3"}}}, diff --git a/src/abstract_negotiator.cr b/src/abstract_negotiator.cr index 6c014e2..1bddf8c 100644 --- a/src/abstract_negotiator.cr +++ b/src/abstract_negotiator.cr @@ -9,7 +9,9 @@ abstract class Athena::Negotiation::AbstractNegotiator(HeaderType) end end - # Returns the best `HeaderType` type based on the provided *header* value and *priorities*. + # Returns the best `HeaderType` based on the provided *header* value and *priorities*. + # + # If *strict* is `true`, an `ANG::Exceptions::Exception` will be raised if the *header* contains an invalid value, otherwise it is ignored. # # See `Athena::Negotiation` for examples. def best(header : String, priorities : Indexable(String), strict : Bool = false) : HeaderType? @@ -24,9 +26,9 @@ abstract class Athena::Negotiation::AbstractNegotiator(HeaderType) raise ex if strict end - accepted_priorties = priorities.map { |p| HeaderType.new p } + accepted_priorities = priorities.map { |p| HeaderType.new p } - matches = self.find_matches accepted_headers, accepted_priorties + matches = self.find_matches accepted_headers, accepted_priorities specific_matches = matches.reduce({} of Int32 => ANG::AcceptMatch) do |acc, match| ANG::AcceptMatch.reduce acc, match @@ -36,10 +38,10 @@ abstract class Athena::Negotiation::AbstractNegotiator(HeaderType) match = specific_matches.shift? - match.nil? ? nil : accepted_priorties[match.index] + match.nil? ? nil : accepted_priorities[match.index] end - # Returns an array of `HeaderType` types that the provided *header* allows, ordered so that the `#best` match is first. + # Returns an array of `HeaderType` that the provided *header* allows, ordered so that the `#best` match is first. # # ``` # header = "text/*;q=0.3, text/html;q=0.7, text/html;level=1, text/html;level=2;q=0.4, */*;q=0.5" diff --git a/src/accept.cr b/src/accept.cr index 34d85ec..d69e91a 100644 --- a/src/accept.cr +++ b/src/accept.cr @@ -3,11 +3,11 @@ require "./base_accept" # Represents an [Accept](https://tools.ietf.org/html/rfc7231#section-5.3.2) header media type. # # ``` -# accept = ANG::Accept.new "application/json; q = 0.75; charset = UTF-8" +# accept = ANG::Accept.new "application/json; q = 0.75; charset = utf-8" # -# accept.header # => "application/json; q = 0.9; charset = UTF-8" -# accept.normalized_header # => "application/json; charset=UTF-8" -# accept.parameters # => {"charset" => "UTF-8"} +# accept.header # => "application/json; q = 0.75; charset = utf-8" +# accept.normalized_header # => "application/json; charset=utf-8" +# accept.parameters # => {"charset" => "utf-8"} # accept.quality # => 0.75 # accept.type # => "application" # accept.sub_type # => "json" diff --git a/src/accept_encoding.cr b/src/accept_encoding.cr index 5157935..138922e 100644 --- a/src/accept_encoding.cr +++ b/src/accept_encoding.cr @@ -5,8 +5,8 @@ require "./base_accept" # ``` # accept = ANG::AcceptEncoding.new "gzip; q = 0.5; key=value" # -# accept.header # => "gzip-1; q = 0.5; key=value" -# accept.normalized_header # => "gzip-1; key=value" +# accept.header # => "gzip; q = 0.5; key=value" +# accept.normalized_header # => "gzip; key=value" # accept.parameters # => {"key" => "value"} # accept.quality # => 0.5 # accept.coding # => "gzip" diff --git a/src/accept_language.cr b/src/accept_language.cr index b4c3115..f0a2ed6 100644 --- a/src/accept_language.cr +++ b/src/accept_language.cr @@ -19,11 +19,11 @@ struct Athena::Negotiation::AcceptLanguage < Athena::Negotiation::BaseAccept getter language : String # Returns the region, if any, for this `AcceptLanguage` header. - # E.x. if the `#language_range` is `zh-Hans-CN`, the language would be `cn` + # E.x. if the `#language_range` is `zh-Hans-CN`, the region would be `cn` getter region : String? = nil # Returns the script, if any, for this `AcceptLanguage` header. - # E.x. if the `#language_range` is `zh-Hans-CN`, the language would be `hans` + # E.x. if the `#language_range` is `zh-Hans-CN`, the script would be `hans` getter script : String? = nil def initialize(value : String) diff --git a/src/athena-negotiation.cr b/src/athena-negotiation.cr index 1b36c62..12ddf3a 100644 --- a/src/athena-negotiation.cr +++ b/src/athena-negotiation.cr @@ -14,78 +14,9 @@ require "./exceptions/*" alias ANG = Athena::Negotiation # The `Athena::Negotiation` component allows an application to support [content negotiation](https://tools.ietf.org/html/rfc7231#section-5.3). -# The component has no dependencies and is framework agnostic; supporting various negotiators. -# -# ## Usage -# -# The main type of `Athena::Negotiation` is `ANG::AbstractNegotiator` which is used to implement negotiators for each `Accept*` header. -# `Athena::Negotiation` exposes class level getters for each negotiator; that return a lazily initialized singleton instance. -# Each negotiator exposes two methods: `ANG::AbstractNegotiator#best` and `ANG::AbstractNegotiator#ordered_elements`. -# -# ### Media Type -# -# ``` -# negotiator = ANG.negotiator -# -# accept_header = "text/html, application/xhtml+xml, application/xml;q=0.9" -# priorities = ["text/html; charset=UTF-8", "application/json", "application/xml;q=0.5"] -# -# accept = negotiator.best(accept_header, priorities).not_nil! -# -# accept.media_range # => "text/html" -# accept.parameters # => {"charset" => "UTF-8"} -# ``` -# -# The `ANG::Negotiator` type returns an `ANG::Accept`, or `nil` if negotiating the best media type has failed. -# -# ### Character Set -# -# ``` -# negotiator = ANG.charset_negotiator -# -# accept_header = "ISO-8859-1, UTF-8; q=0.9" -# priorities = ["iso-8859-1;q=0.3", "utf-8;q=0.9", "utf-16;q=1.0"] -# -# accept = negotiator.best(accept_header, priorities).not_nil! -# -# accept.charset # => "utf-8" -# accept.quality # => 0.9 -# ``` -# -# The `ANG::CharsetNegotiator` type returns an `ANG::AcceptCharset`, or `nil` if negotiating the best character set has failed. -# -# ### Encoding -# -# ``` -# negotiator = ANG.encoding_negotiator -# -# accept_header = "gzip;q=1.0, identity; q=0.5, *;q=0" -# priorities = ["gzip", "foo"] -# -# accept = negotiator.best(accept_header, priorities).not_nil! -# -# accept.coding # => "gzip" -# ``` -# -# The `ANG::EncodingNegotiator` type returns an `ANG::AcceptEncoding`, or `nil` if negotiating the best character set has failed. -# -# ### Language -# -# ``` -# negotiator = ANG.language_negotiator -# -# accept_header = "en; q=0.1, fr; q=0.4, zh-Hans-CN; q=0.9, de; q=0.2" -# priorities = ["de", "zh-Hans-CN", "en"] -# -# accept = negotiator.best(accept_header, priorities).not_nil! -# -# accept.language # => "zh" -# accept.region # => "cn" -# accept.script # => "hans" -# ``` -# -# The `ANG::LanguageNegotiator` type returns an `ANG::AcceptLanguage`, or `nil` if negotiating the best character set has failed. module Athena::Negotiation + VERSION = "0.1.5" + # Returns a lazily initialized `ANG::Negotiator` singleton instance. class_getter(negotiator) { ANG::Negotiator.new } diff --git a/src/base_accept.cr b/src/base_accept.cr index fc9507d..b9e02b8 100644 --- a/src/base_accept.cr +++ b/src/base_accept.cr @@ -1,7 +1,7 @@ # Base type for properties/logic all [Accept*](https://tools.ietf.org/html/rfc7231#section-5.3) headers share. abstract struct Athena::Negotiation::BaseAccept # Returns the full unaltered header `self` represents. - # E.x. `text/html` or `unicode-1-1;q=0.8` or `zh-Hans-CN`. + # E.x. `text/html`, `unicode-1-1;q=0.8`, or `zh-Hans-CN`. getter header : String # Returns a normalized version of the `#header`, excluding the `#quality` parameter. @@ -10,7 +10,7 @@ abstract struct Athena::Negotiation::BaseAccept getter normalized_header : String # Returns any extension parameters included in the header `self` represents. - # E.x. `charset=UTF-8` or `version=2`. + # E.x. `charset=utf-8` or `version=2`. getter parameters : Hash(String, String) = Hash(String, String).new # Returns the [quality value](https://tools.ietf.org/html/rfc7231#section-5.3.1) of the header `self` represents. diff --git a/src/language_negotiator.cr b/src/language_negotiator.cr index 4d0304c..e82d1c9 100644 --- a/src/language_negotiator.cr +++ b/src/language_negotiator.cr @@ -12,7 +12,7 @@ class Athena::Negotiation::LanguageNegotiator < Athena::Negotiation::AbstractNeg base_equal = accept_base.downcase == priority_base.downcase sub_equal = accept_sub.try &.downcase == priority_sub.try &.downcase - if ((accept_base == "*" || base_equal) && (accept_sub.nil? || sub_equal)) + if (accept_base == "*" || base_equal) && (accept_sub.nil? || sub_equal) score = 10 * (base_equal ? 1 : 0) + (sub_equal ? 1 : 0) return ANG::AcceptMatch.new accept.quality * priority.quality, score, index diff --git a/src/negotiator.cr b/src/negotiator.cr index 18b3042..53cd001 100644 --- a/src/negotiator.cr +++ b/src/negotiator.cr @@ -12,7 +12,7 @@ class Athena::Negotiation::Negotiator < Athena::Negotiation::AbstractNegotiator( accept_sub_type = accept.sub_type priority_sub_type = priority.sub_type - intercection = accept.parameters.each_with_object({} of String => String) do |(k, v), params| + intersection = accept.parameters.each_with_object({} of String => String) do |(k, v), params| priority.parameters.tap do |pp| params[k] = v if pp.has_key?(k) && pp[k] == v end @@ -21,12 +21,10 @@ class Athena::Negotiation::Negotiator < Athena::Negotiation::AbstractNegotiator( type_equals = accept_type.downcase == priority_type.downcase sub_type_equals = accept_sub_type.downcase == priority_sub_type.downcase - if ( - (accept_type == "*" || type_equals) && - (accept_sub_type == "*" || sub_type_equals) && - intercection.size == accept.parameters.size - ) - score = 100 * (type_equals ? 1 : 0) + 10 * (sub_type_equals ? 1 : 0) + intercection.size + if (accept_type == "*" || type_equals) && + (accept_sub_type == "*" || sub_type_equals) && + intersection.size == accept.parameters.size + score = 100 * (type_equals ? 1 : 0) + 10 * (sub_type_equals ? 1 : 0) + intersection.size return ANG::AcceptMatch.new accept.quality * priority.quality, score, index end @@ -36,22 +34,18 @@ class Athena::Negotiation::Negotiator < Athena::Negotiation::AbstractNegotiator( accept_sub_type, accept_plus = self.split_sub_type accept_sub_type priority_sub_type, priority_plus = self.split_sub_type priority_sub_type - if ( - !(accept_type == "*" || type_equals) || - !(accept_sub_type == "*" || priority_sub_type == "*" || accept_plus == "*" || priority_plus == "*") - ) + if !(accept_type == "*" || type_equals) || + !(accept_sub_type == "*" || priority_sub_type == "*" || accept_plus == "*" || priority_plus == "*") return nil end sub_type_equals = accept_sub_type.downcase == priority_sub_type.downcase plus_equals = accept_plus.downcase == priority_plus.downcase - if ( - (accept_sub_type == "*" || priority_sub_type == "*" || sub_type_equals) && - (accept_plus == "*" || priority_plus == '*' || plus_equals) && - intercection.size == accept.parameters.size - ) - score = 100 * (type_equals ? 1 : 0) + 10 * (sub_type_equals ? 1 : 0) + (plus_equals ? 1 : 0) + intercection.size + if (accept_sub_type == "*" || priority_sub_type == "*" || sub_type_equals) && + (accept_plus == "*" || priority_plus == '*' || plus_equals) && + intersection.size == accept.parameters.size + score = 100 * (type_equals ? 1 : 0) + 10 * (sub_type_equals ? 1 : 0) + (plus_equals ? 1 : 0) + intersection.size return ANG::AcceptMatch.new accept.quality * priority.quality, score, index end