Some cleanup

src/accept.cr

@@ -11,8 +11,9 @@ struct Athena::Negotiation::Accept < Athena::Negotiation::BaseAccept
 
     parts = @type.split '/'
 
-    # TODO: Use more specific exception
+    if parts.size != 2 || !parts[0].presence || !parts[1].presence
-    raise ANG::Exceptions::InvalidMediaType.new @type, "Invalid media type: '#{@type}'." if parts.size != 2 || !parts[0].presence || !parts[1].presence
+      raise ANG::Exceptions::InvalidMediaType.new @type
+    end
 
     @base_part = parts[0]
     @sub_part = parts[1]

src/accept_language.cr

@@ -21,7 +21,7 @@ struct Athena::Negotiation::AcceptLanguage < Athena::Negotiation::BaseAccept
       @script = parts[1]
       @region = parts[2]
     else
-      raise "Invalid language: '#{@value}'."
+      raise ANG::Exceptions::InvalidLanguage.new @type
     end
   end
 end

src/athena-negotiation.cr

@@ -14,7 +14,7 @@ require "./exceptions/*"
 alias ANG = Athena::Negotiation
 
 module Athena::Negotiation
-  # Returns an `ANG::Negotiation` singleton instance.
+  # Returns an `ANG::Negotiator` singleton instance.
   class_getter(negotiator) { ANG::Negotiator.new }
 
   # Returns an `ANG::CharsetNegotiator` singleton instance.

src/exceptions/invalid_language.cr

@@ -0,0 +1,7 @@
+require "./negotiation_exception"
+
+class Athena::Negotiation::Exceptions::InvalidLanguage < Athena::Negotiation::Exceptions::Exception
+  def initialize(type : String, cause : Exception? = nil)
+    super type, "Invalid language: '#{type}'.", cause
+  end
+end

src/exceptions/invalid_media_type.cr

@@ -1,9 +1,7 @@
 require "./negotiation_exception"
 
 class Athena::Negotiation::Exceptions::InvalidMediaType < Athena::Negotiation::Exceptions::Exception
-  getter type : String
+  def initialize(type : String, cause : Exception? = nil)
-
+    super type, "Invalid media type: '#{type}'.", cause
-  def initialize(@type : String, message : String? = nil, cause : Exception? = nil)
-    super message, cause
   end
 end

src/exceptions/negotiation_exception.cr

@@ -1,2 +1,7 @@
 abstract class Athena::Negotiation::Exceptions::Exception < ::Exception
+  getter type : String
+
+  def initialize(@type : String, message : String? = nil, cause : Exception? = nil)
+    super message, cause
+  end
 end

src/negotiator.cr

@@ -50,8 +50,6 @@ class Athena::Negotiation::Negotiator < Athena::Negotiation::AbstractNegotiator
          (accept_plus == "*" || priority_plus == '*' || plus_equal) &&
          intercection.size == accept.parameters.size
        )
-      # TODO: Calculate intercection between each header's parameters
-
       score = 100 * (base_equal ? 1 : 0) + 10 * (sub_equal ? 1 : 0) + (plus_equal ? 1 : 0) + intercection.size
       return ANG::AcceptMatch.new accept.quality * priority.quality, score, index
     end