132 commits

Author	SHA1	Message	Date
Sijawusz Pur Rahnama	496e8930e2	Merge pull request #303 from crystal-ameba/Sija/lint-literal-assignments-in-expressions-rule ... Add `Lint/LiteralAssignmentsInExpressions` rule	2022-11-17 14:19:17 +01:00
Sijawusz Pur Rahnama	95d68114c7	Fix typos throughout the code	2022-11-16 16:55:32 +01:00
Sijawusz Pur Rahnama	5c08b64e72	Add Lint/LiteralAssignmentsInExpressions rule	2022-11-16 15:08:41 +01:00
Sijawusz Pur Rahnama	2fb37da80f	Refactor AST::Util#literal? helper	2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama	e668ba5bf5	Readability-related refactors	2022-11-14 02:26:52 +01:00
Vitalii Elenhaupt	2811352cae	Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly ... Fix specs on Crystal nightly	2022-11-13 21:07:29 +02:00
Sijawusz Pur Rahnama	5f46612e89	Remove obsolete spec	2022-11-13 01:32:49 +01:00
Sijawusz Pur Rahnama	84540d2a22	Change to alternative approach skipping all macro contexts	2022-11-13 01:25:24 +01:00
Sijawusz Pur Rahnama	5491d31b5f	Fix the edge case re: free var comparison	2022-11-13 01:24:59 +01:00
Sijawusz Pur Rahnama	6bf8db81e3	Refactor Lint/StaticComparison to LiteralsComparison	2022-11-02 02:00:37 +01:00
Sijawusz Pur Rahnama	ea42911c3c	Extend StaticComparison w/ support of === operator	2022-11-01 03:35:20 +01:00
Sijawusz Pur Rahnama	849be52618	Add Lint/StaticComparison rule	2022-11-01 03:34:28 +01:00
Sijawusz Pur Rahnama	63407c1bd1	Rename to Lint/NotNilAfterNoBang	2022-11-01 02:13:04 +01:00
Sijawusz Pur Rahnama	9515e624c3	Add Lint/NotNilWithNoBang rule	2022-10-31 14:17:47 +01:00
Sijawusz Pur Rahnama	67356f246b	Add Lint/NotNil rule	2022-10-30 21:36:47 +01:00
Sijawusz Pur Rahnama	e2faffacfe	Merge branch 'master' into fix/crystal-nightly	2022-04-05 00:37:48 +02:00
Sijawusz Pur Rahnama	20db75a54a	Fix typo in UnneededDisableDirective rule spec filename	2022-04-04 22:30:23 +02:00
Sijawusz Pur Rahnama	390b26d7f1	Use issue expectation helpers in Lint::AmbiguousAssignment rule spec	2022-04-04 21:32:46 +02:00
Sijawusz Pur Rahnama	caeb1609c9	Use issue expectation helpers in Lint::BadDirective rule spec	2022-04-04 21:27:04 +02:00
Sijawusz Pur Rahnama	5283ae4a96	Use issue expectation helpers in Lint::EmptyLoop rule spec	2022-04-04 21:23:17 +02:00
Sijawusz Pur Rahnama	3cbb388393	Use issue expectation helpers in Lint::HashDuplicatedKey rule spec	2022-04-04 21:20:13 +02:00
Sijawusz Pur Rahnama	18316eaa8b	Use issue expectation helpers in Lint::LiteralInInterpolation rule spec	2022-04-04 21:16:48 +02:00
Sijawusz Pur Rahnama	7f85434c85	Use issue expectation helpers in Lint::RandZero rule spec	2022-04-04 21:14:45 +02:00
Sijawusz Pur Rahnama	c58d4cc65a	Use issue expectation helpers in Lint::Syntax rule spec	2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama	c89d32fcf6	Use issue expectation helpers in Lint::UselessConditionInWhen rule spec	2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama	c8daaf4324	Use issue expectation helpers in Lint::UnneededDisableDirective rule spec	2022-04-04 21:10:54 +02:00
Sijawusz Pur Rahnama	614fcfa6a8	Skip macro scopes in ShadowingOuterLocalVar	2022-04-04 01:38:04 +02:00
Sijawusz Pur Rahnama	ad5d56b313	Use issue expectation helpers in ShadowingOuterLocalVar spec	2022-04-04 01:30:27 +02:00
Sijawusz Pur Rahnama	353d09df29	Rename file according to the rule name	2022-04-04 00:42:22 +02:00
Vitalii Elenhaupt	8d4730182f	Rework breaking specs, break backward compatibility	2022-04-04 00:59:21 +03:00
Vitalii Elenhaupt	1f4dda1c4a	Add conditional check using semantic version	2022-04-03 20:16:00 +03:00
Vitalii Elenhaupt	087f470f15	Backward compatibility to Crystal 1.3	2022-04-03 19:17:47 +03:00
Vitalii Elenhaupt	7192b64df0	Fix rest of the specs	2022-03-11 18:00:25 +02:00
Sijawusz Pur Rahnama	66ee7642cf	Add Lint/DebugCalls rule	2021-12-31 16:44:02 +01:00
Johannes Müller	63bafba72e	Fix unexpected token compiler error match	2021-11-29 22:04:59 +01:00
fn ⌃ ⌥	63a6c73dc0	Autocorrect various rules (#253)	2021-11-16 22:30:33 +01:00
Vitalii Elenhaupt	429f76f8b6	Do not report unreachable code after loops ... closes #251	2021-11-10 09:16:14 +02:00
fn ⌃ ⌥	7b437fbd2f	Remove normalize parameter from expect_issue (#249) ... * Add `normalize` parameter to `expect_correction` * Convert Style/IsAFilter spec * Revert "Add `normalize` parameter to `expect_correction`" This reverts commit 4b67e4b900. * Remove `normalize` parameter from `expect_issue` * Require indentation if multiple issues on a single line * Update `Style/IsAFilter` spec * Update `ExpectIssue` documentation * Add missing `expect_no_corrections` * Use carets and space with issues at column 1 or 2 * Update `expect_issue` docs	2021-11-06 15:15:19 +02:00
fn ⌃ ⌥	3d432fdee8	Add expect_issue and expect_no_issues spec helpers (#245)	2021-10-22 19:54:39 +02:00
fn ⌃ ⌥	48b15b9bf8	Add Lint/AmbiguousAssignment rule (#244)	2021-10-19 11:44:41 +02:00
Sijawusz Pur Rahnama	43dea0e49d	Fix typos throughout the codebase	2021-07-03 14:15:23 +02:00
Vitalii Elenhaupt	a64f48b543	ShadowingOuterLocalVar while it is not in macro ... closes #224	2021-04-18 20:55:10 +03:00
Sijawusz Pur Rahnama	99da6b6916	Merge remote-tracking branch 'origin/master' into master-into-develop	2021-02-03 22:45:35 +01:00
Vitalii Elenhaupt	ecad80a96b	NewRule: SpecFocus ... closes #172	2021-02-03 17:10:07 +02:00
Vitalii Elenhaupt	51b0a07e81	Avoid exponential recursion while finding variable references in scopes (#203) ... * Avoid exponential recursion while finding variable references in scopes * Adjust source example in test	2021-01-31 16:40:44 +02:00
Vitalii Elenhaupt	7aa7efd4bd	Do not report if variable is assigned and referenced in MacroFor/MacroIf/MacroExpression ... closes #194	2021-01-20 13:14:42 +02:00
Vitalii Elenhaupt	e9ec91654c	New Rule: Lint/DuplicatedRequire ... closes https://github.com/crystal-ameba/ameba/issues/176	2021-01-17 22:32:24 +02:00
Sijawusz Pur Rahnama	1a091c1f1a	Optimize rules (#185) ... * Replace pointless interpolations with actual values * Rules optimizations * Stylistic refactors * Remove extraneous blank lines * Remove some instances of .not_nil! usage	2021-01-17 14:16:04 +02:00
Vitalii Elenhaupt	44290a6a5d	Handle case when compiler reports incorrect node location ... fixes #168	2020-10-23 10:41:17 +03:00
Vitalii Elenhaupt	f8d57345d4	Merge branch 'develop'	2020-08-26 22:46:03 +03:00
Vitalii Elenhaupt	b5bd76dfa8	Useless Assign: ignore variables with '_' prefix ... closes #164	2020-08-20 21:15:58 +03:00
Vitalii Elenhaupt	d650ca5477	Incorrectly reporting shadowingOuterLocalVar within macro included ... closes #161	2020-07-15 10:18:12 +03:00
Vitalii Elenhaupt	7f501a1df5	RedundantStringCoercion: do not report to_s with named args ... closes #160	2020-06-24 09:26:03 +03:00
Sijawusz Pur Rahnama	1a25583036	Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict (#146)	2020-04-11 09:55:41 +03:00
Vitalii Elenhaupt	458c492730	Do not report shadowing outer local var is var is declared below the ... shadowed var closes #144	2020-04-10 10:44:42 +03:00
Vitalii Elenhaupt	99c65b5a28	New rule: Lint/BadDirective (#143) ... * New rule: Lint/BadDirective * Address PR feedback	2020-04-06 15:10:34 +03:00
Vitalii Elenhaupt	04497feeed	Lint/LiteralInInterpolation: properly report node position	2020-03-27 19:44:04 +02:00
Vitalii Elenhaupt	59bc021e57	Do not report if Object#to_s is called without receiver	2020-03-26 23:51:54 +02:00
Vitalii Elenhaupt	ff1669ebe8	New rule: Lint/RedundantStringCoercion	2020-03-26 16:26:27 +02:00
Vitalii Elenhaupt	a6958ab455	New rule: EmptyLoop	2020-03-26 10:27:00 +02:00
Vitalii Elenhaupt	4f185db0a2	New rule: SharedVarInSpawn ... closes #132	2020-03-25 17:52:20 +02:00
Vitalii Elenhaupt	aff723b682	Incorrectly reporting shadowingOuterLocalVar within macro included ... closes #129	2020-02-15 20:49:47 +02:00
Vitalii Elenhaupt	74dfa0b934	Lint/UselessAssign: ignore transformed assignemnts by the compiler ... closes #127	2020-01-11 23:51:28 +02:00
Vitalii Elenhaupt	6b56c87e78	Shadowing via short instance variable syntax ... closes #122	2019-11-11 15:51:09 +02:00
Vitalii Elenhaupt	fde321f7e6	New rule: RedundantWithObject (#121)	2019-11-10 09:47:30 +02:00
Vitalii Elenhaupt	b6cc454039	New rule: RedundantWithIndex (#120)	2019-11-10 09:29:17 +02:00
Vitalii Elenhaupt	904b5beec2	Lint/UnusedArgument: fails to recognized used argument inside macro ... closes #117	2019-10-27 21:32:55 +02:00
Vitalii Elenhaupt	677c75716f	Typeof scope	2019-10-27 21:22:33 +02:00
Vitalii Elenhaupt	ffa5dc9b4c	Crystal 0.29 fixes (#109) ... * Fixes vs crystal head * Use crystal nightly * Remove trailing ? from local variable * Do not use ? in the lhs ref https://github.com/crystal-lang/crystal/issues/6685#issuecomment-419758587 * Upgrade to crystal 0.29.0 (warnings free) (#108) * Remove trailing ? from local variable (take 2) * Fix Time.now deprecation warnings * Remove Crystal nightly	2019-06-06 19:10:26 +03:00
Vitalii Elenhaupt	f6a57f9272	Set default severities	2019-04-14 12:15:38 +03:00
Vitalii Elenhaupt	3a71b86193	Properly report literals (#96)	2019-03-23 19:20:32 +02:00
Sijawusz Pur Rahnama	e8a68a80d5	Fix several misspellings (#94)	2019-02-23 07:06:28 +02:00
Vitalii Elenhaupt	60ce034f1b	UnusedArgument: fix crystal upgrade regression	2018-12-12 22:21:33 +02:00
Vitalii Elenhaupt	9885457227	Track issue.end_location properly	2018-11-24 19:38:13 +02:00
V. Elenhaupt	0fd5890738	Extend UnreachableCode rule: handle control flow (#83)	2018-11-22 10:38:32 +02:00
Vitalii Elenhaupt	eca0f3f350	Handle raise, exit, abort in unreachable code	2018-11-11 20:33:48 +02:00
Vitalii Elenhaupt	67d76116f7	Basic implementation of UnreachableCode rule	2018-11-05 21:39:27 +02:00
Vitalii Elenhaupt	d7b0e10d1e	Normalize sources for tests	2018-09-07 15:07:03 +03:00
V. Elenhaupt	cb5f802012	Correctly process record declaration at a top level (#78)	2018-09-07 00:47:02 +03:00
Vitalii Elenhaupt	dbac46b68a	Ignore outer shadowing of throwaway variables ... closes #67	2018-06-25 17:02:46 +03:00
Vitalii Elenhaupt	04c7300964	Handle type declarations in scopes ... closes #66	2018-06-23 08:48:13 +03:00
V. Elenhaupt	4cb5328513	Add rule namespaces: style, lint, layout (#63)	2018-06-16 14:50:59 +03:00