Commit graph

88 commits

Author SHA1 Message Date
Sijawusz Pur Rahnama
858557bc07 Add Lint/UnusedBlockArgument rule 2022-12-15 18:35:16 +01:00
Sijawusz Pur Rahnama
9df66e890b Do not report anonymous block arguments in Lint/UnusedArgument 2022-12-12 18:21:19 +01:00
Sijawusz Pur Rahnama
99c81d3630 Add spec for positive case in macro scope in Lint/LiteralsComparison rule 2022-12-09 23:53:39 +01:00
Sijawusz Pur Rahnama
2fb453c61f Add additional spec for Lint/NotNil rule 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
2cb8c1381f Don’t treat crystal paths as literals in Lint/LiteralsComparison 2022-12-08 13:55:29 +01:00
Sijawusz Pur Rahnama
38eb5d5e50 Fix invalid crystal syntax in Lint/Syntax rule spec 2022-11-23 03:26:55 +01:00
Sijawusz Pur Rahnama
496e8930e2
Merge pull request #303 from crystal-ameba/Sija/lint-literal-assignments-in-expressions-rule
Add `Lint/LiteralAssignmentsInExpressions` rule
2022-11-17 14:19:17 +01:00
Sijawusz Pur Rahnama
95d68114c7 Fix typos throughout the code 2022-11-16 16:55:32 +01:00
Sijawusz Pur Rahnama
5c08b64e72 Add Lint/LiteralAssignmentsInExpressions rule 2022-11-16 15:08:41 +01:00
Sijawusz Pur Rahnama
2fb37da80f Refactor AST::Util#literal? helper 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama
e668ba5bf5 Readability-related refactors 2022-11-14 02:26:52 +01:00
Vitalii Elenhaupt
2811352cae
Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly
Fix specs on Crystal nightly
2022-11-13 21:07:29 +02:00
Sijawusz Pur Rahnama
5f46612e89 Remove obsolete spec 2022-11-13 01:32:49 +01:00
Sijawusz Pur Rahnama
84540d2a22 Change to alternative approach skipping all macro contexts 2022-11-13 01:25:24 +01:00
Sijawusz Pur Rahnama
5491d31b5f Fix the edge case re: free var comparison 2022-11-13 01:24:59 +01:00
Sijawusz Pur Rahnama
6bf8db81e3 Refactor Lint/StaticComparison to LiteralsComparison 2022-11-02 02:00:37 +01:00
Sijawusz Pur Rahnama
ea42911c3c Extend StaticComparison w/ support of === operator 2022-11-01 03:35:20 +01:00
Sijawusz Pur Rahnama
849be52618 Add Lint/StaticComparison rule 2022-11-01 03:34:28 +01:00
Sijawusz Pur Rahnama
63407c1bd1 Rename to Lint/NotNilAfterNoBang 2022-11-01 02:13:04 +01:00
Sijawusz Pur Rahnama
9515e624c3 Add Lint/NotNilWithNoBang rule 2022-10-31 14:17:47 +01:00
Sijawusz Pur Rahnama
67356f246b Add Lint/NotNil rule 2022-10-30 21:36:47 +01:00
Sijawusz Pur Rahnama
e2faffacfe
Merge branch 'master' into fix/crystal-nightly 2022-04-05 00:37:48 +02:00
Sijawusz Pur Rahnama
20db75a54a Fix typo in UnneededDisableDirective rule spec filename 2022-04-04 22:30:23 +02:00
Sijawusz Pur Rahnama
390b26d7f1 Use issue expectation helpers in Lint::AmbiguousAssignment rule spec 2022-04-04 21:32:46 +02:00
Sijawusz Pur Rahnama
caeb1609c9 Use issue expectation helpers in Lint::BadDirective rule spec 2022-04-04 21:27:04 +02:00
Sijawusz Pur Rahnama
5283ae4a96 Use issue expectation helpers in Lint::EmptyLoop rule spec 2022-04-04 21:23:17 +02:00
Sijawusz Pur Rahnama
3cbb388393 Use issue expectation helpers in Lint::HashDuplicatedKey rule spec 2022-04-04 21:20:13 +02:00
Sijawusz Pur Rahnama
18316eaa8b Use issue expectation helpers in Lint::LiteralInInterpolation rule spec 2022-04-04 21:16:48 +02:00
Sijawusz Pur Rahnama
7f85434c85 Use issue expectation helpers in Lint::RandZero rule spec 2022-04-04 21:14:45 +02:00
Sijawusz Pur Rahnama
c58d4cc65a Use issue expectation helpers in Lint::Syntax rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c89d32fcf6 Use issue expectation helpers in Lint::UselessConditionInWhen rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c8daaf4324 Use issue expectation helpers in Lint::UnneededDisableDirective rule spec 2022-04-04 21:10:54 +02:00
Sijawusz Pur Rahnama
614fcfa6a8 Skip macro scopes in ShadowingOuterLocalVar 2022-04-04 01:38:04 +02:00
Sijawusz Pur Rahnama
ad5d56b313 Use issue expectation helpers in ShadowingOuterLocalVar spec 2022-04-04 01:30:27 +02:00
Sijawusz Pur Rahnama
353d09df29 Rename file according to the rule name 2022-04-04 00:42:22 +02:00
Vitalii Elenhaupt
8d4730182f
Rework breaking specs, break backward compatibility 2022-04-04 00:59:21 +03:00
Vitalii Elenhaupt
1f4dda1c4a
Add conditional check using semantic version 2022-04-03 20:16:00 +03:00
Vitalii Elenhaupt
087f470f15
Backward compatibility to Crystal 1.3 2022-04-03 19:17:47 +03:00
Vitalii Elenhaupt
7192b64df0
Fix rest of the specs 2022-03-11 18:00:25 +02:00
Sijawusz Pur Rahnama
66ee7642cf Add Lint/DebugCalls rule 2021-12-31 16:44:02 +01:00
Johannes Müller
63bafba72e
Fix unexpected token compiler error match 2021-11-29 22:04:59 +01:00
fn ⌃ ⌥
63a6c73dc0
Autocorrect various rules (#253) 2021-11-16 22:30:33 +01:00
Vitalii Elenhaupt
429f76f8b6
Do not report unreachable code after loops
closes #251
2021-11-10 09:16:14 +02:00
fn ⌃ ⌥
7b437fbd2f
Remove normalize parameter from expect_issue (#249)
* Add `normalize` parameter to `expect_correction`

* Convert Style/IsAFilter spec

* Revert "Add `normalize` parameter to `expect_correction`"

This reverts commit 4b67e4b900.

* Remove `normalize` parameter from `expect_issue`

* Require indentation if multiple issues on a single line

* Update `Style/IsAFilter` spec

* Update `ExpectIssue` documentation

* Add missing `expect_no_corrections`

* Use carets and space with issues at column 1 or 2

* Update `expect_issue` docs
2021-11-06 15:15:19 +02:00
fn ⌃ ⌥
3d432fdee8
Add expect_issue and expect_no_issues spec helpers (#245) 2021-10-22 19:54:39 +02:00
fn ⌃ ⌥
48b15b9bf8
Add Lint/AmbiguousAssignment rule (#244) 2021-10-19 11:44:41 +02:00
Sijawusz Pur Rahnama
43dea0e49d Fix typos throughout the codebase 2021-07-03 14:15:23 +02:00
Vitalii Elenhaupt
a64f48b543
ShadowingOuterLocalVar while it is not in macro
closes #224
2021-04-18 20:55:10 +03:00
Sijawusz Pur Rahnama
99da6b6916 Merge remote-tracking branch 'origin/master' into master-into-develop 2021-02-03 22:45:35 +01:00
Vitalii Elenhaupt
ecad80a96b
NewRule: SpecFocus
closes #172
2021-02-03 17:10:07 +02:00