Commit Graph

749 Commits

Author SHA1 Message Date
Sijawusz Pur Rahnama 496e8930e2
Merge pull request #303 from crystal-ameba/Sija/lint-literal-assignments-in-expressions-rule
Add `Lint/LiteralAssignmentsInExpressions` rule
2022-11-17 14:19:17 +01:00
Sijawusz Pur Rahnama 243071700d
Merge pull request #306 from crystal-ameba/Sija/fix-typos
Fix typos throughout the code
2022-11-16 18:42:22 +01:00
Sijawusz Pur Rahnama 95d68114c7 Fix typos throughout the code 2022-11-16 16:55:32 +01:00
Sijawusz Pur Rahnama f9b6b17657
Merge pull request #305 from crystal-ameba/Sija/followup-to-pr-300
Few more readability refactors
2022-11-16 16:26:59 +01:00
Sijawusz Pur Rahnama 5c08b64e72 Add `Lint/LiteralAssignmentsInExpressions` rule 2022-11-16 15:08:41 +01:00
Sijawusz Pur Rahnama 28e2871165
Merge pull request #301 from crystal-ameba/Sija/style-redundant-parentheses-rule
Add `Style/RedundantParentheses` rule
2022-11-16 12:22:39 +01:00
Sijawusz Pur Rahnama b5ac5990ec
Merge pull request #304 from crystal-ameba/Sija/refactor-ast-util-literal 2022-11-16 11:01:03 +01:00
Sijawusz Pur Rahnama 935296b041 Refactor ternary handling in `Style/RedundantParentheses` rule 2022-11-16 03:54:31 +01:00
Sijawusz Pur Rahnama e54029d8ed Few more readability refactors 2022-11-15 20:55:32 +01:00
Sijawusz Pur Rahnama 76a4209706 Tweak comments in `AST::Util` 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama 2fb37da80f Refactor `AST::Util#literal?` helper 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama 3340613a6a Fix newly found issue 2022-11-15 15:17:32 +01:00
Sijawusz Pur Rahnama cbf5d3de74 Add `Style/RedundantParentheses` rule 2022-11-15 15:17:32 +01:00
Vitalii Elenhaupt cc687d0281
Bump v1.3.1 2022-11-15 09:15:15 +02:00
Sijawusz Pur Rahnama 04b19a60db
Merge pull request #300 from crystal-ameba/Sija/some-refactors
Misc refactors
2022-11-14 17:27:29 +01:00
Sijawusz Pur Rahnama db5eee76cb
Merge pull request #299 from crystal-ameba/Sija/refactor-style-predicate-name-rule 2022-11-14 14:07:33 +01:00
Sijawusz Pur Rahnama e668ba5bf5 Readability-related refactors 2022-11-14 02:26:52 +01:00
Sijawusz Pur Rahnama a6ebb48f14 Remove redundant parentheses in `if` expressions
+ `elsif` -> `case`
2022-11-14 01:52:07 +01:00
Sijawusz Pur Rahnama d1bfdaabeb Use `#in?` instead of `#includes?` in several places
Because:

1. it’s more semantically descriptive
2. it’s shorter
2022-11-14 01:18:43 +01:00
Sijawusz Pur Rahnama ed6085e6a6 Several refactors in `Style/GuardClause` rule
Mostly readability related
2022-11-14 01:18:43 +01:00
Sijawusz Pur Rahnama 353c0a1583 Fix typo + add `NOTE` pragma 2022-11-14 01:05:13 +01:00
Sijawusz Pur Rahnama 5db7a2cf5a Turn on `Style/PredicateName` rule by default 2022-11-13 20:12:39 +01:00
Sijawusz Pur Rahnama 52bf0a5be4 Refactor `Style/PredicateName` rule
Do not report `has_<name>?` method names
2022-11-13 20:12:23 +01:00
Vitalii Elenhaupt 2811352cae
Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly
Fix specs on Crystal nightly
2022-11-13 21:07:29 +02:00
Sijawusz Pur Rahnama df4b49798e
Merge pull request #297 from crystal-ameba/Sija/fix-issue-295
Fix the edge case re: free var comparison
2022-11-13 17:35:43 +01:00
Sijawusz Pur Rahnama 5f46612e89 Remove obsolete spec 2022-11-13 01:32:49 +01:00
Sijawusz Pur Rahnama 84540d2a22 Change to alternative approach skipping all macro contexts 2022-11-13 01:25:24 +01:00
Sijawusz Pur Rahnama 5491d31b5f Fix the edge case re: free var comparison 2022-11-13 01:24:59 +01:00
Sijawusz Pur Rahnama 1a26ebcfed
Merge pull request #296 from crystal-ameba/Sija/dockerfile-alpine-edge 2022-11-10 11:03:41 +01:00
Sijawusz Pur Rahnama 2805e12b9c
Use `alpine:edge` for ameba builder image 2022-11-10 04:42:13 +01:00
Vitalii Elenhaupt 35ff16206c
Bump v1.3.0 2022-11-03 15:21:53 +02:00
Sijawusz Pur Rahnama 816c8b11cd
Merge pull request #293 from crystal-ameba/Sija/refactor-static-comparison-rule 2022-11-02 10:10:52 +01:00
Sijawusz Pur Rahnama aee5de517b Add `Crystal::Path` to the list of primitive types
So, the  comparisons like `Regex == 1=42` will also be detected.
2022-11-02 02:06:22 +01:00
Sijawusz Pur Rahnama 6bf8db81e3 Refactor `Lint/StaticComparison` to `LiteralsComparison` 2022-11-02 02:00:37 +01:00
Sijawusz Pur Rahnama 23ca87ff0e
Merge pull request #292 from crystal-ameba/Sija/lint-static-comparison 2022-11-01 11:12:19 +01:00
Sijawusz Pur Rahnama ea42911c3c Extend `StaticComparison` w/ support of `===` operator 2022-11-01 03:35:20 +01:00
Sijawusz Pur Rahnama 849be52618 Add `Lint/StaticComparison` rule 2022-11-01 03:34:28 +01:00
Sijawusz Pur Rahnama 078c83c2d7
Merge pull request #291 from crystal-ameba/Sija/lint-not-nil-with-no-bang-rule
Add `Lint/NotNilAfterNoBang` rule
2022-11-01 02:16:48 +01:00
Sijawusz Pur Rahnama 63407c1bd1 Rename to `Lint/NotNilAfterNoBang` 2022-11-01 02:13:04 +01:00
Sijawusz Pur Rahnama 9515e624c3 Add `Lint/NotNilWithNoBang` rule 2022-10-31 14:17:47 +01:00
Sijawusz Pur Rahnama 8d4a4dfd7a
Merge pull request #290 from crystal-ameba/Sija/remove-trailing-dots-from-rule-descriptions
Remove trailing dots from rule descriptions
2022-10-30 23:51:32 +01:00
Sijawusz Pur Rahnama 038a3657c0
Merge pull request #288 from crystal-ameba/Sija/lint-not-nil-rule
Add `Lint/NotNil` rule
2022-10-30 23:50:38 +01:00
Sijawusz Pur Rahnama d942524efa Remove trailing dots from rule descriptions 2022-10-30 21:53:09 +01:00
Sijawusz Pur Rahnama eb64fde437 Fix few issues reported by the newly added rule 2022-10-30 21:44:55 +01:00
Sijawusz Pur Rahnama 67356f246b Add `Lint/NotNil` rule 2022-10-30 21:36:47 +01:00
Sijawusz Pur Rahnama 6834292265
Merge pull request #287 from crystal-ameba/enable-lint-empty-expression-by-default
Enable `Lint/EmptyExpression` by default
2022-10-30 21:01:28 +01:00
Sijawusz Pur Rahnama e503c9393a
Merge pull request #289 from crystal-ameba/Sija/fix-corrector-remove-leading-trailing-methods
Fix `Source::Corrector#remove_{leading,trailing}` methods
2022-10-30 21:00:52 +01:00
Sijawusz Pur Rahnama e54e5d0534 Fix `Source::Corrector#remove_{leading,trailing}` methods 2022-10-30 19:50:25 +01:00
Sijawusz Pur Rahnama 2d3bca7b1a
Enable `Lint/EmptyExpression` by default 2022-10-30 15:30:55 +01:00
Sijawusz Pur Rahnama 09aea3da32
Merge pull request #286 from crystal-ameba/Sija/fix-issue-285 2022-10-30 10:46:21 +01:00