Commit graph

872 commits

Author SHA1 Message Date
Sijawusz Pur Rahnama
d843afd962
Merge pull request #250 from FnControlOption/spec/style
Use `expect_issue` in `Style` specs
2021-11-09 22:35:38 +01:00
fn ⌃ ⌥
d06812ea8e Add VariableNames test for method with multiple instance vars 2021-11-09 11:52:31 -08:00
fn ⌃ ⌥
01dfcbe76a Add tests for AST::Util#control_exp_code 2021-11-09 11:52:31 -08:00
fn ⌃ ⌥
c9ba487373 Add custom NodeVisitor subclass for Style/VariableNames 2021-11-09 09:26:00 -08:00
fn ⌃ ⌥
bd1a1a1fd4 Shorten long line in Stye/VerboseBlock spec 2021-11-09 09:07:19 -08:00
fn ⌃ ⌥
b32b00adad Convert remaining Style specs 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
72a3487bb6 Autocorrect Stye/WhileTrue 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
571969265f Convert Style/VerboseBlock spec 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
e93dfe9cdc Convert Style/VariableNames spec 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
265bc51481 Convert Style/UnlessElse spec 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
06c0887136 Convert Style/TypeNames spec 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
e7cfe387d6 Autocorrect Stye/RedundantNext and Style/RedundantReturn 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
7b437fbd2f
Remove normalize parameter from expect_issue (#249)
* Add `normalize` parameter to `expect_correction`

* Convert Style/IsAFilter spec

* Revert "Add `normalize` parameter to `expect_correction`"

This reverts commit 4b67e4b900.

* Remove `normalize` parameter from `expect_issue`

* Require indentation if multiple issues on a single line

* Update `Style/IsAFilter` spec

* Update `ExpectIssue` documentation

* Add missing `expect_no_corrections`

* Use carets and space with issues at column 1 or 2

* Update `expect_issue` docs
2021-11-06 15:15:19 +02:00
Sijawusz Pur Rahnama
7cb0c15747
Merge pull request #248 from FnControlOption/autocorrect
Add autocorrect
2021-11-01 20:24:43 +01:00
fn ⌃ ⌥
78071722c4 Rename s to source 2021-11-01 08:55:48 -07:00
fn ⌃ ⌥
c2aa2fedb6 Return source from expect_issue 2021-10-31 22:44:48 -07:00
fn ⌃ ⌥
470e41cb7b Raise error if attempting to both explain issue and autocorrect 2021-10-31 22:23:14 -07:00
fn ⌃ ⌥
a40fdee33f Revert "Add autocorrect checks to ExplainFormatter"
This reverts commit 1b6fe40a3b.
2021-10-31 22:12:21 -07:00
Vitalii Elenhaupt
3e1df339ae
Consistent parser options 2021-11-01 02:08:16 +02:00
fn ⌃ ⌥
61fc99e107 Inline the do_combine method 2021-10-27 11:19:15 -07:00
fn ⌃ ⌥
73e97ac42e Avoid using iterators and throw-away heap allocations 2021-10-27 11:08:18 -07:00
fn ⌃ ⌥
b7bb282b99 Apply suggestions from code review 2021-10-27 10:08:36 -07:00
fn ⌃ ⌥
d51ef27d54 Add remove_preceding, remove_leading, remove_trailing 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
1b6fe40a3b Add autocorrect checks to ExplainFormatter 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
8d3b76003e Add autocorrect checks to Flycheck, JSON, and TODO formatters 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
749c53527e Add documentation 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
437584f9db Raise error if infinite correction loop 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
16608965f5 Allowed named arguments with Rule::Base.issue_for 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
3b11491cea Add insert_* overloads that accept both location and end_location 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
e8c0f49cb8 Delete redundant alias SourceLocation 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
f87d99a83b Add Corrector method overloads that accept ASTNode 2021-10-26 22:22:22 -07:00
fn ⌃ ⌥
1d5f554e88 Apply suggestions from code review 2021-10-26 12:06:24 -07:00
fn ⌃ ⌥
f39a7a4cd4 Re-run autocorrect until all correctable issues have been corrected 2021-10-25 15:09:44 -07:00
fn ⌃ ⌥
573881cb8a Autocorrect Layout/TrailingBlankLines partially 2021-10-25 12:38:29 -07:00
fn ⌃ ⌥
e5fb0526e0 Autocorrect Style/LargeNumbers 2021-10-25 12:38:29 -07:00
fn ⌃ ⌥
99e7ccd23b Add --autocorrect CLI option 2021-10-25 12:38:29 -07:00
fn ⌃ ⌥
d3d3ccd7e3 Add expect_correction and expect_no_corrections 2021-10-25 12:38:29 -07:00
fn ⌃ ⌥
c1b4add094 Add Source::Corrector and Source::Rewriter 2021-10-25 12:38:29 -07:00
Vitalii Elenhaupt
dafae6ca77
Merge pull request #246 from FnControlOption/replacements
Allow named replacements in expect_issue
2021-10-25 21:40:40 +03:00
fn ⌃ ⌥
9f0b9a709e Allow named replacements in expect_issue 2021-10-23 01:37:24 -07:00
fn ⌃ ⌥
3d432fdee8
Add expect_issue and expect_no_issues spec helpers (#245) 2021-10-22 19:54:39 +02:00
fn ⌃ ⌥
48b15b9bf8
Add Lint/AmbiguousAssignment rule (#244) 2021-10-19 11:44:41 +02:00
Vitalii Elenhaupt
9a91e42bcc
Merge pull request #239 from crystal-ameba/Sija/fix-typos
Fix typos throughout the codebase
2021-07-03 21:53:12 +03:00
Sijawusz Pur Rahnama
43dea0e49d Fix typos throughout the codebase 2021-07-03 14:15:23 +02:00
Sijawusz Pur Rahnama
720810c3cb
Merge pull request #238 from caspiano/exhaustive-case-complexity
Count an exhaustive `case` complexity as 1
2021-06-05 20:49:28 +02:00
Sijawusz Pur Rahnama
651f70f680
Update spec/ameba/ast/visitors/counting_visitor_spec.cr 2021-06-05 20:49:00 +02:00
Caspian Baska
c49c69ed9f
Early return in CountVisitor if macro node
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
2021-06-06 04:12:56 +10:00
Caspian Baska
0ea6238dc6
Count an exhaustive case's complexity as 1 2021-06-05 22:31:58 +10:00
Vitalii Elenhaupt
df14fda0d8
Bump v0.14.3 2021-04-18 20:56:36 +03:00
Vitalii Elenhaupt
a64f48b543
ShadowingOuterLocalVar while it is not in macro
closes #224
2021-04-18 20:55:10 +03:00