Sijawusz Pur Rahnama
09fdac6be9
Refactor Lint::Documentation rule to use a custom visitor
2023-05-29 16:33:45 +02:00
Sijawusz Pur Rahnama
1a9a58b3cd
Add Lint/Documentation rule
2023-05-29 16:32:51 +02:00
Sijawusz Pur Rahnama
60948fffd0
Merge pull request #373 from crystal-ameba/fix-372
...
Raise when empty severity provided to `SeverityYamlConverter.from_yaml`
2023-05-09 14:28:17 +02:00
Sijawusz Pur Rahnama
d0d8b18c83
Raise when empty severity provided to SeverityYamlConverter.from_yaml
2023-05-09 13:02:10 +02:00
Sijawusz Pur Rahnama
14f6ba0c0b
Merge pull request #323 from crystal-ameba/Sija/lint-not-nil-after-no-bang-reports-rindex-calls
...
Make `Lint/NotNilAfterNoBang` report calls to `#rindex`
2023-05-01 11:16:42 +02:00
Vitalii Elenhaupt
149080ae16
Merge pull request #369 from daliborfilus/fix-crystal-1.8-pcre2-docker-build
...
Update Dockerfile for Crystal 1.8 + check if binary works
2023-04-24 09:46:09 +03:00
Dalibor Filus
454a747a68
Update Dockerfile for Crystal 1.8 + check if binary works
...
Crystal 1.8.0+ require pcre2.
Let's also add `RUN ameba -v` to check if the binary actually works.
Fixes cases like this:
```shell
$ docker run --rm -ti ameba:latest sh
Error loading shared library libpcre2-8.so.0: No such file or directory (needed by /usr/bin/ameba)
Error relocating /usr/bin/ameba: pcre2_get_ovector_count_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_config_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_get_ovector_pointer_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_match_data_create_from_pattern_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_jit_stack_assign_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_code_free_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_match_context_create_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_jit_compile_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_compile_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_get_error_message_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_jit_stack_create_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_match_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_match_data_free_8: symbol not found
Error relocating /usr/bin/ameba: pcre2_pattern_info_8: symbol not found
```
2023-04-22 11:41:49 +02:00
Vitalii Elenhaupt
ef2d05e48a
Merge pull request #366 from straight-shoota/fix/severity-spec-yaml-converter
...
Fix severity type for YAML converter spec
2023-04-05 17:35:19 +03:00
Johannes Müller
c7f2cba409
Fix severity type for YAML converter spec
2023-04-05 11:20:44 +02:00
Vitalii Elenhaupt
7c74d196d6
Bump v1.4.3
2023-03-17 10:24:44 +02:00
Vitalii Elenhaupt
adac90c7c6
Merge pull request #363 from zw963/master
...
Skip all config when use with --gen-config.
2023-03-09 08:34:47 +02:00
Billy.Zheng
239f64c278
Refactor
2023-03-09 12:41:40 +08:00
Billy.Zheng
e2528d93dd
Refactor spec to use be_false replace eq false
2023-03-09 12:39:25 +08:00
Billy.Zheng
48c7a2bde6
Add spec for verifying skip_reading_config? flag defaults to false.
2023-03-09 02:23:48 +08:00
Billy.Zheng
d45285d1c9
Skip all config when use with --gen-config.
2023-03-08 22:34:46 +08:00
Sijawusz Pur Rahnama
3fbbe3986e
Merge pull request #361 from crystal-ameba/issue-275
...
Support hierarchical loading of the config file
2023-03-07 11:11:35 +01:00
Sijawusz Pur Rahnama
4c59858f25
Apply code review suggestions
2023-03-06 21:22:47 +01:00
Sijawusz Pur Rahnama
8d56f22af1
Document the new Config.load behaviour
2023-03-06 21:19:47 +01:00
Sijawusz Pur Rahnama
e481a8d139
Use FILENAME constant consistently
2023-03-06 20:54:35 +01:00
Sijawusz Pur Rahnama
102e2834b6
Honor XDG_CONFIG_HOME ENV variable
...
Following XDG Spec: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
2023-03-06 20:54:35 +01:00
Sijawusz Pur Rahnama
749da0984c
Rename Config::PATH to Config::DEFAULT_PATH
2023-03-06 20:54:35 +01:00
Sijawusz Pur Rahnama
9534104942
Support hierarchical loading of the config file
2023-03-06 20:54:17 +01:00
Vitalii Elenhaupt
6f05df4006
Bump v1.4.2
2023-02-22 09:40:17 +02:00
Vitalii Elenhaupt
81177dc7e4
Merge pull request #356 from crystal-ameba/chore/crystal-nightly
...
chore: fix crystal-nightly compatibility
2023-02-19 18:06:31 +02:00
Vitalii Elenhaupt
d03f058cae
Add semicolon to the error message
2023-02-19 17:39:25 +02:00
Vitalii Elenhaupt
be8862837f
Improve error message reported to end user
2023-02-19 14:45:07 +02:00
Vitalii Elenhaupt
63a54986dd
Reformat code example
2023-02-19 13:24:54 +01:00
Vitalii Elenhaupt
801affc58b
Merge pull request #357 from crystal-ameba/fix/comments
...
fix(style): correct typo in rule doc
2023-02-19 13:53:49 +02:00
Vitalii Elenhaupt
c9c5fb655f
fix(style): correct typo in rule doc
2023-02-19 13:47:17 +02:00
Vitalii Elenhaupt
6717ac7b70
Merge pull request #355 from crystal-ameba/fix/unused_block_arg
...
fix(lint): Lint/UnusedBlockArgument is triggered by abstract def
2023-02-19 13:46:45 +02:00
Vitalii Elenhaupt
17e9566c7e
fix(lint): Lint/UnusedBlockArgument is triggered by abstract def
...
closes #352
2023-02-19 10:51:52 +02:00
Vitalii Elenhaupt
031c1daf58
chore: fix crystal-nightly compatibility
2023-02-19 09:30:05 +02:00
Vitalii Elenhaupt
a80672730c
Bump v1.4.1
2023-02-19 08:52:48 +02:00
Vitalii Elenhaupt
8f5d2cca6e
Merge pull request #351 from crystal-ameba/fix/useless-assign-type-def
...
fix(lint): useless assignment for type definition
2023-02-19 08:50:43 +02:00
Vitalii Elenhaupt
e7f4bb6ae3
Fix wording
2023-02-07 22:24:52 +02:00
Vitalii Elenhaupt
61a45d4321
Rework tests
2023-02-07 22:21:09 +02:00
Vitalii Elenhaupt
d20cc212b9
Styling changes
2023-02-07 20:03:52 +02:00
Vitalii Elenhaupt
6b2ddcb1d9
Address feedback, add tests
2023-02-07 17:19:04 +02:00
Vitalii Elenhaupt
14a9ec3a75
Incorporate changes for shadowing outer local var
2023-02-04 20:53:41 +02:00
Vitalii Elenhaupt
ddbcf5cb3f
fix(lint): useless assignment for type definition
...
closes #342
2023-02-04 16:57:46 +02:00
Sijawusz Pur Rahnama
de5c6ad4c6
Merge pull request #350 from crystal-ameba/dependabot/github_actions/docker/build-push-action-4
2023-01-30 22:40:28 +01:00
dependabot[bot]
00e39f6c41
Bump docker/build-push-action from 3 to 4
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](https://github.com/docker/build-push-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-30 21:36:27 +00:00
Sijawusz Pur Rahnama
bd68e8c3b3
Merge pull request #349 from crystal-ameba/Sija-patch-2
...
Remove SWUbanner
2023-01-28 12:18:48 +01:00
Sijawusz Pur Rahnama
8fbaf302ca
Remove SWUbanner
2023-01-28 12:14:19 +01:00
Sijawusz Pur Rahnama
2c044f8179
Merge pull request #348 from crystal-ameba/Sija-patch-2
...
Remove Travis CI references from `README.md`
2023-01-28 11:37:58 +01:00
Sijawusz Pur Rahnama
0efaed9091
Remove Travis CI references in README.md
2023-01-28 11:05:18 +01:00
Vitalii Elenhaupt
7be5af216e
Merge pull request #346 from crystal-ameba/remove-gitter
...
Remove gitter badge
2023-01-28 11:49:24 +02:00
Vitalii Elenhaupt
ff79cefaa8
Remove gitter badge
2023-01-28 09:35:55 +02:00
Vitalii Elenhaupt
7d0fcd4b87
Merge pull request #333 from crystal-ameba/Sija/release-1.4.0
...
Release 1.4.0
2023-01-28 09:32:50 +02:00
Vitalii Elenhaupt
a88299fa5c
Bump crystal 1.7
2023-01-23 19:35:03 +02:00
