Commit Graph

718 Commits

Author SHA1 Message Date
Sijawusz Pur Rahnama e7a6b6b153
Merge pull request #309 from crystal-ameba/Sija/refactor-base-rule 2022-11-23 13:50:45 +01:00
Sijawusz Pur Rahnama 735ec2462a Refactor usages of `\` to sth more readable if possible 2022-11-23 05:50:32 +01:00
Sijawusz Pur Rahnama 38eb5d5e50 Fix invalid crystal syntax in `Lint/Syntax` rule spec 2022-11-23 03:26:55 +01:00
Sijawusz Pur Rahnama 2c67fe2c3f Use tuple instead of an array 2022-11-23 03:23:42 +01:00
Sijawusz Pur Rahnama 8b43a40a65 Misc refactors 2022-11-23 03:22:27 +01:00
Sijawusz Pur Rahnama ffd63ef028 Fix typo in `AST::Branchable` example 2022-11-23 03:21:49 +01:00
Sijawusz Pur Rahnama 4500181ddb Remove redundant blank comment lines 2022-11-23 03:21:15 +01:00
Sijawusz Pur Rahnama 60813e4899 Test generated boolean rule property 2022-11-22 19:53:27 +01:00
Sijawusz Pur Rahnama 9f670c09b5 Refactor `TODOFormatter` spec 2022-11-22 19:52:32 +01:00
Sijawusz Pur Rahnama 2af58cabd4 Use `property?` for defining `Bool`-returning `Rule` properties 2022-11-22 19:49:16 +01:00
Sijawusz Pur Rahnama c7c75ee36a `Rule#enabled` -> `Rule#enabled?` 2022-11-22 19:47:37 +01:00
Sijawusz Pur Rahnama 31392046e0 Always return `Bool` value from `Rule#excluded?` 2022-11-22 19:45:16 +01:00
Sijawusz Pur Rahnama 39cc286263 Use tuple instead of array for `Rule::SPECIAL` 2022-11-22 19:44:38 +01:00
Sijawusz Pur Rahnama 6bd18f9cbf Fix typo 2022-11-22 19:43:52 +01:00
Sijawusz Pur Rahnama a3e5f2d206
Merge pull request #302 from crystal-ameba/Sija/style-parenthesized-assignments 2022-11-20 00:39:58 +01:00
Sijawusz Pur Rahnama 5ee4074c1b Rename `RedundantParentheses` -> `ParenthesesAroundCondition`
Also rename the option: `parenthesized_assignments` -> `allow_safe_assignment`
2022-11-18 21:06:51 +01:00
Sijawusz Pur Rahnama 0b0a815c31 Add additional test case 2022-11-18 07:04:51 +01:00
Sijawusz Pur Rahnama eabe463386 Instead of adding the new rule to support enforcing parens around assignments, refactor existing `RedundantParentheses` rule 2022-11-18 05:27:05 +01:00
Sijawusz Pur Rahnama 94a271b2a1 Add `Style/ParenthesizedAssignments` rule 2022-11-17 21:32:47 +01:00
Sijawusz Pur Rahnama 496e8930e2
Merge pull request #303 from crystal-ameba/Sija/lint-literal-assignments-in-expressions-rule
Add `Lint/LiteralAssignmentsInExpressions` rule
2022-11-17 14:19:17 +01:00
Sijawusz Pur Rahnama 243071700d
Merge pull request #306 from crystal-ameba/Sija/fix-typos
Fix typos throughout the code
2022-11-16 18:42:22 +01:00
Sijawusz Pur Rahnama 95d68114c7 Fix typos throughout the code 2022-11-16 16:55:32 +01:00
Sijawusz Pur Rahnama f9b6b17657
Merge pull request #305 from crystal-ameba/Sija/followup-to-pr-300
Few more readability refactors
2022-11-16 16:26:59 +01:00
Sijawusz Pur Rahnama 5c08b64e72 Add `Lint/LiteralAssignmentsInExpressions` rule 2022-11-16 15:08:41 +01:00
Sijawusz Pur Rahnama 28e2871165
Merge pull request #301 from crystal-ameba/Sija/style-redundant-parentheses-rule
Add `Style/RedundantParentheses` rule
2022-11-16 12:22:39 +01:00
Sijawusz Pur Rahnama b5ac5990ec
Merge pull request #304 from crystal-ameba/Sija/refactor-ast-util-literal 2022-11-16 11:01:03 +01:00
Sijawusz Pur Rahnama 935296b041 Refactor ternary handling in `Style/RedundantParentheses` rule 2022-11-16 03:54:31 +01:00
Sijawusz Pur Rahnama e54029d8ed Few more readability refactors 2022-11-15 20:55:32 +01:00
Sijawusz Pur Rahnama 76a4209706 Tweak comments in `AST::Util` 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama 2fb37da80f Refactor `AST::Util#literal?` helper 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama 3340613a6a Fix newly found issue 2022-11-15 15:17:32 +01:00
Sijawusz Pur Rahnama cbf5d3de74 Add `Style/RedundantParentheses` rule 2022-11-15 15:17:32 +01:00
Vitalii Elenhaupt cc687d0281
Bump v1.3.1 2022-11-15 09:15:15 +02:00
Sijawusz Pur Rahnama 04b19a60db
Merge pull request #300 from crystal-ameba/Sija/some-refactors
Misc refactors
2022-11-14 17:27:29 +01:00
Sijawusz Pur Rahnama db5eee76cb
Merge pull request #299 from crystal-ameba/Sija/refactor-style-predicate-name-rule 2022-11-14 14:07:33 +01:00
Sijawusz Pur Rahnama e668ba5bf5 Readability-related refactors 2022-11-14 02:26:52 +01:00
Sijawusz Pur Rahnama a6ebb48f14 Remove redundant parentheses in `if` expressions
+ `elsif` -> `case`
2022-11-14 01:52:07 +01:00
Sijawusz Pur Rahnama d1bfdaabeb Use `#in?` instead of `#includes?` in several places
Because:

1. it’s more semantically descriptive
2. it’s shorter
2022-11-14 01:18:43 +01:00
Sijawusz Pur Rahnama ed6085e6a6 Several refactors in `Style/GuardClause` rule
Mostly readability related
2022-11-14 01:18:43 +01:00
Sijawusz Pur Rahnama 353c0a1583 Fix typo + add `NOTE` pragma 2022-11-14 01:05:13 +01:00
Sijawusz Pur Rahnama 5db7a2cf5a Turn on `Style/PredicateName` rule by default 2022-11-13 20:12:39 +01:00
Sijawusz Pur Rahnama 52bf0a5be4 Refactor `Style/PredicateName` rule
Do not report `has_<name>?` method names
2022-11-13 20:12:23 +01:00
Vitalii Elenhaupt 2811352cae
Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly
Fix specs on Crystal nightly
2022-11-13 21:07:29 +02:00
Sijawusz Pur Rahnama df4b49798e
Merge pull request #297 from crystal-ameba/Sija/fix-issue-295
Fix the edge case re: free var comparison
2022-11-13 17:35:43 +01:00
Sijawusz Pur Rahnama 5f46612e89 Remove obsolete spec 2022-11-13 01:32:49 +01:00
Sijawusz Pur Rahnama 84540d2a22 Change to alternative approach skipping all macro contexts 2022-11-13 01:25:24 +01:00
Sijawusz Pur Rahnama 5491d31b5f Fix the edge case re: free var comparison 2022-11-13 01:24:59 +01:00
Sijawusz Pur Rahnama 1a26ebcfed
Merge pull request #296 from crystal-ameba/Sija/dockerfile-alpine-edge 2022-11-10 11:03:41 +01:00
Sijawusz Pur Rahnama 2805e12b9c
Use `alpine:edge` for ameba builder image 2022-11-10 04:42:13 +01:00
Vitalii Elenhaupt 35ff16206c
Bump v1.3.0 2022-11-03 15:21:53 +02:00