294 commits

Author	SHA1	Message	Date
Sijawusz Pur Rahnama	a892cd43b0	Add Performance/JoinAfterMap rule	2021-01-17 16:57:15 +01:00
Sijawusz Pur Rahnama	1a091c1f1a	Optimize rules (#185) ... * Replace pointless interpolations with actual values * Rules optimizations * Stylistic refactors * Remove extraneous blank lines * Remove some instances of .not_nil! usage	2021-01-17 14:16:04 +02:00
Vitalii Elenhaupt	44290a6a5d	Handle case when compiler reports incorrect node location ... fixes #168	2020-10-23 10:41:17 +03:00
Vitalii Elenhaupt	f8d57345d4	Merge branch 'develop'	2020-08-26 22:46:03 +03:00
Vitalii Elenhaupt	b5bd76dfa8	Useless Assign: ignore variables with '_' prefix ... closes #164	2020-08-20 21:15:58 +03:00
Vitalii Elenhaupt	d650ca5477	Incorrectly reporting shadowingOuterLocalVar within macro included ... closes #161	2020-07-15 10:18:12 +03:00
Vitalii Elenhaupt	7f501a1df5	RedundantStringCoercion: do not report to_s with named args ... closes #160	2020-06-24 09:26:03 +03:00
Vladislav Trotsenko	bdeb6e3391	Feature/Layout trailing lines, final newline checkup (#152)	2020-05-05 16:52:24 +03:00
Vitalii Elenhaupt	478da94c20	Allow constants to be in PascalCase (i.e. Log, SuperConstant) ... closes #148	2020-04-13 09:38:05 +03:00
Sijawusz Pur Rahnama	1a25583036	Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict (#146)	2020-04-11 09:55:41 +03:00
Vitalii Elenhaupt	458c492730	Do not report shadowing outer local var is var is declared below the ... shadowed var closes #144	2020-04-10 10:44:42 +03:00
Vitalii Elenhaupt	99c65b5a28	New rule: Lint/BadDirective (#143) ... * New rule: Lint/BadDirective * Address PR feedback	2020-04-06 15:10:34 +03:00
Vitalii Elenhaupt	db6b54e63c	New rule: Style/IsANil	2020-03-29 19:45:13 +03:00
Vitalii Elenhaupt	04497feeed	Lint/LiteralInInterpolation: properly report node position	2020-03-27 19:44:04 +02:00
Vitalii Elenhaupt	59bc021e57	Do not report if Object#to_s is called without receiver	2020-03-26 23:51:54 +02:00
Vitalii Elenhaupt	ff1669ebe8	New rule: Lint/RedundantStringCoercion	2020-03-26 16:26:27 +02:00
Vitalii Elenhaupt	a6958ab455	New rule: EmptyLoop	2020-03-26 10:27:00 +02:00
Vitalii Elenhaupt	4f185db0a2	New rule: SharedVarInSpawn ... closes #132	2020-03-25 17:52:20 +02:00
Vitalii Elenhaupt	0002c36fae	RedundantNext params	2020-03-24 18:27:49 +02:00
Vitalii Elenhaupt	a5dd07e9e4	New rule: RedundantNext ... closes #131	2020-03-24 18:06:01 +02:00
Vitalii Elenhaupt	946ec67fae	Include binary op node to redundant return	2020-03-22 20:12:24 +02:00
Vitalii Elenhaupt	aff723b682	Incorrectly reporting shadowingOuterLocalVar within macro included ... closes #129	2020-02-15 20:49:47 +02:00
Vitalii Elenhaupt	74dfa0b934	Lint/UselessAssign: ignore transformed assignemnts by the compiler ... closes #127	2020-01-11 23:51:28 +02:00
Vitalii Elenhaupt	6b56c87e78	Shadowing via short instance variable syntax ... closes #122	2019-11-11 15:51:09 +02:00
Vitalii Elenhaupt	fde321f7e6	New rule: RedundantWithObject (#121)	2019-11-10 09:47:30 +02:00
Vitalii Elenhaupt	b6cc454039	New rule: RedundantWithIndex (#120)	2019-11-10 09:29:17 +02:00
Vitalii Elenhaupt	904b5beec2	Lint/UnusedArgument: fails to recognized used argument inside macro ... closes #117	2019-10-27 21:32:55 +02:00
Vitalii Elenhaupt	677c75716f	Typeof scope	2019-10-27 21:22:33 +02:00
Vitalii Elenhaupt	b868d88a85	CyclomaticCompexity: report onle def name	2019-07-12 23:33:08 +03:00
Vitalii Elenhaupt	ffa5dc9b4c	Crystal 0.29 fixes (#109) ... * Fixes vs crystal head * Use crystal nightly * Remove trailing ? from local variable * Do not use ? in the lhs ref https://github.com/crystal-lang/crystal/issues/6685#issuecomment-419758587 * Upgrade to crystal 0.29.0 (warnings free) (#108) * Remove trailing ? from local variable (take 2) * Fix Time.now deprecation warnings * Remove Crystal nightly	2019-06-06 19:10:26 +03:00
Vitalii Elenhaupt	037d1dde74	Performance/FirstLastAfterFilter: ignore .first/.last with args ... closes #104	2019-06-03 18:25:48 +03:00
Vitalii Elenhaupt	94e1d4567a	Properly report performance rules in macros ... closes #102	2019-05-05 18:05:08 +03:00
Vitalii Elenhaupt	f6a57f9272	Set default severities	2019-04-14 12:15:38 +03:00
Vitalii Elenhaupt	3a71b86193	Properly report literals (#96)	2019-03-23 19:20:32 +02:00
Sijawusz Pur Rahnama	e8a68a80d5	Fix several misspellings (#94)	2019-02-23 07:06:28 +02:00
Hannes Käufler	e850bff60f	Hk cyclomatic complexity (#92) ... * Proof of concept for cyclomatic complexity * Enable configurability of rule * Use the same nodes to increment the complexity as rubocop * Fix typo in test description * Properly indent code and simplify macro * Move metric into metrics * Cover a violation supressed by increased threshold * Extract visitor into its own file * Document cyclomatic complexity rule and visitor * Refactor specs to use a macro * Indent code inside macro * Replace array with tuple for string formatting. `Tuple` is stack based, whereas `Array` is allocated on the heap increasing GC pressure. * Fix formatting * Enable cyclomatic complexity rule by default	2019-02-16 21:03:44 +02:00
Vitalii Elenhaupt	866af184f1	Redundant return (#87)	2018-12-30 09:04:59 +02:00
Vitalii Elenhaupt	32ac199162	Correct trailing blank line position	2018-12-24 00:44:15 +02:00
Vitalii Elenhaupt	60ce034f1b	UnusedArgument: fix crystal upgrade regression	2018-12-12 22:21:33 +02:00
Vitalii Elenhaupt	f8dab3bc34	MethodNames: correct reported location/end_location	2018-11-25 00:56:21 +02:00
Vitalii Elenhaupt	e951c0772a	ConstantNames: correct reported end_location	2018-11-25 00:37:46 +02:00
Vitalii Elenhaupt	9885457227	Track issue.end_location properly	2018-11-24 19:38:13 +02:00
V. Elenhaupt	0fd5890738	Extend UnreachableCode rule: handle control flow (#83)	2018-11-22 10:38:32 +02:00
Vitalii Elenhaupt	eca0f3f350	Handle raise, exit, abort in unreachable code	2018-11-11 20:33:48 +02:00
Vitalii Elenhaupt	67d76116f7	Basic implementation of UnreachableCode rule	2018-11-05 21:39:27 +02:00
Vitalii Elenhaupt	12aa48c98f	Fix Style/RedundantBegin: begin-end in a proc literal ... closes #80	2018-09-22 21:58:38 +03:00
Vitalii Elenhaupt	d7b0e10d1e	Normalize sources for tests	2018-09-07 15:07:03 +03:00
V. Elenhaupt	cb5f802012	Correctly process record declaration at a top level (#78)	2018-09-07 00:47:02 +03:00
V. Elenhaupt	fd78d17c40	New rule: Performance/FirstLastAfterFilter (#76)	2018-09-06 17:59:11 +03:00
Vitalii Elenhaupt	a1b34eb7be	New rule: Performance/AnyAfterFilter	2018-09-03 22:55:10 +03:00