iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Crystal 0.29 fixes (#109)

Browse source 
* Fixes vs crystal head

* Use crystal nightly

* Remove trailing ? from local variable

* Do not use ? in the lhs

ref https://github.com/crystal-lang/crystal/issues/6685#issuecomment-419758587

* Upgrade to crystal 0.29.0 (warnings free) (#108)

* Remove trailing ? from local variable (take 2)

* Fix Time.now deprecation warnings

* Remove Crystal nightly
This commit is contained in:
Vitalii Elenhaupt 2019-06-06 19:10:26 +03:00 • committed by GitHub
parent 633a08f9c7
commit ffa5dc9b4c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

2
spec/ameba/rule/lint/useless_assign_spec.cr
View file

@ -228,7 +228,7 @@ module Ameba::Rule::Lint
it "does not report if global var" do
s = Source.new %(
def method
$? = 3
$1 = 3
end
)
subject.catch(s).should be_valid

4
spec/ameba/rule/performance/size_after_filter_spec.cr
View file

@ -66,8 +66,8 @@ module Ameba::Rule::Performance
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:4"
issue.end_location.to_s.should eq "source.cr:1:25"
issue.location.to_s.should eq "source.cr:2:4"
issue.end_location.to_s.should eq "source.cr:2:25"
issue.message.should eq "Use `count {...}` instead of `reject {...}.size`."
end
end