iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don’t allocate the array on every call

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2021-01-17 17:49:45 +01:00
parent 5e58a60ade
commit fd4b2f309c
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ameba/rule/lint/comparison_to_boolean.cr
View file

@ -25,10 +25,11 @@ module Ameba::Rule::Lint
description "Disallows comparison to booleans" description "Disallows comparison to booleans"
end end
MSG = "Comparison to a boolean is pointless" MSG = "Comparison to a boolean is pointless"
OP_NAMES = %w(== != ===)
def test(source, node : Crystal::Call) def test(source, node : Crystal::Call)
comparison = %w(== != ===).includes?(node.name) comparison = node.name.in?(OP_NAMES)
to_boolean = node.args.first?.try &.is_a?(Crystal::BoolLiteral) || to_boolean = node.args.first?.try &.is_a?(Crystal::BoolLiteral) ||
node.obj.is_a?(Crystal::BoolLiteral) node.obj.is_a?(Crystal::BoolLiteral)