iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rename Error to Issue

Browse source
This commit is contained in:
Vitalii Elenhaupt 2018-06-11 00:15:12 +03:00 • committed by V. Elenhaupt
parent e1b51f62a5
commit f8d14d4222
81 changed files with 475 additions and 384 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/ameba/formatter/disabled_formatter_spec.cr
View file

@ -16,8 +16,8 @@ module Ameba::Formatter
path = "source.cr"
s = Source.new("", path).tap do |source|
source.error(ErrorRule.new, 1, 2, "ErrorRule", :disabled)
source.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
source.add_issue(ErrorRule.new, {1, 2}, message: "ErrorRule", status: :disabled)
source.add_issue(NamedRule.new, location: {2, 2}, message: "NamedRule", status: :disabled)
end
subject.finished [s]
log = output.to_s
@ -30,8 +30,9 @@ module Ameba::Formatter
it "does not write not-disabled rules" do
s = Source.new("", "source.cr").tap do |source|
source.error(ErrorRule.new, 1, 2, "ErrorRule")
source.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
source.add_issue(ErrorRule.new, {1, 2}, "ErrorRule")
source.add_issue(NamedRule.new, location: {2, 2},
message: "NamedRule", status: :disabled)
end
subject.finished [s]
output.to_s.should_not contain ErrorRule.name

15
spec/ameba/formatter/dot_formatter_spec.cr
View file

@ -20,7 +20,7 @@ module Ameba::Formatter
it "writes invalid source" do
s = Source.new ""
s.error DummyRule.new, nil, "message"
s.add_issue DummyRule.new, Crystal::Nop.new, "message"
subject.source_finished s
output.to_s.should contain "F"
end
@ -37,11 +37,11 @@ module Ameba::Formatter
output.to_s.should contain "Finished in"
end
context "when errors found" do
it "writes each error" do
context "when issues found" do
it "writes each issue" do
s = Source.new("").tap do |source|
source.error(DummyRule.new, 1, 1, "DummyRuleError")
source.error(NamedRule.new, 1, 2, "NamedRuleError")
source.add_issue(DummyRule.new, {1, 1}, "DummyRuleError")
source.add_issue(NamedRule.new, {1, 2}, "NamedRuleError")
end
subject.finished [s]
log = output.to_s
@ -50,9 +50,10 @@ module Ameba::Formatter
log.should contain "NamedRuleError"
end
it "does not write disabled errors" do
it "does not write disabled issues" do
s = Source.new ""
s.error(DummyRule.new, 1, 1, "DummyRuleError", :disabled)
s.add_issue(DummyRule.new, location: {1, 1},
message: "DummyRuleError", status: :disabled)
subject.finished [s]
output.to_s.should contain "1 inspected, 0 failures."
end

8
spec/ameba/formatter/flycheck_formatter_spec.cr
View file

@ -16,9 +16,9 @@ module Ameba::Formatter
end
context "when problems found" do
it "reports an error" do
it "reports an issue" do
s = Source.new "a = 1", "source.cr"
s.error DummyRule.new, 1, 2, "message"
s.add_issue DummyRule.new, {1, 2}, "message"
subject = flycheck
subject.source_finished s
subject.output.to_s.should eq(
@ -28,7 +28,7 @@ module Ameba::Formatter
it "properly reports multi-line message" do
s = Source.new "a = 1", "source.cr"
s.error DummyRule.new, 1, 2, "multi\nline"
s.add_issue DummyRule.new, {1, 2}, "multi\nline"
subject = flycheck
subject.source_finished s
subject.output.to_s.should eq(
@ -38,7 +38,7 @@ module Ameba::Formatter
it "reports nothing if location was not set" do
s = Source.new "a = 1", "source.cr"
s.error DummyRule.new, nil, "message"
s.add_issue DummyRule.new, Crystal::Nop.new, "message"
subject = flycheck
subject.source_finished s
subject.output.to_s.should eq ""

24
spec/ameba/formatter/json_formatter_spec.cr
View file

@ -31,26 +31,26 @@ module Ameba
it "shows rule name" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message1"
s.add_issue DummyRule.new, {1, 2}, "message1"
result = get_result [s]
result["sources"][0]["errors"][0]["rule_name"].should eq DummyRule.name
result["sources"][0]["issues"][0]["rule_name"].should eq DummyRule.name
end
it "shows a message" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message"
s.add_issue DummyRule.new, {1, 2}, "message"
result = get_result [s]
result["sources"][0]["errors"][0]["message"].should eq "message"
result["sources"][0]["issues"][0]["message"].should eq "message"
end
it "shows error location" do
it "shows issue location" do
s = Source.new ""
s.error DummyRule.new, 1, 2, "message"
s.add_issue DummyRule.new, {1, 2}, "message"
result = get_result [s]
location = result["sources"][0]["errors"][0]["location"]
location = result["sources"][0]["issues"][0]["location"]
location["line"].should eq 1
location["column"].should eq 2
end
@ -62,16 +62,16 @@ module Ameba
result["summary"]["target_sources_count"].should eq 2
end
it "shows errors count" do
it "shows issues count" do
s1 = Source.new ""
s1.error DummyRule.new, 1, 2, "message1"
s1.error DummyRule.new, 1, 2, "message2"
s1.add_issue DummyRule.new, {1, 2}, "message1"
s1.add_issue DummyRule.new, {1, 2}, "message2"
s2 = Source.new ""
s2.error DummyRule.new, 1, 2, "message3"
s2.add_issue DummyRule.new, {1, 2}, "message3"
result = get_result [s1, s2]
result["summary"]["errors_count"].should eq 3
result["summary"]["issues_count"].should eq 3
end
end
end

4
spec/ameba/formatter/todo_formatter_spec.cr
View file

@ -6,7 +6,7 @@ module Ameba
formatter = Formatter::TODOFormatter.new IO::Memory.new, file
s = Source.new "a = 1", "source.cr"
s.error DummyRule.new, 1, 2, "message"
s.add_issue DummyRule.new, {1, 2}, "message"
formatter.finished [s]
file.to_s
@ -57,7 +57,7 @@ module Ameba
formatter = Formatter::TODOFormatter.new IO::Memory.new, file
s = Source.new "def invalid_syntax"
s.error Rule::Syntax.new, 1, 2, "message"
s.add_issue Rule::Syntax.new, {1, 2}, "message"
formatter.finished [s]
content = file.to_s