mirror of
				https://gitea.invidious.io/iv-org/shard-ameba.git
				synced 2024-08-15 00:53:29 +00:00 
			
		
		
		
	New rule: Style/IsANil
This commit is contained in:
		
							parent
							
								
									02f4afaa64
								
							
						
					
					
						commit
						db6b54e63c
					
				
					 3 changed files with 84 additions and 0 deletions
				
			
		
							
								
								
									
										45
									
								
								spec/ameba/rule/style/is_a_nil_spec.cr
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										45
									
								
								spec/ameba/rule/style/is_a_nil_spec.cr
									
										
									
									
									
										Normal file
									
								
							| 
						 | 
				
			
			@ -0,0 +1,45 @@
 | 
			
		|||
require "../../../spec_helper"
 | 
			
		||||
 | 
			
		||||
module Ameba::Rule::Style
 | 
			
		||||
  describe IsANil do
 | 
			
		||||
    subject = IsANil.new
 | 
			
		||||
 | 
			
		||||
    it "doesn't report if there are no is_a?(Nil) calls" do
 | 
			
		||||
      s = Source.new %(
 | 
			
		||||
        a = 1
 | 
			
		||||
        a.nil?
 | 
			
		||||
        a.is_a?(NilLiteral)
 | 
			
		||||
        a.is_a?(Custom::Nil)
 | 
			
		||||
      )
 | 
			
		||||
      subject.catch(s).should be_valid
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    it "reports if there is a call to is_a?(Nil) without receiver" do
 | 
			
		||||
      s = Source.new %(
 | 
			
		||||
        is_a?(Nil)
 | 
			
		||||
      )
 | 
			
		||||
      subject.catch(s).should_not be_valid
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    it "reports if there is a call to is_a?(Nil) with receiver" do
 | 
			
		||||
      s = Source.new %(
 | 
			
		||||
        a.is_a?(Nil)
 | 
			
		||||
      )
 | 
			
		||||
      subject.catch(s).should_not be_valid
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    it "reports rule, location and message" do
 | 
			
		||||
      s = Source.new %(
 | 
			
		||||
        nil.is_a? Nil
 | 
			
		||||
      ), "source.cr"
 | 
			
		||||
      subject.catch(s).should_not be_valid
 | 
			
		||||
      s.issues.size.should eq 1
 | 
			
		||||
 | 
			
		||||
      issue = s.issues.first
 | 
			
		||||
      issue.rule.should_not be_nil
 | 
			
		||||
      issue.location.to_s.should eq "source.cr:1:11"
 | 
			
		||||
      issue.end_location.to_s.should eq "source.cr:1:13"
 | 
			
		||||
      issue.message.should eq IsANil::MSG
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
end
 | 
			
		||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue