iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Extend JoinAfterMap to check also calls to sum/product and rename it to MapInsteadOfBlock (#190)

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2021-01-18 16:42:50 +01:00 • committed by GitHub
parent e9ec91654c
commit d2fa75280f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/ameba/rule/performance/join_after_map_spec.cr → spec/ameba/rule/performance/map_instead_of_block_spec.cr
View file

@ -1,13 +1,14 @@
require "../../../spec_helper"
module Ameba::Rule::Performance
subject = JoinAfterMap.new
subject = MapInsteadOfBlock.new
describe JoinAfterMap do
describe MapInsteadOfBlock do
it "passes if there is no potential performance improvements" do
source = Source.new %(
(1..3).join(&.to_s)
(1..3).join('.', &.to_s)
(1..3).sum(&.*(2))
(1..3).product(&.*(2))
)
subject.catch(source).should be_valid
end
@ -52,7 +53,7 @@ module Ameba::Rule::Performance
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:8"
issue.end_location.to_s.should eq "source.cr:1:24"
issue.message.should eq "Use `join(separator) {...}` instead of `map {...}.join(separator)`"
issue.message.should eq "Use `join {...}` instead of `map {...}.join`"
end
end
end