iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Correctly process record declaration at a top level (#78)

Browse source
This commit is contained in:
V. Elenhaupt 2018-09-07 00:47:02 +03:00 • committed by GitHub
parent 18ac04d992
commit cb5f802012
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 52 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

29
spec/ameba/rule/lint/useless_assign_spec.cr
View file

@ -419,6 +419,35 @@ module Ameba::Rule::Lint
)
subject.catch(s).should be_valid
end
it "doesn't report if this is a record declaration" do
s = Source.new %(
record Foo, foo = "foo"
)
subject.catch(s).should be_valid
end
it "does not report if assignment is referenced after the record declaration" do
s = Source.new %(
foo = 2
record Bar, foo = 3 # foo = 3 is not parsed as assignment
puts foo
)
subject.catch(s).should be_valid
end
it "reports if assignment is not referenced after the record declaration" do
s = Source.new %(
foo = 2
record Bar, foo = 3
), "source.cr"
subject.catch(s).should_not be_valid
s.issues.size.should eq 1
issue = s.issues.first
issue.location.to_s.should eq "source.cr:2:11"
issue.message.should eq "Useless assignment to variable `foo`"
end
end
context "branching" do