Rename Severity.from_name to Severity.parse

This commit is contained in:
Vitalii Elenhaupt 2019-04-26 18:15:36 +03:00
parent af395a3c13
commit ca5e894e0b
No known key found for this signature in database
GPG key ID: 7558EF3A4056C706
3 changed files with 12 additions and 12 deletions

View file

@ -22,22 +22,22 @@ module Ameba
end end
end end
describe ".from_name" do describe ".parse" do
it "creates error severity by name" do it "creates error severity by name" do
Severity.from_name("Error").should eq Severity::Error Severity.parse("Error").should eq Severity::Error
end end
it "creates warning severity by name" do it "creates warning severity by name" do
Severity.from_name("Warning").should eq Severity::Warning Severity.parse("Warning").should eq Severity::Warning
end end
it "creates refactoring severity by name" do it "creates refactoring severity by name" do
Severity.from_name("Refactoring").should eq Severity::Refactoring Severity.parse("Refactoring").should eq Severity::Refactoring
end end
it "raises when name is incorrect" do it "raises when name is incorrect" do
expect_raises(Exception, "Incorrect severity name BadName. Try one of [Error, Warning, Refactoring]") do expect_raises(Exception, "Incorrect severity name BadName. Try one of [Error, Warning, Refactoring]") do
Severity.from_name("BadName") Severity.parse("BadName")
end end
end end
end end

View file

@ -85,7 +85,7 @@ module Ameba::Cli
end end
parser.on("--fail-level SEVERITY", "Change the level of failure to exit. Defaults to Refactoring") do |level| parser.on("--fail-level SEVERITY", "Change the level of failure to exit. Defaults to Refactoring") do |level|
opts.fail_level = Severity.from_name(level) opts.fail_level = Severity.parse(level)
end end
parser.on("-e", "--explain PATH:line:column", parser.on("-e", "--explain PATH:line:column",

View file

@ -16,14 +16,14 @@ module Ameba
# Creates Severity by the name. # Creates Severity by the name.
# #
# ``` # ```
# Severity.from_name('refactoring') # => Severity::Refactoring # Severity.parse('refactoring') # => Severity::Refactoring
# Severity.from_name('foo-bar') # => Exception: Incorrect severity name.. # Severity.parse('foo-bar') # => Exception: Incorrect severity name
# ``` # ```
# #
def self.from_name(name : String) def self.parse(name : String)
parse(name) super name
rescue ArgumentError rescue ArgumentError
raise "Incorrect severity name #{name}. Try one of #{Severity.values}" raise "Incorrect severity name #{name}. Try one of #{values}"
end end
end end
@ -35,7 +35,7 @@ module Ameba
end end
case value = node.value case value = node.value
when String then Severity.from_name(value) when String then Severity.parse(value)
when Nil then nil when Nil then nil
else else
raise "Incorrect severity: #{value}" raise "Incorrect severity: #{value}"